Don't add expired transactions to invalidUnconfirmedTransactions, as there is no need to keep track of these.

This commit is contained in:
CalDescent 2022-02-06 11:55:07 +00:00
parent 0fe2f226bc
commit 8c03164ea5

View File

@ -1350,12 +1350,14 @@ public class Controller extends Thread {
if (validationResult != ValidationResult.OK) {
LOGGER.trace(() -> String.format("Ignoring invalid (%s) %s transaction %s", validationResult.name(), transactionData.getType().name(), Base58.encode(transactionData.getSignature())));
if (validationResult != ValidationResult.TIMESTAMP_TOO_OLD) {
Long now = NTP.getTime();
if (now != null && now - transactionData.getTimestamp() > INVALID_TRANSACTION_STALE_TIMEOUT) {
LOGGER.debug("Adding stale invalid transaction {} to invalidUnconfirmedTransactions...", Base58.encode(transactionData.getSignature()));
// Invalid, unconfirmed transaction has become stale - add to invalidUnconfirmedTransactions so that we don't keep requesting it
invalidUnconfirmedTransactions.put(transactionData.getSignature(), NTP.getTime());
}
}
iterator.remove();
continue;
}