From cc951060197b62cf3e4c4debb4e37d1825f35338 Mon Sep 17 00:00:00 2001 From: AlphaX-Projects <77661270+AlphaX-Projects@users.noreply.github.com> Date: Sat, 29 Jun 2024 12:15:55 +0200 Subject: [PATCH] Removed unnecessary continue (last statement in a loop) --- .../java/org/qortal/api/resource/AddressesResource.java | 3 +-- src/main/java/org/qortal/controller/BlockMinter.java | 3 +-- src/main/java/org/qortal/controller/Controller.java | 3 +-- .../java/org/qortal/controller/OnlineAccountsManager.java | 1 - .../controller/arbitrary/ArbitraryDataCleanupManager.java | 6 ++---- .../qortal/controller/arbitrary/ArbitraryDataManager.java | 6 ++---- .../controller/arbitrary/ArbitraryDataStorageManager.java | 2 -- src/main/java/org/qortal/controller/tradebot/TradeBot.java | 3 +-- src/test/java/org/qortal/test/apps/SyncReport.java | 3 +-- 9 files changed, 9 insertions(+), 21 deletions(-) diff --git a/src/main/java/org/qortal/api/resource/AddressesResource.java b/src/main/java/org/qortal/api/resource/AddressesResource.java index 688b17fc..66d8412c 100644 --- a/src/main/java/org/qortal/api/resource/AddressesResource.java +++ b/src/main/java/org/qortal/api/resource/AddressesResource.java @@ -233,8 +233,7 @@ public class AddressesResource { } } catch (DataException e) { - continue; - } + } } // Sort by level diff --git a/src/main/java/org/qortal/controller/BlockMinter.java b/src/main/java/org/qortal/controller/BlockMinter.java index 7272ee95..91dd12bb 100644 --- a/src/main/java/org/qortal/controller/BlockMinter.java +++ b/src/main/java/org/qortal/controller/BlockMinter.java @@ -159,8 +159,7 @@ public class BlockMinter extends Thread { int level = mintingAccount.getEffectiveMintingLevel(); if (level < BlockChain.getInstance().getMinAccountLevelForBlockSubmissions()) { madi.remove(); - continue; - } + } } // Needs a mutable copy of the unmodifiableList diff --git a/src/main/java/org/qortal/controller/Controller.java b/src/main/java/org/qortal/controller/Controller.java index 30537b32..2ea376bd 100644 --- a/src/main/java/org/qortal/controller/Controller.java +++ b/src/main/java/org/qortal/controller/Controller.java @@ -1921,8 +1921,7 @@ public class Controller extends Thread { // Disregard peers that don't have a recent block if (peerChainTipData.getTimestamp() == null || peerChainTipData.getTimestamp() < minLatestBlockTimestamp) { iterator.remove(); - continue; - } + } } return peers; diff --git a/src/main/java/org/qortal/controller/OnlineAccountsManager.java b/src/main/java/org/qortal/controller/OnlineAccountsManager.java index 9518b7f3..d37b2aef 100644 --- a/src/main/java/org/qortal/controller/OnlineAccountsManager.java +++ b/src/main/java/org/qortal/controller/OnlineAccountsManager.java @@ -538,7 +538,6 @@ public class OnlineAccountsManager { if (++i > 1 + 1) { iterator.remove(); - continue; } } } catch (DataException e) { diff --git a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataCleanupManager.java b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataCleanupManager.java index 8611ab88..7b434acb 100644 --- a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataCleanupManager.java +++ b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataCleanupManager.java @@ -208,8 +208,7 @@ public class ArbitraryDataCleanupManager extends Thread { Base58.encode(arbitraryTransactionData.getSignature()))); ArbitraryTransactionUtils.convertFileToChunks(arbitraryTransactionData, now, STALE_FILE_TIMEOUT); - continue; - } + } } } catch (DataException e) { @@ -284,8 +283,7 @@ public class ArbitraryDataCleanupManager extends Thread { } } catch (DataException e) { - continue; - } + } } return pathList; diff --git a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataManager.java b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataManager.java index 398dcb5b..37801f50 100644 --- a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataManager.java +++ b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataManager.java @@ -230,8 +230,7 @@ public class ArbitraryDataManager extends Thread { // Remove transactions that we already have local data for if (hasLocalData(arbitraryTransaction)) { iterator.remove(); - continue; - } + } } if (signatures.isEmpty()) { @@ -313,8 +312,7 @@ public class ArbitraryDataManager extends Thread { // Remove transactions that we already have local data for if (hasLocalMetadata(arbitraryTransaction)) { iterator.remove(); - continue; - } + } } if (signatures.isEmpty()) { diff --git a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataStorageManager.java b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataStorageManager.java index f6b2dc0a..91cb9965 100644 --- a/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataStorageManager.java +++ b/src/main/java/org/qortal/controller/arbitrary/ArbitraryDataStorageManager.java @@ -291,7 +291,6 @@ public class ArbitraryDataStorageManager extends Thread { arbitraryTransactionDataList.add(arbitraryTransactionData); } catch (DataException e) { - continue; } } @@ -345,7 +344,6 @@ public class ArbitraryDataStorageManager extends Thread { } } catch (Exception e) { - continue; } } diff --git a/src/main/java/org/qortal/controller/tradebot/TradeBot.java b/src/main/java/org/qortal/controller/tradebot/TradeBot.java index 43330b07..3699bd2a 100644 --- a/src/main/java/org/qortal/controller/tradebot/TradeBot.java +++ b/src/main/java/org/qortal/controller/tradebot/TradeBot.java @@ -724,8 +724,7 @@ public class TradeBot implements Listener { } catch (DataException e) { LOGGER.info("Unable to determine failed state of AT {}", crossChainTradeData.qortalAtAddress); - continue; - } + } } return updatedCrossChainTrades; diff --git a/src/test/java/org/qortal/test/apps/SyncReport.java b/src/test/java/org/qortal/test/apps/SyncReport.java index 402ae118..803878c8 100644 --- a/src/test/java/org/qortal/test/apps/SyncReport.java +++ b/src/test/java/org/qortal/test/apps/SyncReport.java @@ -180,8 +180,7 @@ public class SyncReport { // Sync went bad syncEvent = null; - continue; - } + } } for (SyncEvent se : syncEvents) {