AlphaX/qortal
1
0
Fork 0
forked from Qortal/qortal
Code Issues Pull Requests Projects Releases Wiki Activity

Fix for invalid balance (and transaction amount) when there are no outputs relating to this wallet.

Browse Source
This commit is contained in:
CalDescent 2022-02-14 22:53:30 +00:00
parent 6c1c814aca
commit fd0a6ec71f
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/org/qortal/crosschain/Bitcoiny.java
View File

@ -470,6 +470,8 @@ public abstract class Bitcoiny implements ForeignBlockchain {
List<SimpleTransaction.Input> inputs = new ArrayList<>(); List<SimpleTransaction.Input> inputs = new ArrayList<>();
List<SimpleTransaction.Output> outputs = new ArrayList<>(); List<SimpleTransaction.Output> outputs = new ArrayList<>();
boolean anyOutputAddressInWallet = false;
for (BitcoinyTransaction.Input input : t.inputs) { for (BitcoinyTransaction.Input input : t.inputs) {
try { try {
BitcoinyTransaction t2 = getTransaction(input.outputTxHash); BitcoinyTransaction t2 = getTransaction(input.outputTxHash);
@ -502,6 +504,7 @@ public abstract class Bitcoiny implements ForeignBlockchain {
amount += output.value; amount += output.value;
} }
addressInWallet = true; addressInWallet = true;
anyOutputAddressInWallet = true;
} }
outputs.add(new SimpleTransaction.Output(address, output.value, addressInWallet)); outputs.add(new SimpleTransaction.Output(address, output.value, addressInWallet));
} }
@ -510,6 +513,13 @@ public abstract class Bitcoiny implements ForeignBlockchain {
} }
} }
long fee = totalInputAmount - totalOutputAmount; long fee = totalInputAmount - totalOutputAmount;
if (!anyOutputAddressInWallet) {
// No outputs relate to this wallet - check if any inputs did (which is signified by a positive total)
if (total > 0) {
amount = total * -1;
}
}
return new SimpleTransaction(t.txHash, t.timestamp, amount, fee, inputs, outputs); return new SimpleTransaction(t.txHash, t.timestamp, amount, fee, inputs, outputs);
} }