Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-12 02:05:53 +00:00
Code Issues Projects Releases Wiki Activity

Make bitcoinSerialize() return a copy by default, provide an unsafeBitcoinSerialize() method for high performance applications that are willing to deal with the extra API complexity.

Browse Source
This commit is contained in:
Mike Hearn 2011-11-25 10:12:29 +00:00
parent 9549d345a7
commit 00cb8a4abd
1 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/com/google/bitcoin/core/Message.java
View File

@ -98,7 +98,8 @@ public abstract class Message implements Serializable {
* as the length will be provided as part of the header. If unknown then set to Message.UNKNOWN_LENGTH * as the length will be provided as part of the header. If unknown then set to Message.UNKNOWN_LENGTH
* @throws ProtocolException * @throws ProtocolException
*/ */
Message(NetworkParameters params, byte[] msg, int offset, int protocolVersion, final boolean parseLazy, final boolean parseRetain, int length) throws ProtocolException { Message(NetworkParameters params, byte[] msg, int offset, int protocolVersion, final boolean parseLazy,
final boolean parseRetain, int length) throws ProtocolException {
this.parseLazy = parseLazy; this.parseLazy = parseLazy;
this.parseRetain = parseRetain; this.parseRetain = parseRetain;
this.protocolVersion = protocolVersion; this.protocolVersion = protocolVersion;
@ -262,6 +263,19 @@ public abstract class Message implements Serializable {
this.checksum = checksum; this.checksum = checksum;
} }
/**
* Returns a copy of the array returned by {@link Message#unsafeBitcoinSerialize()}, which is safe to mutate.
* If you need extra performance and can guarantee you won't write to the array, you can use the unsafe version.
*
* @return a freshly allocated serialized byte array
*/
public byte[] bitcoinSerialize() {
byte[] bytes = unsafeBitcoinSerialize();
byte[] copy = new byte[bytes.length];
System.arraycopy(bytes, 0, copy, 0, bytes.length);
return copy;
}
/** /**
* Serialize this message to a byte array that conforms to the bitcoin wire protocol. * Serialize this message to a byte array that conforms to the bitcoin wire protocol.
* <br/> * <br/>
@ -274,11 +288,12 @@ public abstract class Message implements Serializable {
* </ol> * </ol>
* *
* If condition 3 is not met then an copy of the relevant portion of the array will be returned. * If condition 3 is not met then an copy of the relevant portion of the array will be returned.
* Otherwise a full serialize will occur. * Otherwise a full serialize will occur. For this reason you should only use this API if you can guarantee you
* will treat the resulting array as read only.
* *
* @return * @return a byte array owned by this object, do NOT mutate it.
*/ */
public byte[] bitcoinSerialize() { public byte[] unsafeBitcoinSerialize() {
// 1st attempt to use a cached array. // 1st attempt to use a cached array.
if (bytes != null) { if (bytes != null) {
if (offset == 0 && length == bytes.length) { if (offset == 0 && length == bytes.length) {