Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-01-31 23:32:16 +00:00
Code Issues Projects Releases Wiki Activity

Fix a race condition in the memory pool code. Update issue 353.

Browse Source
This commit is contained in:
Mike Hearn 2013-03-19 14:55:12 +01:00
parent 8b437eaf95
commit 0548e983ed
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/com/google/bitcoin/core/MemoryPool.java
View File

@ -200,13 +200,14 @@ public class MemoryPool {
entry.tx = new WeakTransactionReference(tx, referenceQueue); entry.tx = new WeakTransactionReference(tx, referenceQueue);
Set<PeerAddress> addrs = entry.addresses; Set<PeerAddress> addrs = entry.addresses;
entry.addresses = null; entry.addresses = null;
// Copy the previously announced peers into the confidence and then clear it out. Unlock here
// because markBroadcastBy can trigger event listeners and thus inversions.
TransactionConfidence confidence = tx.getConfidence(); TransactionConfidence confidence = tx.getConfidence();
log.debug("{}: Adding tx [{}] {} to the memory pool", log.debug("{}: Adding tx [{}] {} to the memory pool",
new Object[]{byPeer, confidence.numBroadcastPeers(), tx.getHashAsString()}); new Object[]{byPeer, confidence.numBroadcastPeers(), tx.getHashAsString()});
lock.unlock(); // Copy the previously announced peers into the confidence and then clear it out. Unlock here
// because markBroadcastBy can trigger event listeners and thus inversions. After the lock is
// released "entry" may be changing arbitrarily and isn't usable.
skipUnlock = true; skipUnlock = true;
lock.unlock();
for (PeerAddress a : addrs) { for (PeerAddress a : addrs) {
confidence.markBroadcastBy(a); confidence.markBroadcastBy(a);
} }