From 2e895e4e099d14e60966617c54365e93fb8dcb42 Mon Sep 17 00:00:00 2001 From: Mike Hearn Date: Wed, 27 Feb 2013 15:18:04 +0100 Subject: [PATCH] Optimization when downloading blocks (should be rare these days), don't format log messages that requires an expensive hash->string conversion if the debug channel is not enabled. --- core/src/main/java/com/google/bitcoin/core/Peer.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/com/google/bitcoin/core/Peer.java b/core/src/main/java/com/google/bitcoin/core/Peer.java index d0dc9ed1..a16b6f32 100644 --- a/core/src/main/java/com/google/bitcoin/core/Peer.java +++ b/core/src/main/java/com/google/bitcoin/core/Peer.java @@ -640,7 +640,8 @@ public class Peer { } private synchronized void processBlock(Block m) throws IOException { - log.debug("{}: Received broadcast block {}", address.get(), m.getHashAsString()); + if (log.isDebugEnabled()) + log.debug("{}: Received broadcast block {}", address.get(), m.getHashAsString()); try { // Was this block requested by getBlock()? if (maybeHandleRequestedData(m)) return; @@ -691,7 +692,8 @@ public class Peer { // TODO: Fix this duplication. private synchronized void processFilteredBlock(FilteredBlock m) throws IOException { - log.debug("{}: Received broadcast filtered block {}", address.get(), m.getHash().toString()); + if (log.isDebugEnabled()) + log.debug("{}: Received broadcast filtered block {}", address.get(), m.getHash().toString()); try { if (!downloadData.get()) { log.debug("{}: Received block we did not ask for: {}", address.get(), m.getHash().toString());