diff --git a/core/src/main/java/com/google/bitcoin/core/Address.java b/core/src/main/java/com/google/bitcoin/core/Address.java index 4e73110a..e826b2d5 100644 --- a/core/src/main/java/com/google/bitcoin/core/Address.java +++ b/core/src/main/java/com/google/bitcoin/core/Address.java @@ -17,8 +17,9 @@ package com.google.bitcoin.core; /** - * A Bitcoin address is derived from an elliptic curve public key and a set of network parameters. - * It has several possible representations:

+ *

A Bitcoin address is derived from an elliptic curve public key and a set of network parameters. Not to be confused + * with a {@link PeerAddress} or {@link AddressMessage} which are about network (TCP) addresses. + * It has several possible representations:

* *
    *
  1. The raw public key bytes themselves. diff --git a/core/src/main/java/com/google/bitcoin/core/AddressMessage.java b/core/src/main/java/com/google/bitcoin/core/AddressMessage.java index 998f4539..64199b0f 100644 --- a/core/src/main/java/com/google/bitcoin/core/AddressMessage.java +++ b/core/src/main/java/com/google/bitcoin/core/AddressMessage.java @@ -6,6 +6,11 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; +/** + * Represents an "addr" message on the P2P network, which contains broadcast advertisements of other peers. This is + * one of the ways peers can find each other without using the DNS or IRC discovery mechansisms. However storing and + * using addr messages is not presently implemented. + */ public class AddressMessage extends Message { private static final long serialVersionUID = 8058283864924679460L; private static final long MAX_ADDRESSES = 1024; diff --git a/core/src/main/java/com/google/bitcoin/core/Base58.java b/core/src/main/java/com/google/bitcoin/core/Base58.java index 58d6bf7a..8584e76b 100644 --- a/core/src/main/java/com/google/bitcoin/core/Base58.java +++ b/core/src/main/java/com/google/bitcoin/core/Base58.java @@ -21,14 +21,14 @@ import java.math.BigInteger; import java.util.Arrays; /** - * A custom form of base58 is used to encode BitCoin addresses. Note that this is not the same base58 as used by - * Flickr, which you may see reference to around the internet.

    + *

    Base58 is a way to encode Bitcoin addresses as numbers and letters. Note that this is not the same base58 as used by + * Flickr, which you may see reference to around the internet.

    * - * Satoshi says: why base-58 instead of standard base-64 encoding?

    + *

    Satoshi says: why base-58 instead of standard base-64 encoding?

    * *

* * To find if the transaction is dead, you can use tx.getConfidence().getConfidenceType() == - * TransactionConfidence.ConfidenceType.OVERRIDDEN_BY_DOUBLE_SPEND. If it is, you should notify the user + * TransactionConfidence.ConfidenceType.DEAD. If it is, you should notify the user * in some way so they know the thing they bought may not arrive/the thing they sold should not be dispatched. - * - * @param wallet - * @param tx */ void onTransactionConfidenceChanged(Wallet wallet, Transaction tx); /** * Called by the {@link Wallet#addKey(ECKey)} method on whatever the calling thread was. - * @param key */ void onKeyAdded(ECKey key); }