Qortal/altcoinj
1
0
Fork 1
mirror of https://github.com/Qortal/altcoinj.git synced 2025-08-02 00:31:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential race condition when checking keychain for key rotation time.

Browse Source
This commit is contained in:
Andreas Schildbach
2014-11-16 12:27:11 +01:00
parent acad3e985d
commit 77dd531be4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/org/bitcoinj/core/Wallet.java
View File

@@ -4459,13 +4459,13 @@ public class Wallet extends BaseTaggableObject implements Serializable, BlockCha
checkState(keychainLock.isHeldByCurrentThread()); checkState(keychainLock.isHeldByCurrentThread());
List<Transaction> results = Lists.newLinkedList(); List<Transaction> results = Lists.newLinkedList();
// TODO: Handle chain replays here. // TODO: Handle chain replays here.
long keyRotationTimestamp = vKeyRotationTimestamp; final long keyRotationTimestamp = vKeyRotationTimestamp;
if (keyRotationTimestamp == 0) return results; // Nothing to do. if (keyRotationTimestamp == 0) return results; // Nothing to do.
// We might have to create a new HD hierarchy if the previous ones are now rotating. // We might have to create a new HD hierarchy if the previous ones are now rotating.
boolean allChainsRotating = true; boolean allChainsRotating = true;
for (DeterministicKeyChain chain : keychain.getDeterministicKeyChains()) { for (DeterministicKeyChain chain : keychain.getDeterministicKeyChains()) {
if (chain.getEarliestKeyCreationTime() >= vKeyRotationTimestamp) { if (chain.getEarliestKeyCreationTime() >= keyRotationTimestamp) {
allChainsRotating = false; allChainsRotating = false;
break; break;
} }