Qortal/altcoinj
1
0
Fork 1
mirror of https://github.com/Qortal/altcoinj.git synced 2025-07-31 20:11:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Transaction: Limit initial size of inputs and outputs ArrayList.

Browse Source
This commit is contained in:
Oscar Guindzberg
2018-03-19 15:49:51 -03:00
committed by Andreas Schildbach
parent b036f102ca
commit b6415663c9
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/org/bitcoinj/core/Transaction.java
View File

@@ -117,6 +117,11 @@ public class Transaction extends ChildMessage {
*/
public static final Coin MIN_NONDUST_OUTPUT = Coin.valueOf(546); // satoshis
/**
* Max initial size of inputs and outputs ArrayList.
*/
public static final int MAX_INITIAL_INPUTS_OUTPUTS_SIZE = 20;
// These are bitcoin serialized.
private long version;
private ArrayList<TransactionInput> inputs;
@@ -559,7 +564,7 @@ public class Transaction extends ChildMessage {
// First come the inputs.
long numInputs = readVarInt();
optimalEncodingMessageSize += VarInt.sizeOf(numInputs);
inputs = new ArrayList<TransactionInput>((int) numInputs);
inputs = new ArrayList<TransactionInput>(Math.min((int) numInputs, MAX_INITIAL_INPUTS_OUTPUTS_SIZE));
for (long i = 0; i < numInputs; i++) {
TransactionInput input = new TransactionInput(params, this, payload, cursor, serializer);
inputs.add(input);
@@ -570,7 +575,7 @@ public class Transaction extends ChildMessage {
// Now the outputs
long numOutputs = readVarInt();
optimalEncodingMessageSize += VarInt.sizeOf(numOutputs);
outputs = new ArrayList<TransactionOutput>((int) numOutputs);
outputs = new ArrayList<TransactionOutput>(Math.min((int) numOutputs, MAX_INITIAL_INPUTS_OUTPUTS_SIZE));
for (long i = 0; i < numOutputs; i++) {
TransactionOutput output = new TransactionOutput(params, this, payload, cursor, serializer);
outputs.add(output);