Orchid: document an issue with pending circuits on shutdown

orchid/src/com/subgraph/orchid/circuits/CircuitManagerImpl.java

@@ -129,20 +129,21 @@ public class CircuitManagerImpl implements CircuitManager, DashboardRenderable {
 	}
 
 	void addActiveCircuit(CircuitImpl circuit) {
+		synchronized (activeCircuits) {
+			activeCircuits.add(circuit);
+			activeCircuits.notifyAll();
+		}
+
 		lock.lock();
 
 		try {
 			if (!isBuilding) {
+				// we were asked to stop since this circuit was started
 				circuit.destroyCircuit();
 			}
 		} finally {
 			lock.unlock();
 		}
-
-		synchronized (activeCircuits) {
-			activeCircuits.add(circuit);
-			activeCircuits.notifyAll();
-		}
 	}
 	
 	void removeActiveCircuit(CircuitImpl circuit) {

orchid/src/com/subgraph/orchid/connections/ConnectionCacheImpl.java

@@ -94,6 +94,9 @@ public class ConnectionCacheImpl implements ConnectionCache, DashboardRenderable
 					logger.warning("Exception closing connection: "+ e.getCause());
 				}
 			} else {
+				// FIXME this doesn't close the socket, so the connection task lingers
+				// A proper fix would require maintaining pending connections in a separate
+				// collection.
 				f.cancel(true);
 			}
 		}