Qortal/altcoinj
3
0
Fork 0
mirror of https://github.com/Qortal/altcoinj.git synced 2025-02-12 10:15:52 +00:00
Code Issues Projects Releases Wiki Activity

Improve Coin range check to cope with Long.MIN_VALUE correctly

Browse Source
This commit is contained in:
Peter Dettman 2014-10-17 12:53:59 +07:00 committed by Andreas Schildbach
parent f40785fbdf
commit bb368c9543
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/src/main/java/org/bitcoinj/core/Coin.java
View File

@ -82,8 +82,10 @@ public final class Coin implements Monetary, Comparable<Coin>, Serializable {
*/ */
public final long value; public final long value;
private final long MAX_SATOSHIS = COIN_VALUE * NetworkParameters.MAX_COINS;
private Coin(final long satoshis) { private Coin(final long satoshis) {
checkArgument(Math.abs(satoshis) <= COIN_VALUE * NetworkParameters.MAX_COINS, checkArgument(-MAX_SATOSHIS <= satoshis && satoshis <= MAX_SATOSHIS,
"%s satoshis exceeds maximum possible quantity of Bitcoin.", satoshis); "%s satoshis exceeds maximum possible quantity of Bitcoin.", satoshis);
this.value = satoshis; this.value = satoshis;
} }

5
core/src/test/java/org/bitcoinj/core/CoinTest.java
View File

@ -62,6 +62,11 @@ public class CoinTest {
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
} }
try {
valueOf(Long.MIN_VALUE);
fail();
} catch (IllegalArgumentException e) {}
try { try {
valueOf(1, -1); valueOf(1, -1);
fail(); fail();