diff --git a/core/src/main/java/org/bitcoinj/core/LegacyAddress.java b/core/src/main/java/org/bitcoinj/core/LegacyAddress.java index 066bcf9b..c10f7078 100644 --- a/core/src/main/java/org/bitcoinj/core/LegacyAddress.java +++ b/core/src/main/java/org/bitcoinj/core/LegacyAddress.java @@ -108,10 +108,16 @@ public class LegacyAddress extends Address { * P2SH script hash * @return constructed address */ - public static LegacyAddress fromP2SHHash(NetworkParameters params, byte[] hash160) throws AddressFormatException { + public static LegacyAddress fromScriptHash(NetworkParameters params, byte[] hash160) throws AddressFormatException { return new LegacyAddress(params, true, hash160); } + /** @deprecated use {@link #fromScriptHash(NetworkParameters, byte[])} */ + @Deprecated + public static LegacyAddress fromP2SHHash(NetworkParameters params, byte[] hash160) { + return fromScriptHash(params, hash160); + } + /** * Constructs a {@link LegacyAddress} that represents the script hash extracted from the given scriptPubKey. * @@ -123,7 +129,7 @@ public class LegacyAddress extends Address { */ public static LegacyAddress fromP2SHScript(NetworkParameters params, Script scriptPubKey) { checkArgument(ScriptPattern.isPayToScriptHash(scriptPubKey), "Not a P2SH script"); - return fromP2SHHash(params, ScriptPattern.extractHashFromPayToScriptHash(scriptPubKey)); + return fromScriptHash(params, ScriptPattern.extractHashFromPayToScriptHash(scriptPubKey)); } /** diff --git a/core/src/main/java/org/bitcoinj/core/TransactionOutput.java b/core/src/main/java/org/bitcoinj/core/TransactionOutput.java index 18ff3029..bfc9b198 100644 --- a/core/src/main/java/org/bitcoinj/core/TransactionOutput.java +++ b/core/src/main/java/org/bitcoinj/core/TransactionOutput.java @@ -132,7 +132,7 @@ public class TransactionOutput extends ChildMessage { @Deprecated public LegacyAddress getAddressFromP2SH(NetworkParameters params) throws ScriptException { if (ScriptPattern.isPayToScriptHash(getScriptPubKey())) - return LegacyAddress.fromP2SHHash(params, ScriptPattern.extractHashFromPayToScriptHash(getScriptPubKey())); + return LegacyAddress.fromScriptHash(params, ScriptPattern.extractHashFromPayToScriptHash(getScriptPubKey())); return null; } diff --git a/core/src/test/java/org/bitcoinj/core/LegacyAddressTest.java b/core/src/test/java/org/bitcoinj/core/LegacyAddressTest.java index 973002f2..daa8831f 100644 --- a/core/src/test/java/org/bitcoinj/core/LegacyAddressTest.java +++ b/core/src/test/java/org/bitcoinj/core/LegacyAddressTest.java @@ -164,9 +164,9 @@ public class LegacyAddressTest { // Test that we can convert them from hashes byte[] hex = HEX.decode("2ac4b0b501117cc8119c5797b519538d4942e90e"); - LegacyAddress a = LegacyAddress.fromP2SHHash(MAINNET, hex); + LegacyAddress a = LegacyAddress.fromScriptHash(MAINNET, hex); assertEquals("35b9vsyH1KoFT5a5KtrKusaCcPLkiSo1tU", a.toString()); - LegacyAddress b = LegacyAddress.fromP2SHHash(TESTNET, HEX.decode("18a0e827269b5211eb51a4af1b2fa69333efa722")); + LegacyAddress b = LegacyAddress.fromScriptHash(TESTNET, HEX.decode("18a0e827269b5211eb51a4af1b2fa69333efa722")); assertEquals("2MuVSxtfivPKJe93EC1Tb9UhJtGhsoWEHCe", b.toString()); LegacyAddress c = LegacyAddress.fromP2SHScript(MAINNET, ScriptBuilder.createP2SHOutputScript(hex)); assertEquals("35b9vsyH1KoFT5a5KtrKusaCcPLkiSo1tU", c.toString()); diff --git a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java index 8b605165..79b8e518 100644 --- a/core/src/test/java/org/bitcoinj/wallet/WalletTest.java +++ b/core/src/test/java/org/bitcoinj/wallet/WalletTest.java @@ -153,7 +153,7 @@ public class WalletTest extends TestWithWallet { @Test public void basicSpendingToP2SH() throws Exception { - LegacyAddress destination = LegacyAddress.fromP2SHHash(UNITTEST, HEX.decode("4a22c3c4cbb31e4d03b15550636762bda0baf85a")); + LegacyAddress destination = LegacyAddress.fromScriptHash(UNITTEST, HEX.decode("4a22c3c4cbb31e4d03b15550636762bda0baf85a")); basicSpendingCommon(wallet, myAddress, destination, null); }