Qortal/altcoinj
1
0
Fork 1
mirror of https://github.com/Qortal/altcoinj.git synced 2025-07-31 20:11:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Exit after fail + 5 rules

Browse Source
This commit is contained in:
Matt Corallo
2014-10-02 13:50:28 -07:00
committed by Mike Hearn
parent d37bba6393
commit d78e9b053a
1 changed files with 30 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
core/src/test/java/org/bitcoinj/core/BitcoindComparisonTool.java
View File

@@ -218,10 +218,7 @@ public class BitcoindComparisonTool {
locator.add(params.getGenesisBlock().getHash()); locator.add(params.getGenesisBlock().getHash());
Sha256Hash hashTo = new Sha256Hash("0000000000000000000000000000000000000000000000000000000000000000"); Sha256Hash hashTo = new Sha256Hash("0000000000000000000000000000000000000000000000000000000000000000");
int differingBlocks = 0; int rulesSinceFirstFail = 0;
int invalidBlocks = 0;
int mempoolRulesFailed = 0;
Sha256Hash lastBlockTestedHash = null;
for (Rule rule : blockList.list) { for (Rule rule : blockList.list) {
if (rule instanceof BlockAndValidity) { if (rule instanceof BlockAndValidity) {
BlockAndValidity block = (BlockAndValidity) rule; BlockAndValidity block = (BlockAndValidity) rule;
@@ -242,35 +239,34 @@ public class BitcoindComparisonTool {
throw e; throw e;
} }
} }
lastBlockTestedHash = block.blockHash;
currentBlock.block = nextBlock; currentBlock.block = nextBlock;
log.info("Testing block {} {}", block.ruleName, currentBlock.block.getHash()); log.info("Testing block {} {}", block.ruleName, currentBlock.block.getHash());
try { try {
if (chain.add(nextBlock) != block.connects) { if (chain.add(nextBlock) != block.connects) {
log.error("Block didn't match connects flag on block \"" + block.ruleName + "\""); log.error("ERROR: Block didn't match connects flag on block \"" + block.ruleName + "\"");
invalidBlocks++; rulesSinceFirstFail++;
} }
} catch (VerificationException e) { } catch (VerificationException e) {
threw = true; threw = true;
if (!block.throwsException) { if (!block.throwsException) {
log.error("Block didn't match throws flag on block \"" + block.ruleName + "\""); log.error("ERROR: Block didn't match throws flag on block \"" + block.ruleName + "\"");
e.printStackTrace(); e.printStackTrace();
invalidBlocks++; rulesSinceFirstFail++;
} else if (block.connects) { } else if (block.connects) {
log.error("Block didn't match connects flag on block \"" + block.ruleName + "\""); log.error("ERROR: Block didn't match connects flag on block \"" + block.ruleName + "\"");
e.printStackTrace(); e.printStackTrace();
invalidBlocks++; rulesSinceFirstFail++;
} }
} }
if (!threw && block.throwsException) { if (!threw && block.throwsException) {
log.error("Block didn't match throws flag on block \"" + block.ruleName + "\""); log.error("ERROR: Block didn't match throws flag on block \"" + block.ruleName + "\"");
invalidBlocks++; rulesSinceFirstFail++;
} else if (!chain.getChainHead().getHeader().getHash().equals(block.hashChainTipAfterBlock)) { } else if (!chain.getChainHead().getHeader().getHash().equals(block.hashChainTipAfterBlock)) {
log.error("New block head didn't match the correct value after block \"" + block.ruleName + "\""); log.error("ERROR: New block head didn't match the correct value after block \"" + block.ruleName + "\"");
invalidBlocks++; rulesSinceFirstFail++;
} else if (chain.getChainHead().getHeight() != block.heightAfterBlock) { } else if (chain.getChainHead().getHeight() != block.heightAfterBlock) {
log.error("New block head didn't match the correct height after block " + block.ruleName); log.error("ERROR: New block head didn't match the correct height after block " + block.ruleName);
invalidBlocks++; rulesSinceFirstFail++;
} }
// Shouldnt double-request // Shouldnt double-request
@@ -299,8 +295,8 @@ public class BitcoindComparisonTool {
if (shouldntRequest) { if (shouldntRequest) {
Thread.sleep(100); Thread.sleep(100);
if (blocksRequested.contains(nextBlock.getHash())) { if (blocksRequested.contains(nextBlock.getHash())) {
log.error("bitcoind re-requested block " + block.ruleName + " with hash " + nextBlock.getHash()); log.error("ERROR: bitcoind re-requested block " + block.ruleName + " with hash " + nextBlock.getHash());
invalidBlocks++; rulesSinceFirstFail++;
} }
} }
// If the block throws, we may want to get bitcoind to request the same block again // If the block throws, we may want to get bitcoind to request the same block again
@@ -312,8 +308,8 @@ public class BitcoindComparisonTool {
bitcoind.sendMessage(new GetHeadersMessage(params, locator, hashTo)); bitcoind.sendMessage(new GetHeadersMessage(params, locator, hashTo));
bitcoind.ping().get(); bitcoind.ping().get();
if (!chain.getChainHead().getHeader().getHash().equals(bitcoindChainHead)) { if (!chain.getChainHead().getHeader().getHash().equals(bitcoindChainHead)) {
differingBlocks++; rulesSinceFirstFail++;
log.error("bitcoind and bitcoinj acceptance differs on block \"" + block.ruleName + "\""); log.error("ERROR: bitcoind and bitcoinj acceptance differs on block \"" + block.ruleName + "\"");
} }
if (block.sendOnce) if (block.sendOnce)
preloadedBlocks.remove(nextBlock.getHash()); preloadedBlocks.remove(nextBlock.getHash());
@@ -323,11 +319,11 @@ public class BitcoindComparisonTool {
bitcoind.sendMessage(message); bitcoind.sendMessage(message);
bitcoind.ping().get(); bitcoind.ping().get();
if (mostRecentInv == null && !((MemoryPoolState) rule).mempool.isEmpty()) { if (mostRecentInv == null && !((MemoryPoolState) rule).mempool.isEmpty()) {
log.error("bitcoind had an empty mempool, but we expected some transactions on rule " + rule.ruleName); log.error("ERROR: bitcoind had an empty mempool, but we expected some transactions on rule " + rule.ruleName);
mempoolRulesFailed++; rulesSinceFirstFail++;
} else if (mostRecentInv != null && ((MemoryPoolState) rule).mempool.isEmpty()) { } else if (mostRecentInv != null && ((MemoryPoolState) rule).mempool.isEmpty()) {
log.error("bitcoind had a non-empty mempool, but we expected an empty one on rule " + rule.ruleName); log.error("ERROR: bitcoind had a non-empty mempool, but we expected an empty one on rule " + rule.ruleName);
mempoolRulesFailed++; rulesSinceFirstFail++;
} else if (mostRecentInv != null) { } else if (mostRecentInv != null) {
Set<InventoryItem> originalRuleSet = new HashSet<InventoryItem>(((MemoryPoolState)rule).mempool); Set<InventoryItem> originalRuleSet = new HashSet<InventoryItem>(((MemoryPoolState)rule).mempool);
boolean matches = mostRecentInv.items.size() == ((MemoryPoolState)rule).mempool.size(); boolean matches = mostRecentInv.items.size() == ((MemoryPoolState)rule).mempool.size();
@@ -343,19 +339,21 @@ public class BitcoindComparisonTool {
log.info(" The expected mempool was: "); log.info(" The expected mempool was: ");
for (InventoryItem item : originalRuleSet) for (InventoryItem item : originalRuleSet)
log.info(" " + item.hash); log.info(" " + item.hash);
mempoolRulesFailed++; rulesSinceFirstFail++;
} }
mostRecentInv = null; mostRecentInv = null;
} else { } else {
throw new RuntimeException("Unknown rule"); throw new RuntimeException("Unknown rule");
} }
if (rulesSinceFirstFail > 0)
rulesSinceFirstFail++;
if (rulesSinceFirstFail > 6)
System.exit(1);
} }
log.info("Done testing.\n" + if (unexpectedInvs.get() > 0)
"Blocks which were not handled the same between bitcoind/bitcoinj: " + differingBlocks + "\n" + log.error("ERROR: Got " + unexpectedInvs.get() + " unexpected invs from bitcoind");
"Blocks which should/should not have been accepted but weren't/were: " + invalidBlocks + "\n" + log.info("Done testing.");
"Transactions which were/weren't in memory pool but shouldn't/should have been: " + mempoolRulesFailed + "\n" + System.exit(rulesSinceFirstFail > 0 || unexpectedInvs.get() > 0 ? 1 : 0);
"Unexpected inv messages: " + unexpectedInvs.get());
System.exit(differingBlocks > 0 || invalidBlocks > 0 || mempoolRulesFailed > 0 || unexpectedInvs.get() > 0 ? 1 : 0);
} }
} }