Mike Hearn
24a5c05546
Payment channels: allow usage of unconfirmed coins for building a contract, as the risk is low (they're micropayments anyway).
2013-09-05 15:16:58 +02:00
Mike Hearn
bf228cce34
Wallet: comment for AllowUnconfirmedCoinSelector.get()
2013-09-05 15:10:50 +02:00
Mike Hearn
38119b9355
Payment channels: Better comments and logging.
2013-09-05 12:42:33 +02:00
Mike Hearn
273acbdccd
Payment channels: Take out unnecessary {} from log messages.
2013-09-04 13:27:17 +02:00
Mike Hearn
1d454c03f3
Suppress annoying and useless warning.
2013-09-03 14:24:18 +02:00
Mike Hearn
e05abe150b
Wallet: when "emptying" the wallet, only actually empty out the coins that would be considered selectable by the default coin selector.
...
By default that means unconfirmed coins won't be emptied, to avoid the empty tx becoming dependent on a tx that may never confirm.
Resolves issue 438.
2013-08-15 12:31:54 +02:00
Matt Corallo
cf23e18f23
MessageWriteTarget->interface, writeBytes throws IOException
2013-08-13 17:13:58 +02:00
Matt Corallo
edd0a0907c
Clarify PeerEventListener JavaDocs a bit
2013-08-13 17:13:29 +02:00
Matt Corallo
5ef59b9ae1
Unimplemented bitcoinSerializeToStream -> log error, not debug
2013-08-13 17:13:15 +02:00
Matt Corallo
1a5348c534
Implement ListMessage.equals()
2013-08-13 17:12:57 +02:00
Matt Corallo
7011d68165
Implement some (de)serialization (so we can roundtrip msgs in test)
...
Implements deserialization for getblocks/getheaders and supports
FilteredBlock entries in ListMessage (for getdata).
Implements serialization for FilteredBlock, HeadersMessage, and
PartialMerkleTree.
2013-08-13 17:12:32 +02:00
Matt Corallo
a724bcada5
Mark receivePending(List<Tx> dependencies) @Nullable
2013-08-13 17:11:34 +02:00
Matt Corallo
98787909da
Fix typo
2013-08-13 17:11:19 +02:00
Matt Corallo
8448296f5f
Abstract out SelectionKey processing and logic from NioServer.
2013-08-13 17:10:21 +02:00
Matt Corallo
9980903572
Make Protobuf{Server,Client} more generic.
2013-08-13 17:09:14 +02:00
Matt Corallo
146a6dd37e
Add payment channel server native event handler wrappers
2013-08-13 15:06:18 +02:00
Matt Corallo
7074d52fbb
Add test-case for manually-added transactions that appear in blocks
2013-08-13 15:05:04 +02:00
Mike Hearn
3857b0ae05
Sync script test files with bitcoin upstream.
2013-08-13 11:44:46 +02:00
Mike Hearn
08afe9044d
Move verifier XML around.
2013-08-11 16:45:07 +02:00
Mike Hearn
6dd907614c
Wallet: support for key rotation.
...
Key rotation allows you to specify a timestamp, and any money controlled by any keys created before that time will be automatically respent to keys created after it.
2013-08-11 16:33:36 +02:00
Mike Hearn
3ca2cd0345
PeerGroupTest: Fix a race.
2013-08-08 14:23:23 +02:00
Mike Hearn
19d4887253
Wallet: allow SendRequests to override the default coin selector.
2013-08-08 14:23:23 +02:00
Mike Hearn
33f48d3e22
PeerGroup/Wallet: give the wallet a reference to a transaction broadcaster, so it can make its own transactions and broadcast them outside the context of a user initiated spend.
...
Later, we can change the mechanism used to broadcast pending transactions so the wallet does that itself.
2013-08-08 14:23:23 +02:00
Mike Hearn
6b1c208f1e
Wallet: Minor nullity annotation and param genericity tweaks.
2013-08-08 11:19:49 +02:00
Matt Corallo
ca15e611ca
Fix manually-added transactions that make it into blocks.
2013-07-31 13:05:03 +02:00
Mike Hearn
c2cff6df41
Add a remark to the BloomFilter javadocs about when you would want to use full-match filters.
2013-07-30 16:05:04 +02:00
Matt Corallo
41d2a8c62d
Fix block tests
2013-07-30 15:52:00 +02:00
Matt Corallo
a7ec6a1db3
Implement mempool-test support in BitcoindComparisonTool
2013-07-30 15:41:31 +02:00
Matt Corallo
60220aa62d
InventoryItem.hashCode()
...
Conflicts:
core/src/main/java/com/google/bitcoin/core/InventoryItem.java
2013-07-30 15:41:21 +02:00
Matt Corallo
d88d421de6
Make BloomFilter support match-all filters better
2013-07-30 15:40:47 +02:00
Mike Hearn
2808b062d7
Version 0.11-SNAPSHOT
2013-07-30 14:47:39 +02:00
Matt Corallo
df47993e3d
Add some comments for stateless protocols.
2013-07-30 14:47:08 +02:00
Mike Hearn
8016ee8418
Wallet: explicitly note in the completeTx javadoc that it signs the added inputs.
2013-07-29 19:06:21 +02:00
Mike Hearn
bbac0abf9e
Wallet: more @Nullable annotations and generalise the sendCoins argument to take any broadcaster.
2013-07-29 18:35:49 +02:00
Mike Hearn
f821207a80
WalletAppKit: add a new override-able method that lets you customise objects after they were created, but before chain download starts.
2013-07-29 17:18:48 +02:00
Mike Hearn
872967e96e
WalletEventListener: Remove obsolete references to being called on Peer threads from the javadocs.
2013-07-29 17:18:21 +02:00
Mike Hearn
da2a321c23
Wallet: add a missing @Nullable annotation.
2013-07-29 17:17:58 +02:00
Mike Hearn
016837a593
Wallet: expose the calculateAllSpendCandidates method as public.
2013-07-29 13:27:49 +02:00
Mike Hearn
86f68c8ffa
Transaction: add a bit more info to constant field javadocs.
2013-07-29 12:50:02 +02:00
Mike Hearn
630b36c5c8
Payment channels: tweaks to channel resume behaviour.
...
Don't create a new channel automatically when the client wants to resume but there's already an open connection using that contract. Instead, disconnect the other client. This fixes unintuitive behaviour that could occur if a TCP connection silently died and the server didn't notice.
2013-07-25 18:11:53 +02:00
Mike Hearn
cf4c469e6e
TransactionInput: treat duplicate connection attempts as a success.
2013-07-25 15:30:49 +02:00
Mike Hearn
a5ed2d63d3
Payment channels: Relabel stored client channel toString a bit.
2013-07-25 15:29:47 +02:00
Mike Hearn
4aaac4f105
AbstractBlockChain: slight tweak to logging of filtered blocks to make it less confusing.
2013-07-25 15:26:26 +02:00
Mike Hearn
4f92c24dea
Payment channels: stop clients attempting to resume empty channels.
2013-07-25 15:26:10 +02:00
Mike Hearn
70590dac16
Payment channels: add wallet printouts of the contents of the extensions.
2013-07-25 15:09:48 +02:00
Mike Hearn
d3842cc0f4
Wallet: Print Wallet extensions in toString() and make tx printouts optional.
2013-07-25 14:11:42 +02:00
Mike Hearn
89b6b54d24
Payment channels: better logging in client state.
2013-07-25 11:28:45 +02:00
Mike Hearn
9e78268813
Wallet: don't crash if receivePending is called twice with the same tx, even if the override flag is on.
2013-07-24 16:17:47 +02:00
Mike Hearn
51d717e93a
Payment channels: Make the ProtobufParser timer daemon and labelled.
2013-07-24 14:58:33 +02:00
Mike Hearn
00bc4e30ee
PeerGroup: add a todo about the pinging thread.
2013-07-24 14:53:34 +02:00
Mike Hearn
52b478a6f8
PeerGroup: Ignore an IllegalStateException from the ping timer that can be thrown occasionally during a shutdown race.
2013-07-24 14:52:08 +02:00
Mike Hearn
67f3605570
Transaction: format date based time locks correctly.
2013-07-24 14:45:42 +02:00
Mike Hearn
2a635317c3
WalletAppKit: Configure the peergroup with candidate peers before adding wallet extensions, as payment channel state can attempt to broadcast a transaction as soon as the state is loaded/instantiated. This ensures the number of min peers required for broadcast is correct at that point.
2013-07-24 13:56:12 +02:00
Mike Hearn
a1daaa73be
PeerGroup: Don't allow attempts to broadcast to zero peers.
2013-07-24 13:55:20 +02:00
Mike Hearn
81a9e1e893
Peer: drop out of fast catchup mode when reaching the top of the chain.
...
This bug could cause problems if you sync a wallet containing no keys, and then a chain fork happens (you won't follow the fork).
2013-07-23 20:10:57 +02:00
Mike Hearn
2acbd55d47
NetworkParameters: Remove ID_PRODNET. Resolves issue 430.
2013-07-22 18:12:36 +02:00
Mike Hearn
adea4f9479
Wallet: log completed transactions completely.
2013-07-22 17:22:13 +02:00
Matt Corallo
1e69d2b0dd
Add emptyWallet option to SendRequest+tests and random typo fixes
2013-07-22 15:27:24 +02:00
Mike Hearn
87ad8f2e5b
Add JNI peers for some listener classes.
2013-07-22 15:25:21 +02:00
Mike Hearn
dcf04f6cb6
Payment channels: inline a superfluous misnamed method on StoredServerChannel and rename getState to getOrCreateState.
2013-07-19 15:55:30 +02:00
Mike Hearn
4f9bc98e97
Payment channels: Re-order c'tor of StoredPaymentChannelClientStates.
...
This makes it consistent with the server side and put the listener last. It's easier to read this way when an anonymous inner class is used.
2013-07-19 15:55:30 +02:00
Mike Hearn
da0d6c37a2
Payment channels: some bugfixes to resume behaviour.
...
Don't deserialize channels as active. Deserialize keys as compressed, not uncompressed.
2013-07-19 15:55:29 +02:00
Mike Hearn
516327289f
Payment channels: Expose a client connection method that terminates the TCP connection but doesn't try to close the channel (ask the server to broadcast the contract).
2013-07-19 14:41:15 +02:00
Mike Hearn
a7dbe7cd03
Payment channels: Add more logging on the server resume path.
2013-07-19 12:04:15 +02:00
Mike Hearn
7d75e747e0
Payment channels: Fix a dumb bug that caused the negotiated channel size to be wrong. Add a test.
2013-07-17 21:41:08 +02:00
Mike Hearn
c04708dd1e
Payment channels: Add detail to an error log message.
2013-07-17 21:40:52 +02:00
Mike Hearn
87897fbb37
Payment channels: Describe reason for connection closing in log message.
2013-07-17 21:40:17 +02:00
Matt Corallo
c5d267f0f9
PaymentChannelCloseException: Show reason in toString()
2013-07-16 17:25:25 +02:00
Matt Corallo
1d7f2eb00b
Fix channel client state saving to save earlier (and be secure)
2013-07-16 14:59:21 +02:00
Mike Hearn
ff714fbd77
Add a PeerAddress.localhost() helper.
2013-07-15 18:22:57 +02:00
Matt Corallo
0fe56bf544
Let balance check fail later iff the server wants maxValue
2013-07-15 18:22:51 +02:00
Mike Hearn
00da963bbb
Payment channels: use daemon threads so the VM can exit after the state objects are created.
2013-07-13 02:24:19 +02:00
Mike Hearn
719a786db1
Eliminate support for parsing negative or too large amounts in Utils.toNanoCoins. Add tests for out of range URI amounts. Resolves issue 407.
2013-07-11 17:33:31 +02:00
Mike Hearn
d3eab06dba
Make BitcoinURIParseException checked so you can't forget it, and catch/rethrow ArithmeticErrors when parsing the value field.
...
Add more nullity annotations.
2013-07-11 16:52:50 +02:00
Mike Hearn
bf585d8627
Transaction: note that a ScriptException is expected at this point.
2013-07-11 16:52:11 +02:00
Mike Hearn
2c26f8802b
Add PeerGroup.clearListeners(). Resolves issue 426.
2013-07-11 16:34:57 +02:00
Mike Hearn
4e95ab3cfc
Assert on lock.isHeldByCurrentThread() instead of isLocked() - the latter is not correct.
...
This didn't cause any actual bugs but just reduced the safety of making code changes.
2013-07-11 16:30:44 +02:00
Mike Hearn
e687e52230
Use the correct alert signing key for testnet.
2013-07-11 16:29:56 +02:00
Mike Hearn
6a39af30c4
Add AbstractBlockChain.removeWallet(). Resolves issue 419.
2013-07-11 16:11:33 +02:00
Mike Hearn
5c1063860a
WalletAppKit: Improve javadoc a bit.
2013-07-11 16:07:14 +02:00
Mike Hearn
99f32b16af
Introduce UnreadableWalletException and make WalletProtobufSerializer throw it in all cases where there's a problem reading the wallet. Resolves issue 415. Resolves issue 416.
2013-07-11 16:04:00 +02:00
Mike Hearn
be89be6f43
PaymentChannelServerState: Fix typo in variable name.
2013-07-11 15:35:17 +02:00
Mike Hearn
d2232ed4aa
Fix hdw unit tests after I broke them.
2013-07-11 14:19:48 +02:00
Matt Corallo
c98badcf1c
Store states in protobufs instead of using Java Serialization.
...
Saves having to use reflection.
2013-07-11 14:16:40 +02:00
Matt Corallo
4b4405b7bc
Check for double-spend of contract by force-adding it to wallet
2013-07-11 14:15:48 +02:00
Matt Corallo
f0be874815
Add option to skip isRelevant checks in Wallet.receivePending
2013-07-11 14:14:24 +02:00
Mike Hearn
86bd974958
Move HD wallets code into plain crypto package.
2013-07-11 13:45:12 +02:00
Mike Hearn
be39c176db
Add a TODO to merge DeterministicKey and ECKey together.
2013-07-11 13:43:35 +02:00
Mike Hearn
98219bdd1b
More static analysis tweaks.
2013-07-11 13:42:42 +02:00
Mike Hearn
000d81d54f
Rename ExtendedHierarchicKey to DeterministicKey. Add annotations and rewrite a bit of code to satisfy static analysis.
2013-07-11 13:41:46 +02:00
Mike Hearn
50dd5af0c8
Add more javadocs.
...
Delete the wallet integration code - it's good, but we won't ship it in 0.10 as it's not finished.
2013-07-11 13:10:07 +02:00
Mike Hearn
0385ab34e5
Add copyrights, remove dead code, and fix some minor static analysis warnings.
...
Also remove a unit test that was just testing bouncy castle.
2013-07-11 11:59:31 +02:00
matija.mazi@gmail.com
c3fd83e511
Add support classes for hierarchical deterministic wallets (BIP 32)
...
Code from Matija Mazi. HD wallets allow you to derive keys from a single
root key, giving various useful features:
- Make a backup once and it's good forever (for your keys only of course)
- You can break off parts of the tree and give it to other people,
they can then generate new keys to send you money without any
involvement by you (better privacy+security for watching wallets)
- You can delegate sub-trees to other people as a form of access control.
2013-07-11 11:40:33 +02:00
Mike Hearn
00f4c82342
WalletFiles: Make saving thread shut down after 5 seconds of doing nothing.
2013-07-10 18:14:10 +02:00
Mike Hearn
2b6022cd7c
WalletFiles: log how long saving the wallet took.
2013-07-10 16:59:39 +02:00
Mike Hearn
5219a42df9
Wallet: refactor saving code into a separate class that uses a Java scheduled executor rather than the messy and likely buggy custom threading code. Synchronously save the wallet on way more codepaths, now we only do write coalescing for new best block notifications.
2013-07-10 16:46:56 +02:00
Matt Corallo
acc2877329
Reject dust outputs with ensureMinRequiredFee ( fixes #429 )
2013-07-10 16:28:29 +02:00
Mike Hearn
48cee2e668
KeyCrypterScrypt: Fix some minor code style issues.
2013-07-10 16:27:01 +02:00
Mike Hearn
53dc5c2e6a
Make Andreas happy. Resolves issue 423.
2013-07-10 16:23:05 +02:00
Matt Corallo
b51485ca23
Peer Bloom filter generation -> new PeerFilterProvider interface
2013-07-10 15:59:51 +02:00
Matt Corallo
2061d28e52
Use direct byte buffers instead of normal ones in niowrapper
2013-07-10 15:55:21 +02:00
Matt Corallo
e6965d0217
Always accept time-locked txn we create, make refund tx source self
2013-07-10 15:53:59 +02:00
Matt Corallo
1277df32d8
Fix a few minor typos.
2013-07-10 15:53:19 +02:00
Mike Hearn
2c44a4fad7
PeerGroup: Require Bloom-filtering capable peers by default. Resolves issue 421.
2013-07-10 15:52:09 +02:00
Mike Hearn
34d804ecca
PeerGroup: fix naming of vPingTimer
2013-07-10 15:33:24 +02:00
Mike Hearn
5b78601b4a
Wallet: make last seen block height default to zero not -1
2013-07-10 15:32:36 +02:00
Mike Hearn
d92314dd18
Peer/Group: Clear some static analysis warnings related to the (buggy) optionality of the block chain and some threading issues.
2013-07-10 15:32:20 +02:00
Mike Hearn
4c0930a961
AbstractBlockChain: Correct minor logging issue
2013-07-10 14:42:47 +02:00
Mike Hearn
8a74b3da2c
Minor logging fixes. Resolves issue 423.
2013-07-09 14:57:20 +02:00
Mike Hearn
f473267da2
Exception handling: provide a global variable in Threading that receives all unhandled exceptions from all framework threads.
...
Replaces the now removed PeerEventListener.onException() callback.
2013-07-09 14:47:38 +02:00
Mike Hearn
ea19d3164a
TCPNetworkConnection: allow manually constructed one-offs to be given a Peer object.
2013-07-09 14:43:37 +02:00
Mike Hearn
e3e80c357d
BitcoinSerializer: Remove some optimisations that date from the time when someone was trying to make bitcoinj into a super scalable multiplexor, and allow writing of arbitrary byte arrays that get checksummed and prefixed.
2013-07-09 14:43:12 +02:00
Mike Hearn
975dea6e16
VersionAck: Delete some whitespace
2013-07-09 14:42:28 +02:00
Matt Corallo
09752848bb
Announce transactions to wallet in order even from FilteredBlocks
2013-07-09 13:05:35 +02:00
Mike Hearn
a05d69537d
Remove JavaDocs from AbstractWalletEventListener so IDEs will automatically inherit them.
2013-07-08 13:24:32 +02:00
Mike Hearn
24b825252f
Fix a bogus assert in Threading
2013-07-05 14:21:43 +02:00
Mike Hearn
8869e57fa0
AbstractBlockChain: add a bit more logging.
2013-07-05 13:49:43 +02:00
Mike Hearn
573e04491c
Threading: fix the user thread to be daemon so programs can shut down properly again.
2013-07-05 12:23:28 +02:00
Mike Hearn
a8a8d3a044
AbstractBlockChain: Fix some nullity annotations and a few other misc things.
2013-07-05 11:56:27 +02:00
Mike Hearn
d316cf316f
AbstractBlockChain: Replace mention of BOBS in class javadoc with SPVBlockChain.
2013-07-05 11:48:28 +02:00
Mike Hearn
aaa71c0811
Fix AbstractBlockChain.removeListener. Found by IntelliJ.
2013-07-05 11:47:42 +02:00
Mike Hearn
35a7f38d86
Make block chain listeners run in given executors and default to the user thread.
2013-07-05 10:54:21 +02:00
Mike Hearn
2537ff47b5
Extend executor-specific event handlers to PeerGroup and Peer. Rename Threading.sameThread to Threading.SAME_THREAD
2013-07-05 10:54:21 +02:00
Mike Hearn
50b71979bb
Fix removal of event listeners. Make PeerGroup also allow specification of arbitrary executors and run event listeners in those.
2013-07-05 10:54:21 +02:00
Mike Hearn
c552c0cbdd
Move ListenerRegistration out into utils and make it generic.
2013-07-05 10:54:21 +02:00
Mike Hearn
f6d14db8e6
Wallet: allow choice of executor to run event listeners in, default to user thread.
2013-07-05 10:54:20 +02:00
Mike Hearn
3185923d4a
Add @Override annotations to PeerEventListener.
2013-07-05 10:54:20 +02:00
Mike Hearn
cdd1c5e38a
Change onKeyAdded to be onKeysAdded that takes a list, and run it in the user thread.
2013-07-05 10:54:20 +02:00
Mike Hearn
0907a3852b
Add a test to ensure that wallet listeners that throw exceptions don't prevent the others from running.
2013-07-05 10:54:20 +02:00
Mike Hearn
dd83d55df4
Add JavaDocs for TransactionConfidence.Listener.Reason
2013-07-05 10:54:19 +02:00
Mike Hearn
a28cb5c59a
Don't mark transactions that have just been completed as pending, and then fix a stupid efficiency bug in AbstractBlockChain that was revealed by the change.
2013-07-05 10:54:19 +02:00
Mike Hearn
6b7d653614
Major rework of how confidence listeners are called:
...
* API change: TransactionConfidence.Listener now takes a reason enum describing the general class of change.
* Confidence listeners are now invoked in the user code thread as well, thus eliminating any chance of unexpected re-entrancy.
* The wallet batches up confidence changes and executes them all at the end of major operations, avoiding confusing intermediate transitions that could occur in the previous design.
* Much code has been simplified as a result and it's now harder to screw up.
2013-07-05 10:54:19 +02:00
Mike Hearn
5de80dfedf
Introduce a user code thread which is used for running event listeners.
...
This ensures that when user provided event listeners are invoked, we're not holding any locks at that time and thus event listeners can do whatever they want with no risk of accidental inversions or deadlocks. A utility method is available to wait for all preceding events that were triggered to complete, which is useful for unit tests. Reimplement how balance futures work in order to avoid the wallet registering an event handler on itself, this means you cannot accidentally deadlock yourself by running getBalanceFuture().get() inside an event listener.
Future changes will modify how transaction confidence listeners are run to work the same way, and make other kinds of event listener run in the user code thread as well.
The user code mechanism is usable with any executor, opening up the possibility of automatically relaying event listeners into GUI threads for some kinds of apps.
2013-07-05 10:54:18 +02:00
Mike Hearn
b87879fd42
Rename the Locks class to Threading in preparation for more stuff.
2013-07-05 10:54:18 +02:00
Mike Hearn
1296074e8f
Add another Block c'tor. Resolves issue 424.
2013-07-04 12:12:52 +02:00
Mike Hearn
4265e9c692
Optimize imports in payment channels.
2013-07-03 15:18:20 +02:00
Matt Corallo
715e3596d2
Fix another deadlock when storing channel in wallet
2013-07-03 14:53:59 +02:00
Matt Corallo
8fd8683461
JavaDoc in StoredServerChannel + updateValueToMe s/public//
2013-07-03 14:53:54 +02:00
Matt Corallo
c36e725d7d
Use Reentrant locks in a few more places, fix deadlocks(s) on close
2013-07-03 14:53:46 +02:00
Mike Hearn
2d84b3c27b
Deasymock PaymentChannelStateTest
2013-07-03 14:49:43 +02:00
Mike Hearn
a5940282d0
Rewrite ChannelConnectionTest to avoid easyMock, duplication and busy wait loops.
2013-07-02 11:55:37 +02:00
Mike Hearn
93abc34e08
Narrow PeerGroup -> TransactionBroadcaster in the channels code.
2013-07-01 13:17:57 +02:00
Mike Hearn
ec51162ae4
Correct PaymentChannelServerListener class javadoc.
2013-07-01 13:13:29 +02:00
Matt Corallo
4908c241f7
Implement server-side and client-side payment channel protocols.
...
This implements micropayment payment channels in several parts:
* Adds PaymentChannel[Server|Client]State state machines which
handle initialization of the payment channel, keep track of
basic in-memory state, and check data received from the other
side, based on Mike Hearn's initial implementation.
* StoredPaymentChannel[Client|Server]States manage channel
timeout+broadcasting of relevant transactions at that time,
keeping track of state objects which allow for channel
resume, and are saved/loaded as a WalletExtension.
* Adds PaymentChannel[Client|Server] which manage a connection
by getting new protobufs, generating protobufs for the other
side, properly stepping the associated State object and
ensuring the StoredStates object is properly used to save
state in the wallet.
* Adds PaymentChannel[ClientConnection|ServerListener] which
create TCP sockets to each other and use
PaymentChannel[Client|Server] objects to create/use payment
channels.
The algorithm implemented is the one described at
https://en.bitcoin.it/wiki/Contracts#Example_7:_Rapidly-adjusted_.28micro.29payments_to_a_pre-determined_party
with a slight tweak to use looser SIGHASH flags so that the
Wallet.completeTx code can work its magic by adding more inputs if
it saves on fees.
Thanks to Mike Hearn for the initial state machine implementations
and all his contracts work and Jeremy Spilman for suggesting the
protocol modification that works with non-standard nLockTime
Transactions.
2013-06-27 14:15:49 +02:00
Matt Corallo
3d74934b6f
Add a length-prefixed protobuf connection server/client.
...
This forms the base for payment channel network connections, with
a simple single-threaded server which accepts new connections, a
simple single-threaded client which makes a single connection to a
server, and a ProtobufParser which handles data generated by a
connection, splits them into Protobufs and provides a reasonable
interface to users who wish to create/accept protobuf-based
connections.
2013-06-27 14:15:44 +02:00
Matt Corallo
65202b8ab5
Add support for WalletExtensions to WalletAppKit.
2013-06-27 14:15:43 +02:00
Matt Corallo
880b413b24
Add a TransactionBroadcaster abstraction to PeerGroup.
2013-06-27 14:15:43 +02:00
Matt Corallo
7cd38bc77a
Wallet: Enable autoSaveListener for 0-delay autosave.
2013-06-27 14:15:42 +02:00
Mike Hearn
c4572696b1
Some fixes to wallet serialization:
...
1) Switch the outpoint index field to be uint32 and fix isCoinBase() to consider the unsigned versions only. Resolves issue 420.
2) Regenerate the protobuf and fix an out of date definition in WalletProtobufSerializer that it exposed.
2013-06-27 14:01:02 +02:00
Mike Hearn
7f68923529
KeyCrypterScryptTest: Clear static analysis warnings and port to junit 4.
2013-06-24 17:52:09 +02:00
Mike Hearn
0c00b24bbc
Disable native secp256k1 so DCE can delete the relevant code entirely.
2013-06-24 17:48:58 +02:00
Mike Hearn
fbd767320c
Delete the long since obsolete DiskBlockStore.
2013-06-20 15:10:47 +02:00
Mike Hearn
85cd4499f9
Delete NamedSemaphores. It's something that was introduced by Miron
...
and looks like a broken attempt to implement file locking. Neither
store that tried to use it is supporte anymore so don't bother replacing
with real file locks.
2013-06-19 15:43:18 +02:00
Mike Hearn
4d4768ba8c
Fixup last commit
2013-06-19 15:34:05 +02:00
Mike Hearn
ad3bb53327
Allow TransactionInput.verify to take an output as a parameter.
2013-06-19 13:08:09 +02:00
Mike Hearn
f98088221e
Make TransactionOutput.getMinNonDustValue() more documented and provide a simpler function for it.
2013-06-19 11:30:27 +02:00
Mike Hearn
215a131f8b
Typo fix in ECKey
2013-06-19 11:30:27 +02:00
Mike Hearn
354446dd40
Add new helper methods to Transaction[Signature]
...
Add a method for signing a given input and use it.
Convert some code that was working with raw bytes to use TransactionSignature.
Rename Transaction.hashTransactionForSignature to just hashForSignature.
General API tweaks and cleanups.
2013-06-19 11:30:27 +02:00
Mike Hearn
57c1ecbd01
Refactor some code in ECKey into ECKey.ECDSASignature, and introduce a new TransactionSignature class.
...
It extends ECDSASignature and adds support for holding and working with sighash flags. Make some code use it instead of raw byte handling.
2013-06-19 11:30:26 +02:00
Mike Hearn
2149fea7e6
TODO: KeyCrypterScryptTest sometimes fails because key crypto is still relying on padding bytes in some cases.
2013-06-18 17:35:35 +02:00
Mike Hearn
5be443c2d3
Clear some minor static analysis warnings.
2013-06-18 16:33:56 +02:00
Mike Hearn
8b8bf50144
Version 0.10-SNAPSHOT
2013-06-18 16:33:06 +02:00
Mike Hearn
bfbc9c0cf6
Don't use my DNS seed. It's not running on secure hosting so I shut it down.
2013-06-17 16:11:20 +02:00
Mike Hearn
4494d34be0
Use correct private key header byte in reg test mode.
2013-06-17 15:43:57 +02:00
Mike Hearn
960bf2626b
DumpedPrivateKey: Verify that the final byte is set to 1. Resolves issue 411.
2013-06-17 15:43:46 +02:00
Mike Hearn
d8a0cc59c1
Re-order ECKey imports.
2013-06-17 14:28:48 +02:00
Matt Corallo
be88a05c93
Make TransactionOutput.getMinNonDustOutput exact.
2013-06-17 11:07:55 +02:00
Matt Corallo
d6fec93be3
Add canonical signature/pubkey methods to ECKey and tests therefor.
2013-06-17 11:07:55 +02:00
Matt Corallo
ec3708d159
Introduce SIGHASH_ANYONECANPAY_VALUE to replace 0x80 constants.
2013-06-17 10:59:25 +02:00
Matt Corallo
1e24dea569
Fix wallet extensions by adding setKeyCrypter and using auto-save.
2013-06-17 10:59:15 +02:00
Matt Corallo
e2e72a275d
Fix deserialization of wallet transactions with a far-out locktime.
2013-06-17 10:59:06 +02:00
Matt Corallo
63be9b705b
Make all addOutputs and addInputs return the newly added in/output.
2013-06-17 10:59:00 +02:00
Matt Corallo
5f1a9c246b
Add Wallet.maybeCommitTx to not throw when tx is already in pending
2013-06-14 15:04:31 +02:00
Mike Hearn
74110a12d9
Note that a tx of exactly 1000 bytes may overpay.
2013-06-12 17:42:18 +02:00
Mike Hearn
c91e811fc7
Make SendRequest.completed back to being private.
2013-06-12 17:26:12 +02:00
Mike Hearn
87ab410a2f
Make feePerKb apply to the first kilobyte as well.
2013-06-12 17:16:07 +02:00
Mike Hearn
c9f0ecae3d
Delete 3 fee tests that weren't adding any coverage and Matt can't remember what they're for.
2013-06-12 16:21:02 +02:00
Mike Hearn
20049fb9f8
Use RegTestParams.get()
2013-06-12 11:11:59 +02:00
Mike Hearn
80b66a8945
Split a bit more code out of the giant fee calculation function.
2013-06-11 12:29:28 +02:00
Mike Hearn
b865e6a510
Make Transaction.addInput(TransactionOutput) return the created input. Use it to make a minor simplification.
2013-06-11 12:24:14 +02:00
Mike Hearn
6077d32c4a
Refactor fee calculation out of wallet.completeTx(). Introduce a (not widely used yet) InsufficientMoneyException.
2013-06-11 12:21:20 +02:00
Mike Hearn
46914b12b7
Make completeTx once again return a bool (pending replacement with an exception), and update the fee field with the calculated fee.
2013-06-11 11:40:40 +02:00
Mike Hearn
afaebd062a
Rename enforceDefaultClientFeeRelayRules to ensureMinRequiredFee which is shorter.
2013-06-10 16:02:38 +02:00
Mike Hearn
9a389c9475
Move enforceDefaultClientFeeRelayRules into SendRequest instead of being a parameter.
...
Make WalletTool enforce the rules instead of ignoring them (this was an oversight).
2013-06-10 15:51:34 +02:00
Matt Corallo
518b7edcbd
Handle null hostNames in DnsDiscovery (some NP have that).
2013-06-10 13:38:01 +02:00
Matt Corallo
c9d411e8e7
Add two new WalletExtension access methods.
2013-06-10 13:36:33 +02:00
Matt Corallo
a3f1fe5390
Tweak WalletExtension slightly.
2013-06-10 13:36:27 +02:00
Matt Corallo
a7987585b8
Catch out-of-bound reads and rethrow as ProtocolExceptions.
2013-06-10 13:36:20 +02:00
Matt Corallo
dbf7728b4f
Add uint64ToByteArrayLE to Utils.
2013-06-10 13:36:14 +02:00
Mike Hearn
a525f878ca
More fixing of regtest params.
2013-06-07 16:15:36 +02:00
Mike Hearn
90fda575b6
Make bitcoind comparison tool simple to run again.
2013-06-07 13:59:20 +02:00
Mike Hearn
651880405d
Fix regtest params.
2013-06-07 13:59:10 +02:00
Mike Hearn
1288774ee4
Fix a generics warning.
2013-06-05 16:58:58 +02:00
Mike Hearn
50539ff6c2
Remove nonsensical comment: shuffling inputs does not grant extra privacy.
2013-06-05 16:49:18 +02:00
Mike Hearn
033e7e7aab
Some minor clarity improvements to DefaultCoinSelector.
2013-06-05 16:48:02 +02:00
Mike Hearn
0bdba0318a
Clear some static analysis warnings from the inspector - many assertions could be simplified and assertEquals is (expected, actual) not (actual, expected).
2013-06-05 16:41:14 +02:00
Matt Corallo
7daa54b12c
Add a few more fee solver tests.
2013-06-05 16:29:16 +02:00
Matt Corallo
c9c107afaf
Make getBalance() significantly faster.
2013-06-05 16:29:11 +02:00
Matt Corallo
72f346c10f
Add tests for user-specified inputs in SendRequests.
2013-06-05 16:29:06 +02:00
Matt Corallo
375e553bdc
Add basic fee solver to Wallet.completeTx and extensive testing.
...
This also adds support for SendRequests which have some predefined
inputs (already signed), which will be tested in a later commit.
2013-06-05 16:28:35 +02:00
Matt Corallo
86046b7122
Add comments on dust output values and constants/util to calc them
2013-06-05 16:24:39 +02:00
Matt Corallo
4b1e45fae2
Make DefaultCoinSelector aware of priority, not just depth.
2013-06-05 16:11:35 +02:00
Matt Corallo
842b30e2ca
Add basic support for existing inputs in Transaction.signInputs
2013-06-05 16:11:27 +02:00
Matt Corallo
fd4845fa90
Add new data-driven test-case
2013-06-05 14:10:42 +02:00
Matt Corallo
c6b3b82a66
Fix TxOut serialization (fixes SIGHASH_SINGLE hashing)
2013-06-05 14:10:41 +02:00
Matt Corallo
07baa230f3
Wallet: Check if tx is time-locked not just has a lock time
2013-06-05 14:10:41 +02:00
Matt Corallo
e2fea77a3d
Catch potential exception on invalid signatures
2013-06-05 14:10:41 +02:00
Matt Corallo
fb912322ff
Replace Block.fakeClock with Utils.mockClock
2013-06-05 14:10:41 +02:00
Matt Corallo
5369ca925a
Add Transaction.clearIn/Outputs and make getIn/Outputs unmodifiable
2013-06-05 14:10:40 +02:00
Matt Corallo
5993f2dc6c
Further global replace of NetworkParameters.* -> *.get()
2013-06-05 14:10:40 +02:00
Mike Hearn
f4c3b6a49d
Global search and replace to use the param-class specific instance getters and prodNet -> MainNetParams.
...
The old "prodnet" name could be confusing to non-native speakers or people who just haven't been exposed to Google lingo. Main net is more idiomatic.
Conflicts:
tools/src/main/java/com/google/bitcoin/tools/BlockImporter.java
2013-06-05 14:10:40 +02:00
Mike Hearn
52586edb33
NetworkParameters: Refactor out into separate classes.
...
Hide fields behind getters and make unit tests create anonymous subclasses
to tweak them rather than overwriting global variables.
Introduce a regtest params class for use in the comparison tool.
Conflicts:
core/src/test/java/com/google/bitcoin/core/BitcoindComparisonTool.java
core/src/test/java/com/google/bitcoin/core/FullPrunedBlockChainTest.java
2013-06-05 14:10:39 +02:00
Mike Hearn
f6f290cc05
NetworkParameters: hide more params behind a getter.
2013-06-05 14:10:39 +02:00
Mike Hearn
1f005d7b3d
NetworkParameters: hide packet magic behind a getter.
...
Conflicts:
tools/src/main/java/com/google/bitcoin/tools/BlockImporter.java
core/src/main/java/com/google/bitcoin/utils/BlockFileLoader.java
core/src/test/java/com/google/bitcoin/core/FullBlockTestGenerator.java
2013-06-05 14:10:39 +02:00
Mike Hearn
8043bc335b
NetworkParameters: hide port behind a getter.
2013-06-05 14:10:38 +02:00
Mike Hearn
ec62bbdeab
NetworkParameters: hide genesis block behind a getter.
...
Conflicts:
core/src/test/java/com/google/bitcoin/core/FullBlockTestGenerator.java
2013-06-05 14:10:38 +02:00
Mike Hearn
619495875c
Block: Make some things public that aren't going to change.
...
Conflicts:
core/src/main/java/com/google/bitcoin/core/Block.java
2013-06-05 14:10:38 +02:00
Matt Corallo
28292b45a5
Implement dumb Comparable in Sha256Hash.
2013-06-05 14:10:37 +02:00
Matt Corallo
6cdfad43a3
Make Tx.connect public by exposing enums + tweak DISCONNECT_ON_CONFLICT
2013-06-05 14:10:37 +02:00
Matt Corallo
f7c09d74ea
Introduce Transaction.hasLockTime() and use it where appropriate.
2013-06-05 14:10:37 +02:00
Matt Corallo
2bd9531da6
Add txout.setValue, public decodeFromOpN+appendByte new MultiSig.
2013-06-05 14:10:37 +02:00
Matt Corallo
b840ddfcc8
Require bitcoind replies to a inv instead of just sending blocks.
...
This makes b57 testing actually useful.
2013-06-05 14:10:36 +02:00
Matt Corallo
60520ba17a
Add new data-driven tests from the reference client
2013-06-05 14:10:36 +02:00
Matt Corallo
fad5356bd9
Properly uncache scriptSig in TransactionInput.setScriptBytes
2013-06-05 14:10:36 +02:00
Matt Corallo
70685745c3
Fix a possible ArrayIndexOOBEx in Script processing (cleaner error).
2013-06-05 14:10:36 +02:00
Matt Corallo
304bc705b8
Fix script parsing bug and test for it (partially reverts 7837a54
)
2013-06-05 14:10:23 +02:00
Matt Corallo
e8ea5cea7c
Re-enable port selection as pull-tester will need it
2013-06-04 22:18:11 +02:00
Matt Corallo
a1c1a1117a
Rename blocks in FullBlockTestGenerator to make new tests easier
2013-06-04 22:18:11 +02:00
Matt Corallo
f9ebf56047
Test importing first 100K of blocks.
2013-06-04 22:18:11 +02:00
Matt Corallo
68e6228356
Handle duplicate chain.add calls significantly more effeciently.
2013-06-04 22:18:11 +02:00
Matt Corallo
729f2f5312
Store blocks on disk during BitcoindComparisonTool to save memory.
2013-06-04 22:18:11 +02:00
Matt Corallo
a131d08a58
Move BlockImporter to a util and make it an Iterator<Block>
2013-06-04 22:18:11 +02:00
Matt Corallo
1dadb33c28
Split expensive blocks into sigExpensive and largeReorg.
2013-06-04 22:18:11 +02:00
Matt Corallo
9cbd824457
Create very large reorg test.
2013-06-04 22:18:10 +02:00
Matt Corallo
0390bc9371
Add height info to FullBlockTests, to verify the tests are correct.
2013-06-04 22:18:10 +02:00
Matt Corallo
9ddbcb88b9
Make txCounter work for larger values.
2013-06-04 22:18:10 +02:00
Matt Corallo
2e5ca9e72b
Allow FullBlockTestGenerator to indicate maximum reorg depth.
2013-06-04 22:18:10 +02:00
Matt Corallo
0ada33d2b1
Provide more opacity into exceptions.
2013-06-04 22:18:10 +02:00
Matt Corallo
939337b2db
Fix premature optimization in H2FullPrunedBlockStore (resets state)
...
This replaces the H2FullPrunedBlockStore schema with one that will
take (maybe) some more disk space while being a good bit faster.
The tradeoff made was really not worth it.
Also adds a version field to settings database incase something
other than schema changes in the future.
2013-06-04 22:18:10 +02:00
Matt Corallo
59e096e2ea
Add optional support native ECDSA (designed for sipa's impl).
...
This could be significantly more optimized if we avoided crossing
the JNI barrier as often, but as it is its waaay faster than
BouncyCastle.
2013-06-04 22:18:10 +02:00
Matt Corallo
70bffcd6f4
Move onPeerConnected to after VerAck.
2013-05-22 22:46:10 +02:00
Mike Hearn
f1750679b6
Use non-deprecated asserts in AlertMessageTest. Found by IntelliJ inspections.
2013-05-08 16:33:22 +02:00
Mike Hearn
2830d48ac1
Simply a few assertions.
2013-05-08 15:42:27 +02:00
Mike Hearn
1463213f25
Use port 18444 for regtest mode.
2013-05-08 14:30:15 +02:00
Mike Hearn
9d5b3865f5
Wallet: remove an unused variable from reorganize().
2013-05-07 12:48:34 +02:00
Mike Hearn
e2291d2fb4
Wallet: remove the affectedUs check in reorganize(). It was buggy, and if it had worked it would have introduced other issues. We always need to process the entire reorg to keep the depth and workDone counters on transactions accurate.
2013-05-07 12:00:50 +02:00
Mike Hearn
4886a137bc
TransactionConfidence: make accessors return zero rather than throw when pending, and add a method to get a depth future.
2013-05-06 17:59:31 +02:00
Mike Hearn
bacc67f26f
Peer: fix buggy log statement.
2013-05-06 17:34:48 +02:00
Mike Hearn
857da6bb29
AbstractBlockChain: add a helper method to create futures that complete when the chain reaches a particular height.
2013-05-06 16:23:08 +02:00
Mike Hearn
9a20c39b15
A few simplifications suggested by IntelliJ
2013-05-06 16:21:32 +02:00