Mike Hearn
d14ac586d7
Add a few basic sanity checks on transactions received from the network at various points, to avoid syntactically invalid transactions from getting into the system (e.g. no inputs or outputs).
2013-04-12 11:10:48 +02:00
Mike Hearn
21ba7e0260
MemoryPool: Clarify logging a bit.
2013-04-12 11:10:38 +02:00
Mike Hearn
5eebca2c7d
Wallet: Add some convenience methods for spending unconfirmed transactions.
2013-04-12 11:10:31 +02:00
Mike Hearn
f1845dd552
Version 0.9-SNAPSHOT
2013-04-11 14:27:35 +02:00
Mike Hearn
d64f555896
Wallet: fix logging of balance in receive() and only calculate the balance once instead of twice.
...
Resolves issue 372.
2013-04-01 18:14:20 +01:00
Mike Hearn
bfd9d81b21
Undo a couple of changes to NetworkParameters to fix the bitcoind comparison tool
2013-04-01 18:08:14 +01:00
Matt Corallo
2a33065e31
Add a bitcoind/bitcoinj testing tool that compares bitcoind's rules
...
...by creating blocks and then comparing their acceptance by
bitcoind to their acceptance by bitcoinj.
2013-04-01 18:05:35 +01:00
Matt Corallo
1f904d28e1
Fix balooning memory usage in FullPrunedBlockChain.
...
This fixes a bug which had been previously solved with a dumb
workaround.
2013-04-01 18:05:01 +01:00
Matt Corallo
726dd02472
Propogate very old refactor to duplicate code.
2013-04-01 18:02:50 +01:00
Matt Corallo
1b830a10e6
Add comment about using a large fast catchup time in PeerGroup.
2013-04-01 18:02:34 +01:00
Mike Hearn
cb670bdc39
BOBS: Suppress deprecation warning.
2013-04-01 18:02:29 +01:00
Mike Hearn
d92f944564
Peer: Allow peer listeners to handle exceptions thrown in the peer thread.
2013-03-30 19:28:58 +00:00
Mike Hearn
11b5ea11b8
WalletProtobufSerializer: throw IllegalArgumentException if tx cannot be connected.
2013-03-30 18:06:40 +00:00
Mike Hearn
9201cba0cc
Wallet: try deleting the temp file in the finally block and print a warning if it succeeded.
...
Resolves issue 362.
2013-03-30 17:35:57 +00:00
Mike Hearn
301db707b1
Wallet: misc comment updates
2013-03-30 17:35:07 +00:00
Mike Hearn
49d26ad773
WalletProtobufSerializer: Add a couple of NPE checks
2013-03-30 17:34:30 +00:00
Mike Hearn
7307308915
WalletProtobufSerializer: Clear txMap after reading.
...
Resolves issue 380.
2013-03-30 17:23:34 +00:00
Mike Hearn
616b4a5a7d
PeerGroup: make selectDownloadPeer non static so users can override it and control selection behaviour.
2013-03-29 18:26:40 +00:00
Mike Hearn
9e870f40bf
DnsDiscovery: Rewrite to use better abstractions and remove some arbitrary magic numbers.
...
Resolves issue 346.
2013-03-29 18:18:45 +00:00
Mike Hearn
08dbb21a39
H2 store: Set a 60 second locking timeout to avoid failures when processing large/complex operations.
...
Resolves issue 348.
2013-03-29 18:00:46 +00:00
Mike Hearn
a78b53c5aa
AbstractBlockChain: Fix median timestamp calculation.
...
Resolves issue 370.
2013-03-29 17:56:28 +00:00
Mike Hearn
3d6691c82a
Switch to using DNS for testnet discovery, as LFnet has gone away.
...
Put DNS seeds into NetworkParams.
Deprecate IrcDiscovery and remove the unit tests for it.
Update examples and tools to use DNS for everything.
Resolves issue 299.
2013-03-29 17:39:24 +00:00
Mike Hearn
41ce887652
Fix TCPNetworkConnection.connectTo() which broke during a previous re-factor. It's not often used so it wasn't noticed.
2013-03-29 17:34:23 +00:00
Mike Hearn
89d45b638f
WalletTest: Remove temp code that snuck in to the tests accidentally.
2013-03-29 17:21:38 +00:00
Mike Hearn
89079fd8d4
WalletTest: Heterogeneous is hard to spel corectly :) Also it's probably unfamiliar to non native speakers. Replace it with the simpler word "mixed".
2013-03-29 17:07:22 +00:00
Mike Hearn
4273dacc00
Check that the private key decrypted correctly in ECKey.sign(). Resolves issue 359.
2013-03-29 17:05:39 +00:00
Mike Hearn
7b8eab19ff
Use a bit of Guava for unsigned longs. Resolves issue 367.
2013-03-29 16:41:28 +00:00
Mike Hearn
4f1c7f4816
Throw BlockStoreException not NullPointerException when chain head cannot be found in SPVBlockStore. Resolves issue 374.
2013-03-27 17:57:00 +01:00
Mike Hearn
3c6f435fde
More changes/simplifications to PeerGroup locking.
2013-03-27 17:44:51 +01:00
Mike Hearn
61c8c07468
Make wallet description private. Resolves issue 368.
2013-03-27 11:57:29 +01:00
Mike Hearn
8e0c72597c
Add JSR305 annotations. Bump Guava version. Resolves issue 347.
2013-03-21 17:19:36 +01:00
Mike Hearn
df257e8589
Don't dump entire block to log when a split happens.
2013-03-21 16:42:34 +01:00
Mike Hearn
56285da06c
Lots of bug fixes to double spend handling.
...
Fix some corruptions that could occur during a Finney attack. Resolves issue 182.
2013-03-21 16:14:16 +01:00
Mike Hearn
76e539e8e7
Simplify the handling of double spends somewhat.
2013-03-21 15:25:52 +01:00
Mike Hearn
608810cfc1
Improvements to tx handling in the wallet.
...
Attach inputs of pending transactions when relevant transactions appear in the chain. Resolves issue 345.
Check transactions for being double spends independent of whether they send/receive us money. Resolves a potential security issue.
2013-03-21 14:24:59 +01:00
Mike Hearn
e449c77026
Don't rely on padding checks to tell us if the decryption was correct.
...
Fix a few minor javadoc issues. Resolves issue 356.
2013-03-19 17:30:08 +01:00
Mike Hearn
89d30142c3
Fix some labels in the wallet encryption tests.
2013-03-19 17:29:26 +01:00
Mike Hearn
b7eab44990
Remove a couple of checkNotLocked asserts that didn't get deleted last time.
2013-03-19 15:40:31 +01:00
Mike Hearn
7696835f86
Fix over-eager locking in PeerGroup and ensure the resulting code doesn't race, resolving a lock inversion. Also, take into account the possibility of a block being mined before it's fully propagated and add some discussion.
...
Resolves issue 353.
2013-03-19 15:21:24 +01:00
Mike Hearn
0548e983ed
Fix a race condition in the memory pool code. Update issue 353.
2013-03-19 14:55:12 +01:00
Mike Hearn
8b437eaf95
Fix a thread safety issue. Update issue 353.
2013-03-19 14:54:00 +01:00
Mike Hearn
e5265a5342
Add more comments explaining Bloom filtering to avoid confusion.
2013-03-18 23:24:59 +01:00
Mike Hearn
57b4774985
Clean up another listener invocation a bit.
2013-03-18 23:24:59 +01:00
Mike Hearn
c988212441
Remove a redundant null check in checkAESKey()
2013-03-18 18:27:13 +01:00
Mike Hearn
dc433761dd
Print whether a key is encrypted or not in ECKey.toString()
2013-03-18 18:27:13 +01:00
Mike Hearn
33499aab78
JavaDoc fix to KeyCrypter.
2013-03-18 18:27:13 +01:00
Mike Hearn
7799024c5c
Don't dump the salt bytes in toString() and change how it's printed.
2013-03-18 18:27:13 +01:00
Mike Hearn
732c5e631e
Make it easier for people to override just the tx eligibility behavior in DefaultCoinSelector by using a protected method.
2013-03-18 18:27:13 +01:00
Mike Hearn
aaa2ec4c5a
Add some convenience methods for encrypted wallets. Minor style fixes.
2013-03-18 18:27:13 +01:00
Mike Hearn
5d0518dafd
Merge encrypted wallets functionality by Jim Burton.
2013-03-18 18:27:12 +01:00
Mike Hearn
17efb4d6b7
Add more logging and fix a bug in the dependency resolution process that occurred when using ping/pongs instead of notfound. It could result in hung dependency resolution and interfered with block downloads.
2013-03-18 17:33:54 +01:00
Mike Hearn
32353bdc2e
Bit more logging in TCPNetworkConnection
2013-03-18 17:33:16 +01:00
Mike Hearn
311e0549b9
Delete unneeded pong logging. Resolves issue 352.
2013-03-18 10:44:16 +01:00
Mike Hearn
1ed2459522
More minor issues found by IntelliJ static analysis.
2013-03-15 17:19:28 +01:00
Mike Hearn
3a899767b4
Clear some minor cosmetic issues found by IntelliJ static analysis.
2013-03-15 17:14:07 +01:00
Mike Hearn
c2e96be58b
Remove obsolete code that handled migration from java serialized wallets.
2013-03-15 17:12:52 +01:00
Mike Hearn
3db55946df
Fix another stupid bug in the pinging code that could cause crashes.
2013-03-15 16:03:02 +01:00
Mike Hearn
e140662ea2
Fix a regression in saving wallets on Windows.
2013-03-13 12:23:12 +01:00
Mike Hearn
9bc9a4b262
For now, throw on cycles. Also remove checkNotLocked(), as it isn't actually the right thing to do.
2013-03-11 16:07:33 +01:00
Mike Hearn
c351df567e
PeerGroup: Remove a now-useless synchronized block and mark a few more fields final.
2013-03-11 15:48:46 +01:00
Mike Hearn
a6d0c9169b
Clear a few more misc IntelliJ inspection alerts.
2013-03-11 15:06:27 +01:00
Mike Hearn
fb9bfb960e
Fix a bug that would cause ping nonces to always be set to zero, thus screwing up perceived ping times.
2013-03-11 15:02:16 +01:00
Mike Hearn
4d01e107fa
No-op: auto-simplify a few constructs
2013-03-11 14:58:47 +01:00
Mike Hearn
ac8a5008fe
Add JCIP thread annotations jar and use @GuardedBy in Peer.
...
Unlock Peer almost completely and make it fully thread safe with minimal use of locking.
Introduce a new convention that volatile variables have a v prefix.
2013-03-11 14:51:15 +01:00
Mike Hearn
45ce6fe9df
Bit more debugging code in TestWithNetworkConnections
2013-03-11 14:30:10 +01:00
Mike Hearn
c21f182d78
Move refreshing of the bloom filter out of the PeerGroup and into the Peer, where it belongs.
2013-03-11 12:39:46 +01:00
Mike Hearn
bffc85fa24
Move message processing out of the handler class and into the top-level Peer class.
2013-03-11 12:25:10 +01:00
Mike Hearn
b2ab3e1c43
Delete EventListenerInvoker, it is no longer needed.
2013-03-11 12:21:42 +01:00
Mike Hearn
971c9c5999
Remove more usages of EventListenerInvoker in PeerGroup and fix a TODO.
2013-03-11 12:21:01 +01:00
Mike Hearn
081663f857
Remove event listener in PeerGroup.removeWallet() to avoid a memory leak.
...
Resolves issue 344.
2013-03-11 12:10:41 +01:00
Mike Hearn
807447ca1a
Unlock Peer event listeners.
2013-03-07 18:43:23 +01:00
Mike Hearn
2333c44657
Add a comment.
2013-03-07 18:43:15 +01:00
Mike Hearn
c8c1e68152
Unlock TransactionConfidence event listeners, make sure MemoryPool is not locked when a tx is marked broadcast by a peer to avoid inversions via listeners.
...
Unfortunately this introduces some new FindBugs warnings because it doesn't understand the inside-out locking pattern used here, despite that it's correct.
Update issue 233.
2013-03-07 17:38:13 +01:00
Mike Hearn
0534231de9
Run wallet event listeners unlocked. Resolves another inversion.
...
Update issue 223.
2013-03-07 17:08:15 +01:00
Mike Hearn
0c30050a97
Delete the cycle test, we can trust that Guava works.
2013-03-07 17:08:15 +01:00
Mike Hearn
f0aff6484e
Narrow the locking in Peer.processInv() to avoid invoking memoryPool.seen() with the Peer lock held.
...
This resolves an inversion that can occur if a transaction confidence listener is run due to being marked as broadcast.
Update issue 233.
2013-03-07 17:08:07 +01:00
Mike Hearn
2fb3667c42
Add a 1-liner Locks.checkNotLocked method to make it clearer than writing checkState(!lock.isLocked());
2013-03-07 16:18:53 +01:00
Mike Hearn
0221b71418
Convert block chain to use a cycle detecting lock.
2013-03-07 15:57:50 +01:00
Mike Hearn
9d87997736
Some more tweaks to the Locks class.
2013-03-07 15:36:07 +01:00
Mike Hearn
9de6dca8c1
Move cycle detecting lock creation out into a new Locks class, rather than stuff it into Utils.
...
Convert PeerGroup and Peer to also use cycle detecting locks, and add a unit test to Wallet to check that cycle detection works.
Change default policy to warn. Now warnings are being triggered, the followup commits will fix them.
2013-03-07 13:58:04 +01:00
Mike Hearn
94670f3df0
Make Peer.memoryPool final and introduce a new c'tor for it.
2013-03-06 16:08:52 +01:00
Mike Hearn
83308c6ee1
Clear another FindBugs warning in SPVBlockStore.
...
The analysis doesn't seem to be good enough to detect that some of these cases are safe.
2013-03-06 15:52:39 +01:00
Mike Hearn
b780c6f191
Silence a FindBugs warning in Utils.
...
This isn't a real bug as unit tests aren't multi-threaded, but the analysis can't know that.
2013-03-06 15:51:45 +01:00
Mike Hearn
5a16a3d3fe
Silence a couple of FindBugs warnings.
2013-03-06 15:51:17 +01:00
Mike Hearn
1ba2c9d5de
Use a cycle detecting lock in Wallet and convert its event listeners array to a COW list.
...
This does not currently detect or break any cycles, even though some are known.
2013-03-06 15:10:52 +01:00
Mike Hearn
23aa1a9105
Tweak DefaultCoinSelector.isSelectable to take a Transaction as a parameter.
...
Resolves issue 322.
2013-03-06 14:47:30 +01:00
Mike Hearn
f7fa0cda72
Make the use of cycle detecting locks optional at compile time.
2013-03-06 13:51:27 +01:00
Mike Hearn
de653cc42d
Mark BoundedOverheadBlockStore as deprecated.
2013-03-06 13:47:09 +01:00
Mike Hearn
53fcef761e
BitCoin -> Bitcoin
2013-03-06 13:12:27 +01:00
Mike Hearn
e57068451d
Split some selection logic into a static method of DefaultCoinSelector. Resolves issue 322.
2013-03-06 12:13:34 +01:00
Mike Hearn
27a49655fb
Update language level in the POM.
...
Updates issue 334.
2013-03-06 11:59:53 +01:00
Mike Hearn
96cd35f139
Add a convenience method to CheckpointManager and example of how to use in PingService.
2013-03-05 14:48:28 +01:00
Mike Hearn
7f17766b47
Minor javadoc improvement.
2013-03-05 14:48:28 +01:00
Mike Hearn
0419887407
Add a CheckpointManager class and a BuildCheckpoints tool that saves a set of checkpoints to disk. By default there is one every difficulty transition period (two weeks), which means a relatively small amount of RAM needed to hold them all. There are only 111 checkpoints so far and old ones can be thinned out if needed.
2013-03-05 14:48:28 +01:00
Mike Hearn
b4c835c0cf
Quieten a noisy debug line when downloading the block chain.
2013-03-05 14:48:28 +01:00
Mike Hearn
68907880cb
Refactor compact serialization out of SPVBlockStore and into StoredBlock.
2013-03-05 14:48:28 +01:00
Mike Hearn
18a14c6668
Indent fix
2013-03-05 14:48:28 +01:00
Mike Hearn
61410adbaa
Fix BOBS bug introduced by my optimizations.
2013-03-05 14:48:28 +01:00
Mike Hearn
fb56237de8
Fix a couple of unit tests and resolve Matts comment.
2013-03-05 14:48:28 +01:00
Mike Hearn
50323391e5
Misc optimizations, the profiles look much better now.
2013-03-05 14:48:28 +01:00