Qortal/pirate-librustzcash
1
0
Fork 1
mirror of https://github.com/Qortal/pirate-librustzcash.git synced 2025-07-31 20:41:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix broken linear relation checking

Browse Source
This commit is contained in:
Taylor Hornby
2019-03-12 16:37:04 -06:00
committed by Jack Grigg
parent 15b4c37ab0
commit e391594e9e
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zcash_primitives/src/jubjub/mod.rs
View File

@@ -429,13 +429,10 @@ impl JubjubBls12 {
tmp_params: &E::Params, tmp_params: &E::Params,
pedersen_hash_generators: &[edwards::Point<E, PrimeOrder>], pedersen_hash_generators: &[edwards::Point<E, PrimeOrder>],
) { ) {
let sum = &edwards::Point::zero();
for (i, p1) in pedersen_hash_generators.iter().enumerate() { for (i, p1) in pedersen_hash_generators.iter().enumerate() {
if p1 == &edwards::Point::zero() { if p1 == &edwards::Point::zero() {
panic!("Neutral element!"); panic!("Neutral element!");
} }
// Used for checking no generator is a sum of previous ones.
let sum = &sum.add(&p1, &tmp_params);
for p2 in pedersen_hash_generators.iter().skip(i + 1) { for p2 in pedersen_hash_generators.iter().skip(i + 1) {
if p1 == p2 { if p1 == p2 {
panic!("Duplicate generator!"); panic!("Duplicate generator!");
@@ -443,8 +440,21 @@ impl JubjubBls12 {
if p1 == &p2.negate() { if p1 == &p2.negate() {
panic!("Inverse generator!"); panic!("Inverse generator!");
} }
if sum == p2 { }
panic!("Linear relation between generators!");
// check for a generator being the sum of any other two
for (j, p2) in pedersen_hash_generators.iter().enumerate() {
if j == i {
continue;
}
for (k, p3) in pedersen_hash_generators.iter().enumerate() {
if k == j || k == i {
continue;
}
let sum = &p2.add(&p3, &tmp_params);
if sum == p1 {
panic!("Linear relation between generators!");
}
} }
} }
} }