From f99ab768dc88fdb6d4262ea05becf643928f9cd8 Mon Sep 17 00:00:00 2001 From: Jack Grigg Date: Tue, 14 Jan 2020 21:03:39 -0500 Subject: [PATCH] bls12_381: Remove unnecessary references --- bls12_381/src/fp12.rs | 25 +++++++++++-------------- bls12_381/src/fp6.rs | 19 ++++++++----------- 2 files changed, 19 insertions(+), 25 deletions(-) diff --git a/bls12_381/src/fp12.rs b/bls12_381/src/fp12.rs index 5246a6f..735f91e 100644 --- a/bls12_381/src/fp12.rs +++ b/bls12_381/src/fp12.rs @@ -600,24 +600,21 @@ fn test_arithmetic() { // because a and b and c are similar to each other and // I was lazy, this is just some arbitrary way to make // them a little more different - let a = &a.square().invert().unwrap().square() + &c; - let b = &b.square().invert().unwrap().square() + &a; - let c = &c.square().invert().unwrap().square() + &b; + let a = a.square().invert().unwrap().square() + c; + let b = b.square().invert().unwrap().square() + a; + let c = c.square().invert().unwrap().square() + b; - assert_eq!(a.square(), &a * &a); - assert_eq!(b.square(), &b * &b); - assert_eq!(c.square(), &c * &c); + assert_eq!(a.square(), a * a); + assert_eq!(b.square(), b * b); + assert_eq!(c.square(), c * c); + + assert_eq!((a + b) * c.square(), (c * c * a) + (c * c * b)); assert_eq!( - (a + b) * c.square(), - &(&(&c * &c) * &a) + &(&(&c * &c) * &b) + a.invert().unwrap() * b.invert().unwrap(), + (a * b).invert().unwrap() ); - - assert_eq!( - &a.invert().unwrap() * &b.invert().unwrap(), - (&a * &b).invert().unwrap() - ); - assert_eq!(&a.invert().unwrap() * &a, Fp12::one()); + assert_eq!(a.invert().unwrap() * a, Fp12::one()); assert!(a != a.frobenius_map()); assert_eq!( diff --git a/bls12_381/src/fp6.rs b/bls12_381/src/fp6.rs index dc44ebd..3f310dc 100644 --- a/bls12_381/src/fp6.rs +++ b/bls12_381/src/fp6.rs @@ -490,18 +490,15 @@ fn test_arithmetic() { }, }; - assert_eq!(a.square(), &a * &a); - assert_eq!(b.square(), &b * &b); - assert_eq!(c.square(), &c * &c); + assert_eq!(a.square(), a * a); + assert_eq!(b.square(), b * b); + assert_eq!(c.square(), c * c); + + assert_eq!((a + b) * c.square(), (c * c * a) + (c * c * b)); assert_eq!( - (a + b) * c.square(), - &(&(&c * &c) * &a) + &(&(&c * &c) * &b) + a.invert().unwrap() * b.invert().unwrap(), + (a * b).invert().unwrap() ); - - assert_eq!( - &a.invert().unwrap() * &b.invert().unwrap(), - (&a * &b).invert().unwrap() - ); - assert_eq!(&a.invert().unwrap() * &a, Fp6::one()); + assert_eq!(a.invert().unwrap() * a, Fp6::one()); }