compile of tonic

cli/Cargo.toml

@@ -10,7 +10,7 @@ log = "0.4"
 log4rs = "0.8.3"
 shellwords = "1.0.0"
 json = "0.12.0"
-http = "0.1"
+http = "0.2"
 byteorder = "1"
 tiny-bip39 = "0.6.2"
 

cli/src/main.rs

@@ -44,7 +44,7 @@ pub fn main() {
     let server = LightClientConfig::get_server_or_default(maybe_server);
 
     // Test to make sure the server has all of scheme, host and port
-    if server.scheme_str().is_none() || server.host().is_none() || server.port_part().is_none() {
+    if server.scheme_str().is_none() || server.host().is_none() || server.port().is_none() {
         eprintln!("Please provide the --server parameter as [scheme]://[host]:[port].\nYou provided: {}", server);
         return;
     }

lib/Cargo.toml

@@ -4,18 +4,11 @@ version = "0.1.0"
 edition = "2018"
 
 [dependencies]
-tower-grpc = "0.1.1"
-futures = "0.1"
-bytes = "0.4"
 base58 = "0.1.0"
 log = "0.4"
 log4rs = "0.8.3"
 dirs = "2.0.2"
-http = "0.1"
+http = "0.2"
-prost = "0.5"
-tokio = "0.1"
-tower-request-modifier = "0.1.0"
-tower-util = "0.1"
 hex = "0.3"
 protobuf = "2"
 byteorder = "1"
@@ -24,17 +17,20 @@ tiny-bip39 = "0.6.2"
 secp256k1 = "=0.15.0"
 sha2 = "0.8.0"
 ripemd160 = "0.8.0"
-ring = "0.14.0"
 lazy_static = "1.2.0"
-tower-service = "0.2"
-tokio-rustls = "0.10.0-alpha.3"
-rustls = { version = "0.15.2", features = ["dangerous_configuration"] }
-webpki = "0.19.1"
-webpki-roots = "0.16.0"
-tower-h2 = { git = "https://github.com/tower-rs/tower-h2", rev="0865040d699697bbaf1c3b77b3f256b72f98cdf4" } 
 rust-embed = { version = "5.1.0", features = ["debug-embed"] }
 rand = "0.7.2"
 sodiumoxide = "0.2.5"
+ring = "0.16.9"
+
+tonic = { version = "0.1.0-beta.1", features = ["tls", "tls-roots"] }
+bytes = "0.4"
+prost = "0.5"
+prost-types = "0.5"
+tokio = { version = "0.2", features = ["rt-threaded", "time", "stream", "fs", "macros", "uds", "full"] }
+tokio-rustls = "0.12.1"
+webpki = "0.21.0"
+webpki-roots = "0.18.0"
 
 [dependencies.bellman]
 git = "https://github.com/adityapk00/librustzcash.git"
@@ -68,7 +64,7 @@ rev = "188537ea025fcb7fbdfc11266f307a084a5451e4"
 features = ["ff_derive"]
 
 [build-dependencies]
-tower-grpc-build = { git = "https://github.com/tower-rs/tower-grpc",  features = ["tower-hyper"]  }
+tonic-build = "0.1.0-beta.1"
 
 [dev-dependencies]
 tempdir = "0.3.7"

lib/build.rs

@@ -1,12 +1,11 @@
-fn main() {
+fn main() -> Result<(), Box<dyn std::error::Error>> {
-    // Build proto files
+    tonic_build::configure()
-    tower_grpc_build::Config::new()
+         .build_server(false)
-        .enable_server(false)
+         .compile(
-        .enable_client(true)
-        .build(
             &["proto/service.proto", "proto/compact_formats.proto"],
             &["proto"],
-        )
+         )?;
-        .unwrap_or_else(|e| panic!("protobuf compilation failed: {}", e));
     println!("cargo:rerun-if-changed=proto/service.proto");
+    Ok(())
  }
+ 

lib/src/grpcconnector.rs

@@ -1,282 +1,178 @@
 use log::{error};
 
-use std::sync::{Arc};
-use std::net::ToSocketAddrs;
-use std::net::SocketAddr;
-
-use futures::{Future};
-use futures::stream::Stream;
-
-use tower_h2;
-use tower_util::MakeService;
-use tower_grpc::Request;
-
-use tokio_rustls::client::TlsStream;
-use tokio_rustls::{rustls::ClientConfig, TlsConnector};
-
-use tokio::executor::DefaultExecutor;
-use tokio::net::tcp::TcpStream;
-
 use zcash_primitives::transaction::{TxId};
 
 use crate::grpc_client::{ChainSpec, BlockId, BlockRange, RawTransaction, 
                          TransparentAddressBlockFilter, TxFilter, Empty, LightdInfo};
-use crate::grpc_client::client::CompactTxStreamer;
+use tonic::transport::{Channel, ClientTlsConfig};
+use tokio_rustls::{rustls::ClientConfig};
+use tonic::{Request};
 
-mod danger {
+use crate::grpc_client::compact_tx_streamer_client::CompactTxStreamerClient;
-    use rustls;
-    use webpki;
 
-    pub struct NoCertificateVerification {}
+async fn get_client(uri: &http::Uri) -> Result<CompactTxStreamerClient<Channel>, Box<dyn std::error::Error>> {
-
+    let channel = if uri.scheme_str() == Some("http") {
-    impl rustls::ServerCertVerifier for NoCertificateVerification {
+        println!("http");
-        fn verify_server_cert(&self,
+        Channel::builder(uri.clone()).connect().await?
-                              _roots: &rustls::RootCertStore,
+    } else {
-                              _presented_certs: &[rustls::Certificate],
+        println!("https");
-                              _dns_name: webpki::DNSNameRef<'_>,
-                              _ocsp: &[u8]) -> Result<rustls::ServerCertVerified, rustls::TLSError> {
-            Ok(rustls::ServerCertVerified::assertion())
-        }
-    }
-}
-
-/// A Secure (https) grpc destination.
-struct Dst {
-    addr:        SocketAddr, 
-    host:        String,
-    no_cert:     bool,
-}
-
-impl tower_service::Service<()> for Dst {
-    type Response = TlsStream<TcpStream>;
-    type Error = ::std::io::Error;
-    type Future = Box<dyn Future<Item = TlsStream<TcpStream>, Error = ::std::io::Error> + Send>;
-
-    fn poll_ready(&mut self) -> futures::Poll<(), Self::Error> {
-        Ok(().into())
-    }
-
-    fn call(&mut self, _: ()) -> Self::Future {
         let mut config = ClientConfig::new();
 
-
         config.alpn_protocols.push(b"h2".to_vec());
         config.root_store.add_server_trust_anchors(&webpki_roots::TLS_SERVER_ROOTS);
         
-        if self.no_cert {
+        let tls = ClientTlsConfig::new()
-            config.dangerous()
+            .rustls_client_config(config)
-                .set_certificate_verifier(Arc::new(danger::NoCertificateVerification {}));
+            .domain_name(uri.host().unwrap());
-        }
         
-        let config = Arc::new(config);
+        Channel::builder(uri.clone())
-        let tls_connector = TlsConnector::from(config);
+            .tls_config(tls)
-
+            .connect()
-        let addr_string_local = self.host.clone();
+            .await?
-
-        let domain = match webpki::DNSNameRef::try_from_ascii_str(&addr_string_local) {
-            Ok(d)  => d,
-            Err(_) => webpki::DNSNameRef::try_from_ascii_str("localhost").unwrap()
     };
-        let domain_local = domain.to_owned();
 
-        let stream = TcpStream::connect(&self.addr).and_then(move |sock| {
+    Ok(CompactTxStreamerClient::new(channel))
-            sock.set_nodelay(true).unwrap();
-            tls_connector.connect(domain_local.as_ref(), sock)
-        })
-            .map(move |tcp| tcp);
-
-        Box::new(stream)
 }
-}
-
-// Same implementation but without TLS. Should make it straightforward to run without TLS
-// when testing on local machine
-//
-// impl tower_service::Service<()> for Dst {
-//     type Response = TcpStream;
-//     type Error = ::std::io::Error;
-//     type Future = Box<dyn Future<Item = TcpStream, Error = ::std::io::Error> + Send>;
-//
-//     fn poll_ready(&mut self) -> futures::Poll<(), Self::Error> {
-//         Ok(().into())
-//     }
-//
-//     fn call(&mut self, _: ()) -> Self::Future {
-//         let mut config = ClientConfig::new();
-//         config.alpn_protocols.push(b"h2".to_vec());
-//         config.root_store.add_server_trust_anchors(&webpki_roots::TLS_SERVER_ROOTS);
-//
-//         let stream = TcpStream::connect(&self.addr)
-//             .and_then(move |sock| {
-//                 sock.set_nodelay(true).unwrap();
-//                 Ok(sock)
-//             });
-//         Box::new(stream)
-//     }
-// }
-
-
-macro_rules! make_grpc_client {
-    ($protocol:expr, $host:expr, $port:expr, $nocert:expr) => {{
-        let uri: http::Uri = format!("{}://{}", $protocol, $host).parse().unwrap();
-
-        let addr = format!("{}:{}", $host, $port)
-            .to_socket_addrs()
-            .unwrap()
-            .next()
-            .unwrap();
-
-        let h2_settings = Default::default();
-        let mut make_client = tower_h2::client::Connect::new(Dst {addr, host: $host.to_string(), no_cert: $nocert}, h2_settings, DefaultExecutor::current());
-
-        make_client
-            .make_service(())
-            .map_err(|e| { format!("HTTP/2 connection failed; err={:?}.\nIf you're connecting to a local server, please pass --dangerous to trust the server without checking its TLS certificate", e) })
-            .and_then(move |conn| {
-                let conn = tower_request_modifier::Builder::new()
-                    .set_origin(uri)
-                    .build(conn)
-                    .unwrap();
-
-                CompactTxStreamer::new(conn)
-                    // Wait until the client is ready...
-                    .ready()
-                    .map_err(|e| { format!("client closed: {:?}", e) })
-            })
-    }};
-}
-
 
 // ==============
 // GRPC code
 // ==============
+async fn get_lightd_info(uri: &http::Uri) -> Result<LightdInfo, Box<dyn std::error::Error>> {
+    let mut client = get_client(uri).await?;
+
+    let request = Request::new(Empty {});
+
+    let response = client.get_lightd_info(request).await?;
 
-pub fn get_info(uri: http::Uri, no_cert: bool) -> Result<LightdInfo, String> {
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
-        .and_then(move |mut client| {
-            client.get_lightd_info(Request::new(Empty{}))
-                .map_err(|e| {
-                    format!("ERR = {:?}", e)
-                })
-                .and_then(move |response| {
     Ok(response.into_inner())
-                })
+}
-                .map_err(|e| {
-                    format!("ERR = {:?}", e)
-                })
-        });
 
-    tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner)
+pub fn get_info(uri: &http::Uri, no_cert: bool) -> Result<LightdInfo, String> {
+    let mut rt = tokio::runtime::Runtime::new().map_err(|e| e.to_string())?;
+
+    rt.block_on(get_lightd_info(uri)).map_err( |e| e.to_string())
 }
 
 
-pub fn fetch_blocks<F : 'static + std::marker::Send>(uri: &http::Uri, start_height: u64, end_height: u64, no_cert: bool, mut c: F)
+async fn get_block_range<F : 'static + std::marker::Send>(uri: &http::Uri, start_height: u64, end_height: u64, no_cert: bool, mut c: F) 
+    -> Result<(), Box<dyn std::error::Error>> 
 where F : FnMut(&[u8], u64) {
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
+    let mut client = get_client(uri).await?;
-        .and_then(move |mut client| {
+
     let bs = BlockId{ height: start_height, hash: vec!()};
     let be = BlockId{ height: end_height,   hash: vec!()};
 
-            let br = Request::new(BlockRange{ start: Some(bs), end: Some(be)});
+    let request = Request::new(BlockRange{ start: Some(bs), end: Some(be) });
-            client
+
-                .get_block_range(br)
+    let mut response = client.get_block_range(request).await?.into_inner();
-                .map_err(|e| {
+    println!("{:?}", response);
-                    format!("RouteChat request failed; err={:?}", e)
+    while let Some(block) = response.message().await? {
-                })
-                .and_then(move |response| {
-                    let inbound = response.into_inner();
-                    inbound.for_each(move |b| {
         use prost::Message;
         let mut encoded_buf = vec![];
 
-                        b.encode(&mut encoded_buf).unwrap();
+        block.encode(&mut encoded_buf).unwrap();
-                        c(&encoded_buf, b.height);
+        c(&encoded_buf, block.height);
+    }
 
     Ok(())
-                    })
+}
-                    .map_err(|e| format!("gRPC inbound stream error: {:?}", e))
-                })
-        });
 
-    match tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner) {
+pub fn fetch_blocks<F : 'static + std::marker::Send>(uri: &http::Uri, start_height: u64, end_height: u64, no_cert: bool, mut c: F)
-        Ok(_)  => {}, // The result is processed in callbacks, so nothing to do here
+    where F : FnMut(&[u8], u64) {
+    
+    let mut rt = match tokio::runtime::Runtime::new() {
+        Ok(r) => r,
         Err(e) => {
-            error!("Error while executing fetch_blocks: {}", e);
+            error!("Error fetching blocks {}", e.to_string());
             eprintln!("{}", e);
+            return;
         }
     };
+
+    rt.block_on(get_block_range(uri, start_height, end_height, no_cert, c)).unwrap();
 }
 
+
+// get_address_txids GRPC call
+async fn get_address_txids<F : 'static + std::marker::Send>(uri: &http::Uri, address: String, 
+        start_height: u64, end_height: u64, no_cert: bool, c: F) -> Result<(), Box<dyn std::error::Error>>
+    where F : Fn(&[u8], u64) {
+
+    let mut client = get_client(uri).await?;
+    let start = Some(BlockId{ height: start_height, hash: vec!()});
+    let end   = Some(BlockId{ height: end_height,   hash: vec!()});
+
+    let request = Request::new(TransparentAddressBlockFilter{ address, range: Some(BlockRange{start, end}) });
+
+    let maybe_response = client.get_address_txids(request).await?;
+    let mut response = maybe_response.into_inner();
+
+    while let Some(tx) = response.message().await? {
+        c(&tx.data, tx.height);
+    }
+
+    Ok(())
+}
+
+
 pub fn fetch_transparent_txids<F : 'static + std::marker::Send>(uri: &http::Uri, address: String, 
         start_height: u64, end_height: u64, no_cert: bool, c: F)
     where F : Fn(&[u8], u64) {
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
-        .and_then(move |mut client| {
-            let start = Some(BlockId{ height: start_height, hash: vec!()});
-            let end   = Some(BlockId{ height: end_height,   hash: vec!()});
     
-            let br = Request::new(TransparentAddressBlockFilter{ address, range: Some(BlockRange{start, end}) });
+    let mut rt = match tokio::runtime::Runtime::new() {
-
+        Ok(r) => r,
-            client
-                .get_address_txids(br)
-                .map_err(|e| {
-                    format!("RouteChat request failed; err={:?}", e)
-                })
-                .and_then(move |response| {
-                    let inbound = response.into_inner();
-                    inbound.for_each(move |tx| {
-                        //let tx = Transaction::read(&tx.into_inner().data[..]).unwrap();
-                        c(&tx.data, tx.height);
-
-                        Ok(())
-                    })
-                    .map_err(|e| format!("gRPC inbound stream error: {:?}", e))
-                })
-        });
-
-    match tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner) {
-        Ok(_)  => {}, // The result is processed in callbacks, so nothing to do here
         Err(e) => {
-            error!("Error while executing fetch_transparent_txids: {}", e);
+            error!("Error creating runtime {}", e.to_string());
             eprintln!("{}", e);
+            return;
         }
     };
+
+    rt.block_on(get_address_txids(uri, address, start_height, end_height, no_cert, c)).unwrap();
+}
+
+
+// get_transaction GRPC call
+async fn get_transaction(uri: &http::Uri, txid: TxId, no_cert: bool) 
+    -> Result<RawTransaction, Box<dyn std::error::Error>> {
+    let mut client = get_client(uri).await?;
+    let request = Request::new(TxFilter { block: None, index: 0, hash: txid.0.to_vec() });
+
+    let response = client.get_transaction(request).await?;
+
+    Ok(response.into_inner())
 }
 
 pub fn fetch_full_tx<F : 'static + std::marker::Send>(uri: &http::Uri, txid: TxId, no_cert: bool, c: F)
         where F : Fn(&[u8]) {
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
+    let mut rt = match tokio::runtime::Runtime::new() {
-        .and_then(move |mut client| {
+        Ok(r) => r,
-            let txfilter = TxFilter { block: None, index: 0, hash: txid.0.to_vec() };
-            client.get_transaction(Request::new(txfilter))
-                    .map_err(|e| {
-                    format!("RouteChat request failed; err={:?}", e)
-                })
-                .and_then(move |response| {
-                    c(&response.into_inner().data);
-
-                    Ok(())
-                })
-                .map_err(|e| { format!("ERR = {:?}", e) })
-        });
-
-    match tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner) {
-        Ok(_)  => {}, // The result is processed in callbacks, so nothing to do here
         Err(e) => {
-            error!("Error while executing fetch_full_tx: {}", e);
+            error!("Error creating runtime {}", e.to_string());
             eprintln!("{}", e);
+            return;
         }
     };
+
+    match rt.block_on(get_transaction(uri, txid, no_cert)) {
+        Ok(rawtx) => c(&rawtx.data),
+        Err(e) => {
+            error!("Error in get_transaction runtime {}", e.to_string());
+            eprintln!("{}", e);
+        }
     }
 
-pub fn broadcast_raw_tx(uri: &http::Uri, no_cert: bool, tx_bytes: Box<[u8]>) -> Result<String, String> {
+    
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
+}
-        .and_then(move |mut client| {
+
-            client.send_transaction(Request::new(RawTransaction {data: tx_bytes.to_vec(), height: 0}))
+// send_transaction GRPC call
-                .map_err(|e| {
+async fn send_transaction(uri: &http::Uri, no_cert: bool, tx_bytes: Box<[u8]>) -> Result<String, Box<dyn std::error::Error>> {
-                    format!("ERR = {:?}", e)
+    let mut client = get_client(uri).await?;
-                })
+
-                .and_then(move |response| {
+    let request = Request::new(RawTransaction {data: tx_bytes.to_vec(), height: 0});
+
+    let response = client.send_transaction(request).await?;
+
     let sendresponse = response.into_inner();
     if sendresponse.error_code == 0 {
         let mut txid = sendresponse.error_message;
@@ -286,32 +182,42 @@ pub fn broadcast_raw_tx(uri: &http::Uri, no_cert: bool, tx_bytes: Box<[u8]>) ->
 
         Ok(txid)
     } else {
-                        Err(format!("Error: {:?}", sendresponse))
+        Err(Box::from(format!("Error: {:?}", sendresponse)))
+    }
 }
-                })
-                .map_err(|e| { format!("ERR = {:?}", e) })
-        });
 
-    tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner)
+pub fn broadcast_raw_tx(uri: &http::Uri, no_cert: bool, tx_bytes: Box<[u8]>) -> Result<String, String> {
+    let mut rt = tokio::runtime::Runtime::new().map_err(|e| e.to_string())?;
+
+    rt.block_on(send_transaction(uri, no_cert, tx_bytes)).map_err( |e| e.to_string())
+}
+
+// get_latest_block GRPC call
+async fn get_latest_block(uri: &http::Uri) -> Result<BlockId, Box<dyn std::error::Error>> {
+    let mut client = get_client(uri).await?;
+
+    let request = Request::new(ChainSpec {});
+
+    let response = client.get_latest_block(request).await?;
+
+    Ok(response.into_inner())
 }
 
 pub fn fetch_latest_block<F : 'static + std::marker::Send>(uri: &http::Uri, no_cert: bool, mut c : F) 
     where F : FnMut(BlockId) {
-    let runner = make_grpc_client!(uri.scheme_str().unwrap(), uri.host().unwrap(), uri.port_part().unwrap(), no_cert)
+    let mut rt = match tokio::runtime::Runtime::new() {
-        .and_then(|mut client| {
+        Ok(r) => r,
-            client.get_latest_block(Request::new(ChainSpec {}))
-            .map_err(|e| { format!("ERR = {:?}", e) })
-            .and_then(move |response| {
-                c(response.into_inner());
-                Ok(())
-            })
-            .map_err(|e| { format!("ERR = {:?}", e) })
-        });
-
-    match tokio::runtime::current_thread::Runtime::new().unwrap().block_on(runner) {
-        Ok(_)  => {}, // The result is processed in callbacks, so nothing to do here
         Err(e) => {
-            error!("Error while executing fetch_latest_block: {}", e);
+            error!("Error creating runtime {}", e.to_string());
+            eprintln!("{}", e);
+            return;
+        }
+    };
+
+    match rt.block_on(get_latest_block(uri)) {
+        Ok(b) => c(b),
+        Err(e) => {
+            error!("Error getting latest block {}", e.to_string());
             eprintln!("{}", e);
         }
     };

lib/src/lib.rs

@@ -13,7 +13,6 @@ pub struct SaplingParams;
 
 pub const ANCHOR_OFFSET: u32 = 4;
 
-
 pub mod grpc_client {
-    include!(concat!(env!("OUT_DIR"), "/cash.z.wallet.sdk.rpc.rs"));
+    tonic::include_proto!("cash.z.wallet.sdk.rpc");
 }

lib/src/lightclient.rs

@@ -87,13 +87,13 @@ impl LightClientConfig {
     pub fn create(server: http::Uri, dangerous: bool) -> io::Result<(LightClientConfig, u64)> {
         use std::net::ToSocketAddrs;
         // Test for a connection first
-        format!("{}:{}", server.host().unwrap(), server.port_part().unwrap())
+        format!("{}:{}", server.host().unwrap(), server.port().unwrap())
             .to_socket_addrs()?
             .next()
             .ok_or(std::io::Error::new(ErrorKind::ConnectionRefused, "Couldn't resolve server!"))?;
 
         // Do a getinfo first, before opening the wallet
-        let info = grpcconnector::get_info(server.clone(), dangerous)
+        let info = grpcconnector::get_info(&server, dangerous)
             .map_err(|e| std::io::Error::new(ErrorKind::ConnectionRefused, e))?;
 
         // Create a Light Client Config
@@ -199,7 +199,7 @@ impl LightClientConfig {
             Some(s) => {
                 let mut s = if s.starts_with("http") {s} else { "http://".to_string() + &s};
                 let uri: http::Uri = s.parse().unwrap();
-                if uri.port_part().is_none() {
+                if uri.port().is_none() {
                     s = s + ":443";
                 }
                 s
@@ -583,7 +583,7 @@ impl LightClient {
     }
 
     pub fn do_info(&self) -> String {
-        match get_info(self.get_server_uri(), self.config.no_cert_verification) {
+        match get_info(&self.get_server_uri(), self.config.no_cert_verification) {
             Ok(i) => {
                 let o = object!{
                     "version" => i.version,

lib/src/lightwallet/extended_key.rs

@@ -1,6 +1,5 @@
 use ring::{
-    digest,
+    hmac::{self, Context, Key},
-    hmac::{SigningContext, SigningKey},
 };
 use lazy_static::lazy_static;
 use secp256k1::{PublicKey, Secp256k1, SecretKey, SignOnly, VerifyOnly, Error};
@@ -74,8 +73,8 @@ impl ExtendedPrivKey {
     /// Generate an ExtendedPrivKey from seed
     pub fn with_seed(seed: &[u8]) -> Result<ExtendedPrivKey, Error> {
         let signature = {
-            let signing_key = SigningKey::new(&digest::SHA512, b"Bitcoin seed");
+            let signing_key = Key::new(hmac::HMAC_SHA512, b"Bitcoin seed");
-            let mut h = SigningContext::with_key(&signing_key);
+            let mut h = Context::with_key(&signing_key);
             h.update(&seed);
             h.sign()
         };
@@ -88,18 +87,18 @@ impl ExtendedPrivKey {
         })
     }
 
-    fn sign_hardended_key(&self, index: u32) -> ring::hmac::Signature {
+    fn sign_hardended_key(&self, index: u32) -> ring::hmac::Tag {
-        let signing_key = SigningKey::new(&digest::SHA512, &self.chain_code);
+        let signing_key = Key::new(hmac::HMAC_SHA512, &self.chain_code);
-        let mut h = SigningContext::with_key(&signing_key);
+        let mut h = Context::with_key(&signing_key);
         h.update(&[0x00]);
         h.update(&self.private_key[..]);
         h.update(&index.to_be_bytes());
         h.sign()
     }
 
-    fn sign_normal_key(&self, index: u32) -> ring::hmac::Signature {
+    fn sign_normal_key(&self, index: u32) -> ring::hmac::Tag {
-        let signing_key = SigningKey::new(&digest::SHA512, &self.chain_code);
+        let signing_key = Key::new(hmac::HMAC_SHA512, &self.chain_code);
-        let mut h = SigningContext::with_key(&signing_key);
+        let mut h = Context::with_key(&signing_key);
         let public_key = PublicKey::from_secret_key(&SECP256K1_SIGN_ONLY, &self.private_key);
         h.update(&public_key.serialize());
         h.update(&index.to_be_bytes());