From 0e644da6acf8c417bd51afd8121707091047d11c Mon Sep 17 00:00:00 2001 From: askeluv Date: Thu, 14 Feb 2019 17:39:12 +0800 Subject: [PATCH] Fixed linting issues --- .../src/data_sources/ohlcv_external/crypto_compare.ts | 5 +++-- packages/pipeline/src/scripts/pull_slippage.ts | 4 +--- packages/pipeline/test/parsers/slippage/index_test.ts | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/pipeline/src/data_sources/ohlcv_external/crypto_compare.ts b/packages/pipeline/src/data_sources/ohlcv_external/crypto_compare.ts index 526fc5f6bb..961e6ff61a 100644 --- a/packages/pipeline/src/data_sources/ohlcv_external/crypto_compare.ts +++ b/packages/pipeline/src/data_sources/ohlcv_external/crypto_compare.ts @@ -49,6 +49,7 @@ export class CryptoCompareOHLCVSource { public readonly defaultExchange = 'CCCAGG'; public readonly interval = this.intervalBetweenRecords * MAX_PAGE_SIZE; // the hourly API returns data for one interval at a time private readonly _url: string = 'https://min-api.cryptocompare.com/data/histohour?'; + private readonly _priceUrl: string = 'https://min-api.cryptocompare.com/data/price?'; // rate-limit for all API calls through this class instance private readonly _limiter: Bottleneck; @@ -102,8 +103,8 @@ export class CryptoCompareOHLCVSource { } public async getUsdPriceAsync(symbol: string): Promise { - const priceUrl = `https://min-api.cryptocompare.com/data/price?tsyms=USD&fsym=${symbol}`; - const resp = await fetchAsync(priceUrl); + const usdUrl = `${this._priceUrl}tsyms=USD&fsym=${symbol}`; + const resp = await fetchAsync(usdUrl); const respJson: CryptoCompareUsdPrice = await resp.json(); return respJson.USD; } diff --git a/packages/pipeline/src/scripts/pull_slippage.ts b/packages/pipeline/src/scripts/pull_slippage.ts index d344bc7489..bfdd1f7b4f 100644 --- a/packages/pipeline/src/scripts/pull_slippage.ts +++ b/packages/pipeline/src/scripts/pull_slippage.ts @@ -1,10 +1,9 @@ -import * as R from 'ramda'; import { Connection, ConnectionOptions, createConnection } from 'typeorm'; import { logUtils } from '@0x/utils'; -import { CryptoCompareOHLCVSource } from '../data_sources/ohlcv_external/crypto_compare'; import { EdpsSource } from '../data_sources/dex_prices'; +import { CryptoCompareOHLCVSource } from '../data_sources/ohlcv_external/crypto_compare'; import { Slippage } from '../entities'; import * as ormConfig from '../ormconfig'; import { calculateSlippage } from '../parsers/slippage'; @@ -22,7 +21,6 @@ const USD_AMOUNTS = [10, 100, 1000, 10000]; // TODO: fetch from database const TOKENS = ['BAT', 'DAI', 'FUN', 'MANA', 'OMG', 'REP', 'TUSD', 'ZRX', 'MKR', 'BNB', 'USDC', 'LOOM', 'DNT', 'CVC']; -//const TOKENS = ['BAT', 'DNT', 'CVC', 'MANA']; let connection: Connection; diff --git a/packages/pipeline/test/parsers/slippage/index_test.ts b/packages/pipeline/test/parsers/slippage/index_test.ts index 892b136efd..7aeb45caa8 100644 --- a/packages/pipeline/test/parsers/slippage/index_test.ts +++ b/packages/pipeline/test/parsers/slippage/index_test.ts @@ -2,7 +2,7 @@ import { BigNumber } from '@0x/utils'; import * as chai from 'chai'; import 'mocha'; -import { EdpsExchange, EdpsWrapper } from '../../../src/data_sources/dex_prices'; +import { EdpsWrapper } from '../../../src/data_sources/dex_prices'; import { Slippage } from '../../../src/entities'; import { calculateSlippage } from '../../../src/parsers/slippage'; import { chaiSetup } from '../../utils/chai_setup';