Updated changelogs and documentation for erc1155 proxy

This commit is contained in:
Greg Hysen
2019-03-05 15:23:15 -08:00
parent ae51cfe8b9
commit 1e5648111e
8 changed files with 27 additions and 20 deletions

View File

@@ -1,4 +1,13 @@
[
{
"version": "2.1.0",
"changes": [
{
"note": "Add ERC1155Proxy",
"pr": 1661
}
]
},
{
"version": "2.0.0",
"changes": [

View File

@@ -1,15 +1,4 @@
[
{
"name": "ERC1155Proxy",
"version": "1.0.0",
"changes": [
{
"note": "Add ERC1155Proxy implementation",
"pr": 0,
"networks": {
}
}
]
{
"name": "MultiAssetProxy",
"version": "1.0.0",

View File

@@ -124,7 +124,7 @@ describe('ERC1155Proxy', () => {
});
it('should have an id of 0x9645780d', async () => {
const proxyId = await erc1155Proxy.getProxyId.callAsync();
// proxy computed using -- bytes4(keccak256("erc1155Contract(address,uint256[],uint256[],bytes)"));
// proxy computed using -- bytes4(keccak256("erc1155Token(address,uint256[],uint256[],bytes)"));
const expectedProxyId = '0x9645780d';
expect(proxyId).to.equal(expectedProxyId);
});
@@ -538,7 +538,7 @@ describe('ERC1155Proxy', () => {
receiverCallbackData,
authorized,
),
RevertReason.nftNotOwnedByFromAddress,
RevertReason.NFTNotOwnedByFromAddress,
);
});
it('should revert if tansferring 0 amount of any token', async () => {
@@ -571,7 +571,7 @@ describe('ERC1155Proxy', () => {
receiverCallbackData,
authorized,
),
RevertReason.transferGreaterThanZeroRequired,
RevertReason.TransferGreaterThanZeroRequired,
);
});
it('should revert if there is a multiplication overflow', async () => {
@@ -635,7 +635,7 @@ describe('ERC1155Proxy', () => {
receiverCallbackData,
authorized,
),
RevertReason.amountEqualToOneRequired,
RevertReason.AmountEqualToOneRequired,
);
});
it('should revert if transferring > 1 instances of a non-fungible token (`valuesToTransfer` field >1)', async () => {
@@ -664,7 +664,7 @@ describe('ERC1155Proxy', () => {
receiverCallbackData,
authorized,
),
RevertReason.amountEqualToOneRequired,
RevertReason.AmountEqualToOneRequired,
);
});
it('should revert if sender balance is insufficient', async () => {

View File

@@ -52,7 +52,7 @@ export class ERC1155ProxyWrapper {
*/
public async deployDummyContractsAsync(): Promise<Erc1155Wrapper[]> {
// tslint:disable-next-line:no-unused-variable
for (const i of _.times(constants.NUM_DUMMY_ERC1155_TO_DEPLOY)) {
for (const i of _.times(constants.NUM_DUMMY_ERC1155_CONTRACTS_TO_DEPLOY)) {
const erc1155Contract = await ERC1155MintableContract.deployFrom0xArtifactAsync(
artifacts.ERC1155Mintable,
this._provider,