crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify parallelization of orderbook & RFQT

Browse Source 
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r406955099
This commit is contained in:
F. Eugene Aumson
2020-04-11 01:03:26 -04:00
parent bb15f78af0
commit 27ca75d94f
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/asset-swapper/src/swap_quoter.ts
View File

@@ -528,10 +528,9 @@ export class SwapQuoter {
} else {
gasPrice = await this._protocolFeeUtils.getGasPriceEstimationOrThrowAsync();
}
// get the relevant orders for the makerAsset
const orderPromises: Array<Promise<SignedOrder[]>> = [
this._getSignedOrdersAsync(makerAssetData, takerAssetData),
];
// get batches of orders from different sources, awaiting sources in parallel
const orderBatchPromises: Array<Promise<SignedOrder[]>> = [];
orderBatchPromises.push(this._getSignedOrdersAsync(makerAssetData, takerAssetData)); // order book
if (
options.rfqt &&
options.rfqt.intentOnFilling &&
@@ -541,7 +540,7 @@ export class SwapQuoter {
if (!options.rfqt.takerAddress || options.rfqt.takerAddress === constants.NULL_ADDRESS) {
throw new Error('RFQ-T requests must specify a taker address');
}
orderPromises.push(
orderBatchPromises.push(
this._quoteRequestor.requestRfqtFirmQuotesAsync(
makerAssetData,
takerAssetData,
@@ -552,7 +551,8 @@ export class SwapQuoter {
),
);
}
const orders: SignedOrder[] = ([] as SignedOrder[]).concat(...(await Promise.all(orderPromises)));
const orderBatches: SignedOrder[][] = await Promise.all(orderBatchPromises);
const orders: SignedOrder[] = orderBatches.reduce((_orders, batch) => _orders.concat(...batch));
// if no native orders, pass in a dummy order for the sampler to have required metadata for sampling
if (orders.length === 0) {
orders.push(