Add noop conditionals for clarity

2018-06-20 13:55:45 +02:00
parent 0bbdbc9e63
commit 3fab40efe5
1 changed files with 10 additions and 0 deletions
--- a/packages/contracts/src/utils/asset_wrapper.ts
+++ b/packages/contracts/src/utils/asset_wrapper.ts
@@ -87,6 +87,11 @@ export class AssetWrapper {
                    // Burn token
                    await erc721Wrapper.burnAsync(assetProxyData.tokenAddress, assetProxyData.tokenId, userAddress);
                    return;
+                } else if (
+                    (userAddress !== tokenOwner && desiredBalance.eq(0)) ||
+                    (tokenOwner === userAddress && desiredBalance.eq(1))
+                ) {
+                    return; // noop
                }
                break;
            }
@@ -176,6 +181,11 @@ export class AssetWrapper {
                        assetProxyData.tokenAddress,
                        assetProxyData.tokenId,
                    );
+                } else if (
+                    (!isProxyApproved && desiredAllowance.eq(0)) ||
+                    (isProxyApproved && desiredAllowance.eq(1))
+                ) {
+                    return; // noop
                }

                break;