crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove cancelOrderNoThrow and batchCancelOrdersNoThrow

Browse Source
This commit is contained in:
Amir Bandeali
2019-08-05 10:11:41 -07:00
parent 6cb8c1df42
commit 467a11f4b4
1 changed files with 0 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
contracts/exchange/contracts/src/MixinWrapperFunctions.sol
View File

@@ -371,19 +371,6 @@ contract MixinWrapperFunctions is
return fillResults;
}
/// @dev After calling, the order can not be filled anymore.
// Returns false if the cancelOrder call would otherwise revert.
/// @param order Order to cancel. Order must be OrderStatus.FILLABLE.
/// @return True if the order was cancelled successfully.
function cancelOrderNoThrow(LibOrder.Order memory order)
public
returns (bool didCancel)
{
bytes memory cancelOrderCallData = abi.encodeWithSelector(CANCEL_ORDER_SELECTOR, order);
(didCancel,) = address(this).delegatecall(cancelOrderCallData);
return didCancel;
}
/// @dev Executes multiple calls of cancelOrder.
/// @param orders Array of order specifications.
function batchCancelOrders(LibOrder.Order[] memory orders)
@@ -396,21 +383,6 @@ contract MixinWrapperFunctions is
}
}
/// @dev Executes multiple calls of canccelOrderNoThrow.
/// @param orders Array of order specifications.
/// @return Bool array containing results of each individual cancellation.
function batchCancelOrdersNoThrow(LibOrder.Order[] memory orders)
public
returns (bool[] memory)
{
uint256 ordersLength = orders.length;
bool[] memory didCancel = new bool[](ordersLength);
for (uint256 i = 0; i != ordersLength; i++) {
didCancel[i] = cancelOrderNoThrow(orders[i]);
}
return didCancel;
}
/// @dev Fetches information for all passed in orders.
/// @param orders Array of order specifications.
/// @return Array of OrderInfo instances that correspond to each order.