crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Updated hashing comments as-per PR

Browse Source
This commit is contained in:
Greg Hysen
2018-06-28 15:41:06 -07:00
parent 94740155e5
commit 46d79e5115
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/contracts/src/contracts/current/protocol/Exchange/libs/LibOrder.sol
View File

@@ -99,11 +99,7 @@ contract LibOrder is
bytes32 makerAssetDataHash = keccak256(order.makerAssetData);
bytes32 takerAssetDataHash = keccak256(order.takerAssetData);
// Assembly for more efficiently computing:
// keccak256(abi.encodePacked(
// DOMAIN_SEPARATOR_SCHEMA_HASH,
// keccak256(abi.encodePacked(address(this))),
// ORDER_SCHEMA_HASH,
// keccak256(abi.encodePacked(
// keccak256(abi.encode(
// order.makerAddress,
// order.takerAddress,
// order.feeRecipientAddress,
@@ -114,10 +110,9 @@ contract LibOrder is
// order.takerFee,
// order.expirationTimeSeconds,
// order.salt,
// keccak256(abi.encodePacked(order.makerAssetData)),
// keccak256(abi.encodePacked(order.takerAssetData))
// ))
// ));
// keccak256(order.makerAssetData),
// keccak256(order.takerAssetData)
// ));
assembly {
// Backup
let temp1 := mload(sub(order, 32))