crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove hard coded gas limits in all tests

Browse Source
This commit is contained in:
Amir Bandeali
2019-08-25 19:00:50 -07:00
parent 1400ceb4e8
commit 71acf2bfa7
3 changed files with 1 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
contracts/extensions/test/balance_threshold_filter.ts
View File

@@ -427,10 +427,6 @@ describe(ContractName.BalanceThresholdFilter, () => {
validTakerAddress,
{
takerAssetFillAmounts,
// HACK(albrow): We need to hardcode the gas estimate here because
// the Geth gas estimator doesn't work with the way we use
// delegatecall and swallow errors.
gas: 600000,
},
);
// Assert validated addresses
@@ -699,10 +695,6 @@ describe(ContractName.BalanceThresholdFilter, () => {
validTakerAddress,
{
takerAssetFillAmount,
// HACK(albrow): We need to hardcode the gas estimate here because
// the Geth gas estimator doesn't work with the way we use
// delegatecall and swallow errors.
gas: 600000,
},
);
// Assert validated addresses
@@ -951,10 +943,6 @@ describe(ContractName.BalanceThresholdFilter, () => {
validTakerAddress,
{
takerAssetFillAmount: cumulativeTakerAssetFillAmount,
// HACK(albrow): We need to hardcode the gas estimate here because
// the Geth gas estimator doesn't work with the way we use
// delegatecall and swallow errors.
gas: 600000,
},
);
// Assert validated addresses