From 157b2efa1d387c53174564502beb56daba285033 Mon Sep 17 00:00:00 2001 From: David Sun Date: Fri, 12 Jul 2019 13:16:00 -0700 Subject: [PATCH 1/3] fix to not throw on new packages --- packages/monorepo-scripts/src/prepublish_checks.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/monorepo-scripts/src/prepublish_checks.ts b/packages/monorepo-scripts/src/prepublish_checks.ts index c41282453b..5ffe48525f 100644 --- a/packages/monorepo-scripts/src/prepublish_checks.ts +++ b/packages/monorepo-scripts/src/prepublish_checks.ts @@ -148,7 +148,14 @@ async function checkPublishRequiredSetupAsync(updatedPublicPackages: Package[]): const writePermissions = Object.keys(pkgPermissions).filter(pkgName => { return pkgPermissions[pkgName] === 'read-write'; }); - const unwriteablePkgs = updatedPublicPackages.filter(pkg => !writePermissions.includes(pkg.packageJson.name)); + const unwriteablePkgs = []; + for (const pkg of updatedPublicPackages) { + const isPackagePublished = (await npmUtils.getPackageRegistryJsonIfExistsAsync(pkg.packageJson.name)) !== undefined; + const isPackageWritePermissionsGranted = writePermissions.includes(pkg.packageJson.name); + if (!isPackageWritePermissionsGranted && isPackagePublished) { + unwriteablePkgs.push(pkg); + } + } if (unwriteablePkgs.length > 0) { utils.log(`Missing write permissions for the following packages:`); unwriteablePkgs.forEach(pkg => { From 38825865cc903740969e90c80aefd7b2d8e39c38 Mon Sep 17 00:00:00 2001 From: David Sun Date: Fri, 12 Jul 2019 13:32:27 -0700 Subject: [PATCH 2/3] prettier --- packages/monorepo-scripts/src/prepublish_checks.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/monorepo-scripts/src/prepublish_checks.ts b/packages/monorepo-scripts/src/prepublish_checks.ts index 5ffe48525f..f6a7d6c627 100644 --- a/packages/monorepo-scripts/src/prepublish_checks.ts +++ b/packages/monorepo-scripts/src/prepublish_checks.ts @@ -150,7 +150,8 @@ async function checkPublishRequiredSetupAsync(updatedPublicPackages: Package[]): }); const unwriteablePkgs = []; for (const pkg of updatedPublicPackages) { - const isPackagePublished = (await npmUtils.getPackageRegistryJsonIfExistsAsync(pkg.packageJson.name)) !== undefined; + const isPackagePublished = + (await npmUtils.getPackageRegistryJsonIfExistsAsync(pkg.packageJson.name)) !== undefined; const isPackageWritePermissionsGranted = writePermissions.includes(pkg.packageJson.name); if (!isPackageWritePermissionsGranted && isPackagePublished) { unwriteablePkgs.push(pkg); From ddc5aaacdb15bf7e486ba7775f84d48657d97f0c Mon Sep 17 00:00:00 2001 From: David Sun Date: Fri, 12 Jul 2019 13:39:41 -0700 Subject: [PATCH 3/3] Update condition for readability Co-Authored-By: Fabio B --- packages/monorepo-scripts/src/prepublish_checks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/monorepo-scripts/src/prepublish_checks.ts b/packages/monorepo-scripts/src/prepublish_checks.ts index f6a7d6c627..0c2b43a7d3 100644 --- a/packages/monorepo-scripts/src/prepublish_checks.ts +++ b/packages/monorepo-scripts/src/prepublish_checks.ts @@ -153,7 +153,7 @@ async function checkPublishRequiredSetupAsync(updatedPublicPackages: Package[]): const isPackagePublished = (await npmUtils.getPackageRegistryJsonIfExistsAsync(pkg.packageJson.name)) !== undefined; const isPackageWritePermissionsGranted = writePermissions.includes(pkg.packageJson.name); - if (!isPackageWritePermissionsGranted && isPackagePublished) { + if (isPackagePublished && !isPackageWritePermissionsGranted) { unwriteablePkgs.push(pkg); } }