diff --git a/contracts/exchange-forwarder/test/forwarder.ts b/contracts/exchange-forwarder/test/forwarder.ts index 400f944e98..fcc8a05ab1 100644 --- a/contracts/exchange-forwarder/test/forwarder.ts +++ b/contracts/exchange-forwarder/test/forwarder.ts @@ -445,7 +445,7 @@ describe(ContractName.Forwarder, () => { takerAssetAmount: Web3Wrapper.toBaseUnitAmount(17, DECIMALS_DEFAULT), }); await forwarderTestFactory.marketBuyTestAsync([order], 0.57, erc20Token, { - ethValueAdjustment: new BigNumber(2), + ethValueAdjustment: 2, }); }); it('should buy the exact amount of makerAsset from a single order with a WETH fee', async () => { @@ -474,7 +474,7 @@ describe(ContractName.Forwarder, () => { ); await forwarderTestFactory.marketBuyTestAsync([order], 0.5, erc20Token, { - ethValueAdjustment: new BigNumber(-2), + ethValueAdjustment: -2, revertError, }); }); @@ -725,7 +725,7 @@ describe(ContractName.Forwarder, () => { // -2 to compensate for the extra 1 wei added in ForwarderTestFactory to account for rounding await forwarderTestFactory.marketBuyTestAsync([order], 0.5, erc20Token, { - ethValueAdjustment: new BigNumber(-2), + ethValueAdjustment: -2, forwarderFeePercentage, revertError, }); diff --git a/contracts/exchange-forwarder/test/utils/forwarder_test_factory.ts b/contracts/exchange-forwarder/test/utils/forwarder_test_factory.ts index 429a6b0b3d..2ea4c0ea79 100644 --- a/contracts/exchange-forwarder/test/utils/forwarder_test_factory.ts +++ b/contracts/exchange-forwarder/test/utils/forwarder_test_factory.ts @@ -149,13 +149,13 @@ export class ForwarderTestFactory { fractionalNumberOfOrdersToFill: number, makerAssetContract: DummyERC20TokenContract | DummyERC721TokenContract, options: { - ethValueAdjustment?: BigNumber; // Used to provided insufficient/excess ETH + ethValueAdjustment?: number; // Used to provided insufficient/excess ETH forwarderFeePercentage?: BigNumber; makerAssetId?: BigNumber; revertError?: RevertError; } = {}, ): Promise { - const ethValueAdjustment = options.ethValueAdjustment || constants.ZERO_AMOUNT; + const ethValueAdjustment = options.ethValueAdjustment || 0; const forwarderFeePercentage = options.forwarderFeePercentage || constants.ZERO_AMOUNT; const erc20Balances = await this._erc20Wrapper.getBalancesAsync();