crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-asset-proxy: Always set allowance.

Browse Source
This commit is contained in:
Lawrence Forman
2019-10-01 18:32:41 -07:00
parent 2593f1ff30
commit 95e461072f
2 changed files with 39 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
contracts/asset-proxy/contracts/src/bridges/UniswapBridge.sol
View File

@@ -52,9 +52,6 @@ contract UniswapBridge is
payable
{}
/// @dev Whether we've granted an allowance to the exchange for a token.
mapping (address => bool) private _hasAllowance;
/// @dev Callback for `IERC20Bridge`. Tries to buy `amount` of
/// `toTokenAddress` tokens by selling the entirety of the `fromTokenAddress`
/// token encoded in the bridge data.
@@ -184,16 +181,13 @@ contract UniswapBridge is
}
/// @dev Grants an unlimited allowance to the exchange for its token
/// on behalf of this contract, if we haven't already done so.
/// on behalf of this contract.
/// @param exchange The Uniswap token exchange.
function _grantExchangeAllowance(IUniswapExchange exchange)
private
{
address tokenAddress = exchange.toTokenAddress();
if (!_hasAllowance[tokenAddress]) {
IERC20Token(tokenAddress).approve(address(exchange), uint256(-1));
_hasAllowance[tokenAddress] = true;
}
IERC20Token(tokenAddress).approve(address(exchange), uint256(-1));
}
/// @dev Retrieves the uniswap exchange contract for a given token pair.