Update exchange and coordinator contracts to incorporate chainID in their domain separators.

2019-03-21 11:11:54 -04:00
parent 5b1cbbf157
commit 964d8171dd
7 changed files with 53 additions and 23 deletions
--- a/contracts/coordinator/test/utils/hash_utils.ts
+++ b/contracts/coordinator/test/utils/hash_utils.ts
@@ -6,6 +6,7 @@ import * as _ from 'lodash';
 export const hashUtils = {
    getApprovalHashBuffer(
        transaction: SignedZeroExTransaction,
+        chainId: BigNumber,
        verifyingContractAddress: string,
        txOrigin: string,
        approvalExpirationTimeSeconds: BigNumber,
@@ -21,12 +22,18 @@ export const hashUtils = {
    },
    getApprovalHashHex(
        transaction: SignedZeroExTransaction,
+        chainId: BigNumber,
        verifyingContractAddress: string,
        txOrigin: string,
        approvalExpirationTimeSeconds: BigNumber,
    ): string {
        const hashHex = `0x${hashUtils
-            .getApprovalHashBuffer(transaction, verifyingContractAddress, txOrigin, approvalExpirationTimeSeconds)
+            .getApprovalHashBuffer(
+                transaction,
+                chainId,
+                verifyingContractAddress,
+                txOrigin,
+                approvalExpirationTimeSeconds)
            .toString('hex')}`;
        return hashHex;
    },