From 98fc780ade384f732bb71c0e62f77d5bec769fb9 Mon Sep 17 00:00:00 2001
From: "F. Eugene Aumson" <feuGeneA@users.noreply.github.com>
Date: Wed, 8 Apr 2020 23:14:06 -0400
Subject: [PATCH] Use map idiom instead of for loop

Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2541#discussion_r405904035
---
 .../asset-swapper/src/utils/quote_requestor.ts     | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/packages/asset-swapper/src/utils/quote_requestor.ts b/packages/asset-swapper/src/utils/quote_requestor.ts
index ec3acbb1d4..e453ef1844 100644
--- a/packages/asset-swapper/src/utils/quote_requestor.ts
+++ b/packages/asset-swapper/src/utils/quote_requestor.ts
@@ -50,10 +50,9 @@ export class QuoteRequestor {
         // create an array of promises for quote responses, using "undefined"
         // as a placeholder for failed requests.
 
-        const responsePromises: Array<Promise<AxiosResponse<SignedOrder> | undefined>> = [];
-        for (const rfqtMakerEndpoint of this._rfqtMakerEndpoints) {
-            responsePromises.push(
-                Axios.get(`${rfqtMakerEndpoint}/quote`, {
+        const responsesIfDefined: Array<void | AxiosResponse<SignedOrder>> = await Promise.all(
+            this._rfqtMakerEndpoints.map(async rfqtMakerEndpoint =>
+                Axios.get<SignedOrder>(`${rfqtMakerEndpoint}/quote`, {
                     headers: { '0x-api-key': takerApiKey },
                     params: {
                         sellToken,
@@ -69,12 +68,9 @@ export class QuoteRequestor {
                             err,
                         )}`,
                     );
-                    return undefined;
                 }),
-            );
-        }
-
-        const responsesIfDefined: Array<AxiosResponse<SignedOrder> | undefined> = await Promise.all(responsePromises);
+            ),
+        );
 
         const responses: Array<AxiosResponse<SignedOrder>> = responsesIfDefined.filter(
             (respIfDefd): respIfDefd is AxiosResponse<SignedOrder> => respIfDefd !== undefined,