From a340c817c93b9341867aa8dd05d1c784498140d4 Mon Sep 17 00:00:00 2001 From: Amir Bandeali Date: Thu, 19 Sep 2019 21:07:43 -0700 Subject: [PATCH] Guarantee that makers can't be added to pools when max amount decreases --- .../contracts/src/staking_pools/MixinStakingPoolMakers.sol | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contracts/staking/contracts/src/staking_pools/MixinStakingPoolMakers.sol b/contracts/staking/contracts/src/staking_pools/MixinStakingPoolMakers.sol index bf16479d21..c09991e537 100644 --- a/contracts/staking/contracts/src/staking_pools/MixinStakingPoolMakers.sol +++ b/contracts/staking/contracts/src/staking_pools/MixinStakingPoolMakers.sol @@ -177,7 +177,9 @@ contract MixinStakingPoolMakers is } // Is the pool already full? - if (pool.numberOfMakers == maximumMakersInPool) { + // NOTE: If maximumMakersInPool is decreased below the number of makers currently in a pool, + // the pool will no longer be able to add more makers. + if (pool.numberOfMakers >= maximumMakersInPool) { LibRichErrors.rrevert(LibStakingRichErrors.MakerPoolAssignmentError( LibStakingRichErrors.MakerPoolAssignmentErrorCodes.PoolIsFull, makerAddress,