From ab62f50f5ce85e97e826f42624efc2fb5fac929e Mon Sep 17 00:00:00 2001 From: Fred Carlsen Date: Tue, 19 Feb 2019 15:53:07 +0100 Subject: [PATCH] Hide ledger sign note on error --- .../website/ts/pages/governance/vote_form.tsx | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/packages/website/ts/pages/governance/vote_form.tsx b/packages/website/ts/pages/governance/vote_form.tsx index fc5686f0a4..bafd5572e0 100644 --- a/packages/website/ts/pages/governance/vote_form.tsx +++ b/packages/website/ts/pages/governance/vote_form.tsx @@ -256,29 +256,27 @@ export class VoteForm extends React.Component { } else { const responseBody = await response.json(); const errorMessage = !_.isUndefined(responseBody.reason) ? responseBody.reason : 'Unknown Error'; - this.props.onError - ? this.props.onError(errorMessage) - : this.setState({ - errors: { - signError: errorMessage, - }, - isSuccessful: false, - isAwaitingLedgerSignature: false, - }); + this._handleError(errorMessage); } } catch (err) { - const errorMessage = err.message; - this.props.onError - ? this.props.onError(errorMessage) - : this.setState({ - errors: { - signError: errorMessage, - }, - isSuccessful: false, - isAwaitingLedgerSignature: false, - }); + this._handleError(err.message); } }; + private _handleError(errorMessage: string): void { + const { onError } = this.props; + onError + ? onError(errorMessage) + : this.setState({ + errors: { + signError: errorMessage, + }, + isSuccessful: false, + isAwaitingLedgerSignature: false, + }); + this.setState({ + isAwaitingLedgerSignature: false, + }); + } private async _signVoteAsync(signerAddress: string, typedData: any): Promise { const { provider: providerEngine } = this.props; let signatureHex;