crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asset-s: clean up order faking for indicative RFQT

Browse Source 
Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2555#discussion_r411545804
This commit is contained in:
F. Eugene Aumson
2020-04-20 22:13:19 -04:00
parent 5effc6ec90
commit ad7868ebe1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/asset-swapper/src/utils/market_operation_utils/orders.ts
View File

@@ -375,16 +375,16 @@ export function createSignedOrdersFromRfqtIndicativeQuotes(
makerAddress: NULL_ADDRESS,
senderAddress: NULL_ADDRESS,
feeRecipientAddress: NULL_ADDRESS,
salt: ZERO_AMOUNT, // generatePseudoRandomSalt(),
expirationTimeSeconds: new BigNumber(Math.floor(Date.now() / ONE_SECOND_MS) + ONE_HOUR_IN_SECONDS),
salt: ZERO_AMOUNT,
expirationTimeSeconds: ZERO_AMOUNT,
makerFeeAssetData: NULL_BYTES,
takerFeeAssetData: NULL_BYTES,
makerFee: ZERO_AMOUNT,
takerFee: ZERO_AMOUNT,
fillableTakerFeeAmount: ZERO_AMOUNT,
signature: WALLET_SIGNATURE,
chainId: 0, // HACK !!!!!!!!! how can we get at this from this context?
exchangeAddress: NULL_ADDRESS, // HACK !!!!!!!!! how can we get at this from this context?
chainId: 0,
exchangeAddress: NULL_ADDRESS,
};
});
}