From ad7868ebe10b902c04f34cd2cfdac64b72dfb8bc Mon Sep 17 00:00:00 2001 From: "F. Eugene Aumson" Date: Mon, 20 Apr 2020 22:13:19 -0400 Subject: [PATCH] asset-s: clean up order faking for indicative RFQT Addresses review comment https://github.com/0xProject/0x-monorepo/pull/2555#discussion_r411545804 --- .../src/utils/market_operation_utils/orders.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/asset-swapper/src/utils/market_operation_utils/orders.ts b/packages/asset-swapper/src/utils/market_operation_utils/orders.ts index 854f3f9642..320bee4fb2 100644 --- a/packages/asset-swapper/src/utils/market_operation_utils/orders.ts +++ b/packages/asset-swapper/src/utils/market_operation_utils/orders.ts @@ -375,16 +375,16 @@ export function createSignedOrdersFromRfqtIndicativeQuotes( makerAddress: NULL_ADDRESS, senderAddress: NULL_ADDRESS, feeRecipientAddress: NULL_ADDRESS, - salt: ZERO_AMOUNT, // generatePseudoRandomSalt(), - expirationTimeSeconds: new BigNumber(Math.floor(Date.now() / ONE_SECOND_MS) + ONE_HOUR_IN_SECONDS), + salt: ZERO_AMOUNT, + expirationTimeSeconds: ZERO_AMOUNT, makerFeeAssetData: NULL_BYTES, takerFeeAssetData: NULL_BYTES, makerFee: ZERO_AMOUNT, takerFee: ZERO_AMOUNT, fillableTakerFeeAmount: ZERO_AMOUNT, signature: WALLET_SIGNATURE, - chainId: 0, // HACK !!!!!!!!! how can we get at this from this context? - exchangeAddress: NULL_ADDRESS, // HACK !!!!!!!!! how can we get at this from this context? + chainId: 0, + exchangeAddress: NULL_ADDRESS, }; }); }