crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1514 from 0xProject/bug/exchange-wrapper-matchOrders

Browse Source 
Remove optimization from matchOrdersAsync in Exchange wrapper
This commit is contained in:
Jacob Evans
2019-01-15 13:23:45 +11:00
committed by GitHub
parent c859788fde 007a2d7deb
commit b4621f6a69
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/contract-wrappers/CHANGELOG.json
View File

@@ -5,6 +5,10 @@
{
"note": "Renamed OrderStatus enum members to PascalCase to conform with tslint enum-naming rule",
"pr": 1474
},
{
"note": "Remove Exchange `matchOrdersAsync` optimization",
"pr": 1514
}
]
},

4
packages/contract-wrappers/src/contract_wrappers/exchange_wrapper.ts
View File

@@ -743,10 +743,6 @@ export class ExchangeWrapper extends ContractWrapper {
rightSignedOrder.takerAssetData !== leftSignedOrder.makerAssetData
) {
throw new Error(ExchangeWrapperError.AssetDataMismatch);
} else {
// Smart contracts assigns the asset data from the left order to the right one so we can save gas on reducing the size of call data
rightSignedOrder.makerAssetData = '0x';
rightSignedOrder.takerAssetData = '0x';
}
const exchangeInstance = await this._getExchangeContractAsync();
if (orderTransactionOpts.shouldValidate) {