crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-exchange: Add comments about preserving signatures in MixinSignatureValidator.sol

Browse Source
This commit is contained in:
Lawrence Forman
2019-06-25 15:21:12 -04:00
committed by Amir Bandeali
parent 0eb5c825a5
commit c23bb5e589
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
contracts/exchange/contracts/src/MixinSignatureValidator.sol
View File

@@ -320,7 +320,9 @@ contract MixinSignatureValidator is
returns (bool isValid)
{
uint256 signatureLength = signature.length;
// Shave the signature type off the signature.
// HACK(dorothy-zbornak): Temporarily shave the signature type
// from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 1))
}
@@ -365,7 +367,9 @@ contract MixinSignatureValidator is
returns (bool isValid)
{
uint256 signatureLength = signature.length;
// Shave the signature type off the signature.
// HACK(dorothy-zbornak): Temporarily shave the signature type
// from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 1))
}
@@ -428,7 +432,9 @@ contract MixinSignatureValidator is
validatorAddress
));
}
// Shave the validator address and signature type from the signature.
// HACK(dorothy-zbornak): Temporarily shave the validator address
// and signature type from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 21))
}
@@ -477,7 +483,9 @@ contract MixinSignatureValidator is
returns (bool isValid)
{
uint256 signatureLength = signature.length;
// Shave the signature type off the signature.
// HACK(dorothy-zbornak): Temporarily shave the signature type
// from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 1))
}
@@ -525,7 +533,9 @@ contract MixinSignatureValidator is
returns (bool isValid)
{
uint256 signatureLength = signature.length;
// Shave the signature type off the signature.
// HACK(dorothy-zbornak): Temporarily shave the signature type
// from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 1))
}
@@ -588,7 +598,9 @@ contract MixinSignatureValidator is
validatorAddress
));
}
// Shave the validator address and signature type from the signature.
// HACK(dorothy-zbornak): Temporarily shave the validator address
// and signature type from the signature for the encode call then restore
// it immediately after because we want to keep signatures intact.
assembly {
mstore(signature, sub(signatureLength, 21))
}