includeEmpty -> shouldIncludeEmpty

This commit is contained in:
Steve Klebanoff
2018-12-18 14:11:29 -08:00
parent 441b5ac6f1
commit e10b30886f
2 changed files with 5 additions and 5 deletions

View File

@@ -65,7 +65,7 @@ export class ConfigGenerator extends React.Component<ConfigGeneratorProps, Confi
<Container minWidth="350px">
<ConfigGeneratorSection title="Liquidity Source">
<Select
includeEmpty={false}
shouldIncludeEmpty={false}
id=""
value={value.orderSource}
items={this._generateItems()}

View File

@@ -13,21 +13,21 @@ interface SelectProps {
items: SelectItemConfig[];
emptyText?: string;
onChange?: (ev: React.ChangeEvent<HTMLSelectElement>) => void;
includeEmpty: boolean;
shouldIncludeEmpty: boolean;
}
export const Select: React.FunctionComponent<SelectProps> = ({
value,
id,
items,
includeEmpty,
shouldIncludeEmpty,
emptyText,
onChange,
}) => {
return (
<Container>
<StyledSelect id={id} onChange={onChange}>
{includeEmpty && <option value="">{emptyText}</option>}
{shouldIncludeEmpty && <option value="">{emptyText}</option>}
{items.map((item, index) => (
<option
key={`${id}-item-${index}`}
@@ -48,7 +48,7 @@ export const Select: React.FunctionComponent<SelectProps> = ({
Select.defaultProps = {
emptyText: 'Select...',
includeEmpty: true,
shouldIncludeEmpty: true,
};
const Container = styled.div`