diff --git a/contracts/coordinator/test/libs.ts b/contracts/coordinator/test/libs.ts index 1ef208b637..baa97b597e 100644 --- a/contracts/coordinator/test/libs.ts +++ b/contracts/coordinator/test/libs.ts @@ -74,7 +74,6 @@ describe('Libs tests', () => { const expectedApprovalHash = hashUtils.getApprovalHashHex( signedTx, coordinatorContract.address, - chainId, txOrigin, approvalExpirationTimeSeconds, ); diff --git a/contracts/coordinator/test/utils/approval_factory.ts b/contracts/coordinator/test/utils/approval_factory.ts index 36c90cd356..cb4bfd6b4e 100644 --- a/contracts/coordinator/test/utils/approval_factory.ts +++ b/contracts/coordinator/test/utils/approval_factory.ts @@ -8,12 +8,10 @@ import { hashUtils, SignedCoordinatorApproval } from './index'; export class ApprovalFactory { private readonly _privateKey: Buffer; private readonly _verifyingContractAddress: string; - private readonly _chainId: number; constructor(privateKey: Buffer, verifyingContractAddress: string, chainId: number) { this._privateKey = privateKey; this._verifyingContractAddress = verifyingContractAddress; - this._chainId = chainId; } public newSignedApproval( @@ -25,7 +23,6 @@ export class ApprovalFactory { const approvalHashBuff = hashUtils.getApprovalHashBuffer( transaction, this._verifyingContractAddress, - this._chainId, txOrigin, approvalExpirationTimeSeconds, ); diff --git a/packages/order-utils/src/eip712_utils.ts b/packages/order-utils/src/eip712_utils.ts index 17f95ce52c..aefba4d31c 100644 --- a/packages/order-utils/src/eip712_utils.ts +++ b/packages/order-utils/src/eip712_utils.ts @@ -113,6 +113,7 @@ export const eip712Utils = { name: constants.COORDINATOR_DOMAIN_NAME, version: constants.COORDINATOR_DOMAIN_VERSION, verifyingContractAddress, + chainId: transaction.chainId, }; const transactionHash = transactionHashUtils.getTransactionHashHex(transaction); const approval = {