crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

@0x/contracts-zero-ex: Address review feedback.

Browse Source
This commit is contained in:
Lawrence Forman
2020-07-06 12:29:23 -04:00
parent bdc1dbf08a
commit e8106f04b5
14 changed files with 135 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
contracts/zero-ex/test/full_migration_test.ts
View File

@@ -44,7 +44,9 @@ blockchainTests.resets('Full migration', env => {
await migrator.getBootstrapper().callAsync(),
);
features = await deployFullFeaturesAsync(env.provider, env.txDefaults, zeroEx.address);
await migrator.deploy(owner, zeroEx.address, features, { transformerDeployer }).awaitTransactionSuccessAsync();
await migrator
.initializeZeroEx(owner, zeroEx.address, features, { transformerDeployer })
.awaitTransactionSuccessAsync();
});
it('ZeroEx has the correct owner', async () => {
@@ -58,10 +60,10 @@ blockchainTests.resets('Full migration', env => {
expect(dieRecipient).to.eq(owner);
});
it('Non-deployer cannot call deploy()', async () => {
it('Non-deployer cannot call initializeZeroEx()', async () => {
const notDeployer = randomAddress();
const tx = migrator
.deploy(owner, zeroEx.address, features, { transformerDeployer })
.initializeZeroEx(owner, zeroEx.address, features, { transformerDeployer })
.callAsync({ from: notDeployer });
return expect(tx).to.revertWith('FullMigration/INVALID_SENDER');
});
@@ -89,7 +91,7 @@ blockchainTests.resets('Full migration', env => {
contractType: IMetaTransactionsContract,
fns: [
'executeMetaTransaction',
'executeMetaTransactions',
'batchExecuteMetaTransactions',
'_executeMetaTransaction',
'getMetaTransactionExecutedBlock',
'getMetaTransactionHashExecutedBlock',