@0x/order-utils refactors for v3: orderParsingUtils, signatureUtils, orderHashUtils, RevertErrors, transactionHashUtils (#2321)

* move orderParsingUtils from order-utils to connect * Remove many functions from signatureUtils Removed from the exported object, that is. All of them are used in other existing code, so they were all moved to be as local to their usage as possible. * remove orderHashUtils.isValidOrderHash() * Move all *RevertErrors from order-utils... ...into their respective @0x/contracts- packages. * Refactor @0x/order-utils' orderHashUtils away - Move existing routines into @0x/contracts-test-utils - Migrate non-contract-test callers to a newly-exposed getOrderHash() method in DevUtils. * Move all *RevertErrors from @0x/utils... ...into their respective @0x/contracts- packages. * rm transactionHashUtils.isValidTransactionHash() * DevUtils.sol: Fail yarn test if too big to deploy * Refactor @0x/order-utils transactionHashUtils away - Move existing routines into @0x/contracts-test-utils - Migrate non-contract-test callers to a newly-exposed getTransactionHash() method in DevUtils. * Consolidate `Removed export...` CHANGELOG entries * Rm EthBalanceChecker from devutils wrapper exports * Stop importing from '.' or '.../src' * fix builds * fix prettier; dangling promise * increase max bundle size
2019-11-14 17:14:24 -05:00
parent f0d7d10fe7
commit f11d8a5bd8
132 changed files with 584 additions and 653 deletions
--- a/contracts/test-utils/test/transaction_hash.ts
+++ b/contracts/test-utils/test/transaction_hash.ts
@@ -0,0 +1,48 @@
+import { chaiSetup } from '@0x/dev-utils';
+import { ZeroExTransaction } from '@0x/types';
+import { BigNumber } from '@0x/utils';
+import * as chai from 'chai';
+import 'mocha';
+
+import { transactionHashUtils } from '../src';
+
+import { constants } from '../src/constants';
+
+chaiSetup.configure();
+const expect = chai.expect;
+
+describe('0x transaction hashing', () => {
+    describe('#getTransactionHashHex', () => {
+        const expectedTransactionHash = '0x7845d260300acfbebaff52f0462f984016473290b9eb865fb6ffac0503cab364';
+        const fakeVerifyingContractAddress = '0x5e72914535f202659083db3a02c984188fa26e9f';
+        const fakeChainId = 1337;
+        const transaction: ZeroExTransaction = {
+            signerAddress: constants.NULL_ADDRESS,
+            salt: new BigNumber(0),
+            expirationTimeSeconds: new BigNumber(0),
+            gasPrice: new BigNumber(0),
+            data: constants.NULL_BYTES,
+            domain: {
+                verifyingContract: fakeVerifyingContractAddress,
+                chainId: fakeChainId,
+            },
+        };
+        it('calculates the transaction hash', async () => {
+            const transactionHash = transactionHashUtils.getTransactionHashHex(transaction);
+            expect(transactionHash).to.be.equal(expectedTransactionHash);
+        });
+        it('calculates the transaction hash if amounts are strings', async () => {
+            // It's common for developers using javascript to provide the amounts
+            // as strings. Since we eventually toString() the BigNumber
+            // before encoding we should result in the same orderHash in this scenario
+            // tslint:disable-next-line:no-unnecessary-type-assertion
+            const transactionHash = transactionHashUtils.getTransactionHashHex({
+                ...transaction,
+                salt: '0',
+                expirationTimeSeconds: '0',
+                gasPrice: '0',
+            } as any);
+            expect(transactionHash).to.be.equal(expectedTransactionHash);
+        });
+    });
+});