Fabio Berger
252fdd03d7
Fix comment
2017-11-11 10:21:40 -05:00
Fabio Berger
0fe5c5dac3
Remove keys from dependentOrderHashes if empty
2017-11-11 10:13:42 -05:00
Fabio Berger
037e992de4
establish convention of initializing empty instances in instance declaration
2017-11-11 09:57:45 -05:00
Fabio Berger
12023073f4
Use enum instead of boolean to avoid potential bugs from isRemoved incorrectly being set to true
2017-11-11 09:54:27 -05:00
Fabio Berger
0db0694aad
rename _orders to _orderByOrderhash for clarity
2017-11-11 09:47:32 -05:00
Fabio Berger
d4f763aa68
Add comment above orderStateWatcher class
2017-11-11 09:45:50 -05:00
Fabio Berger
4e708c81ca
Fix expected balance
2017-11-11 09:19:51 -05:00
Fabio Berger
041d00301c
Fix type declaration in test
2017-11-11 08:58:01 -05:00
Fabio Berger
0ec51b124b
Feather the callback down to _emitDifferencesAsync and don't store it as a class instance. This will make supporting multiple subscriptions easier later on and reduces the amount of unsubscription cleanup
2017-11-11 08:57:49 -05:00
Fabio Berger
6012926e82
Throw if trying to subscribe multiple times
2017-11-10 18:07:11 -05:00
Fabio Berger
ca9c1bca4a
Fix alignment
2017-11-10 18:06:57 -05:00
Fabio Berger
0d957ea71d
Add comment above the eventWatcher class
2017-11-10 17:47:41 -05:00
Fabio Berger
697926641f
Rename method since it's not more then just mempool
2017-11-10 17:47:30 -05:00
Fabio Berger
9b9ab983d6
Fix test description
2017-11-10 09:04:25 -05:00
Fabio Berger
d5746652a2
Fix test description
2017-11-09 23:37:01 -05:00
Fabio Berger
47f9e171fc
Move numConfirmations to constructor call
2017-11-09 23:32:22 -05:00
Fabio Berger
a1bc18e5cf
Improve comment
2017-11-09 23:32:04 -05:00
Fabio Berger
0cd5bf7967
Make sure to set the defaultBlock to the blockNumber rather then the number of confirmations
2017-11-09 23:24:46 -05:00
Fabio Berger
0205f9ede3
Simplify to/from block code
2017-11-09 23:16:26 -05:00
Fabio Berger
960c83315b
Add assertion
2017-11-09 23:05:46 -05:00
Fabio Berger
f9c84fb6f4
Merge branch 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Add forgotten file
2017-11-09 22:58:10 -05:00
Fabio Berger
1b14561748
remove no longer needed arg
2017-11-09 22:58:06 -05:00
Fabio Berger
27519e1dfa
rename intervalId to intervalIdIfExists
2017-11-09 22:57:38 -05:00
Leonid Logvinov
46e2da24a4
Add forgotten file
2017-11-09 22:12:29 -05:00
Fabio Berger
dbbcbed344
Merge branch 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Add order state watcher tests for LogCancel
# Conflicts:
# test/order_state_watcher_test.ts
2017-11-09 18:30:20 -05:00
Fabio Berger
c0db88168b
Fix bug where we hard-coded using pendingBlock for fetching the orderState. Moved numConfirmations to become a global orderStateWatcher config
2017-11-09 18:29:13 -05:00
Leonid Logvinov
d98435b4dc
Add order state watcher tests for LogCancel
2017-11-09 18:28:33 -05:00
Fabio Berger
595dc6de03
Fix comments
2017-11-09 18:04:24 -05:00
Fabio Berger
322e054f1a
comment improvements
2017-11-09 17:57:41 -05:00
Fabio Berger
7f606e1e64
Closing paren on same level as open
2017-11-09 17:50:48 -05:00
Fabio Berger
b0491b0ee2
Rename _callbackAsync to _callbackIfExistsAsync for clarity
2017-11-09 17:48:05 -05:00
Fabio Berger
0e69356ca9
Merge branches 'orderWatcher' and 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Fix getting events from non-mempool
* 'orderWatcher' of github.com:0xProject/0x.js:
Fix getting events from non-mempool
2017-11-09 17:45:37 -05:00
Fabio Berger
90348e08c1
use explicit import
2017-11-09 17:45:30 -05:00
Leonid Logvinov
c60d7e2db8
Fix getting events from non-mempool
2017-11-09 17:44:45 -05:00
Fabio Berger
50d3a14825
Remove finished TODOs
2017-11-09 17:39:03 -05:00
Fabio Berger
0ff3ba5250
Merge branch 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Revert test amount changes
2017-11-09 17:20:49 -05:00
Fabio Berger
02cc3f9116
Create assert.isValidSignature method and use it in addOrder
2017-11-09 17:18:30 -05:00
Fabio Berger
62861d1e13
Move isValidSignature implementation into signatureUtils
2017-11-09 17:18:03 -05:00
Leonid Logvinov
cd3c7f1b97
Revert test amount changes
2017-11-09 17:14:10 -05:00
Fabio Berger
0c8886ad0c
Fix comment
2017-11-09 17:03:54 -05:00
Fabio Berger
9d24325207
Merge branch 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Revert "Use _.get for optional configs"
# Conflicts:
# src/0x.ts
2017-11-09 17:01:30 -05:00
Fabio Berger
126a165f55
Add nested config for orderWatcher
2017-11-09 16:59:41 -05:00
Leonid Logvinov
1c6e6842c6
Revert "Use _.get for optional configs"
...
This reverts commit ecc54b07c7 .
2017-11-09 16:48:45 -05:00
Fabio Berger
6f5a55b5fe
Rename MempoolEventCallback to EventWatcherCallback
2017-11-09 16:43:19 -05:00
Fabio Berger
530f5a700e
Merge branch 'orderWatcher' of github.com:0xProject/0x.js into orderWatcher
...
* 'orderWatcher' of github.com:0xProject/0x.js:
Fix namings
2017-11-09 16:42:06 -05:00
Fabio Berger
441c1f9ab7
rename folder to order_watcher
2017-11-09 16:41:57 -05:00
Leonid Logvinov
d98d885924
Fix namings
2017-11-09 16:37:00 -05:00
Leonid Logvinov
6aa91d89e0
Remove redundant assertions
2017-11-09 16:30:40 -05:00
Fabio Berger
ecc54b07c7
Use _.get for optional configs
2017-11-09 16:30:14 -05:00
Fabio Berger
ce11a38d70
Improve comment
2017-11-09 16:23:39 -05:00