Lawrence Forman
2f464ee8f0
@0x/contracts-exchange: Fix critical error in fillOrder() and matchOrders() redundant transfer optimization code.
...
`@0x/contracts-exchange`: Rearrange `Fill` event params to make regular `emit` code work without breaking the stack.
`@0x/contracts-exchange`: Add edge case tests for redundant transfer optimizations.
2019-07-23 15:46:15 -07:00
Lawrence Forman
8fe9883b62
Update contracts/exchange/contracts/src/MixinMatchOrders.sol
...
`@0x/contracts-exchange`: Minor code change to save an mload.
2019-07-23 15:46:15 -07:00
Lawrence Forman
de896f9159
@0x/contracts-exchange: Remove TODO comment in fill_order_combinatorial_utils.ts.
2019-07-23 15:46:15 -07:00
Lawrence Forman
a2468e8129
@0x/contracts-exchange: Update changelog.
2019-07-23 15:46:15 -07:00
Lawrence Forman
ee89f74afd
@0x/contracts-exchange: Avoid redundant transfer in matchOrders() when maker/feeRecipient and takerAssetData/makerFeeAssetData are the same.
...
`@0x/conracts-exchange`: Disable combinatorial tests by default. Can be run by setting env var `TEST_ALL=1`.
2019-07-23 15:46:15 -07:00
Lawrence Forman
cd08c3e8fa
@0x/contracts-exchange: Avoid redundant trasfer in fillOrder() when maker/taker is the same as feeRecipient and the assets match.
...
`@0x/contracts-exchange`: Swap fill order in `fillOrder()` from maker -> taker to taker -> maker first
2019-07-23 15:46:15 -07:00
Lawrence Forman
9cc8933eec
@0x/contracs-test-utils: Increase number of deployed ERC721 and ERC1155 tokens to 2 to fix broken asset-proxy tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
91c27ff972
@0x/contracts-exchange: Fix build error.
2019-07-23 15:46:15 -07:00
Lawrence Forman
07e3ba014c
@0x/contracts-exchange: Fully incorporate ERC1155 and MultiAsset tests into the fillOrder and matchOrders test suites.
2019-07-23 15:46:15 -07:00
Lawrence Forman
57ac0ca6e8
@0x/contracts-test-utils: Reduce number of test token deployments to speed up tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
816368b1fe
@0x/contracts-exchange: Re-eanble all exchange tests.
...
`@0x/contracts-echange`: Set up 1155 and MAP proxies for `matchOrders()` tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
85ea291745
@0x/contracts-exchange: Add MultiAssetProxy, ERC1155Fungible, and ERC1155NonFungible combinatorial tests.
2019-07-23 15:46:15 -07:00
Lawrence Forman
741fdfa52e
@0x/contracts-erc1155: Add mintKnownFungibleTokensAsync(), isNonFungibleItemAsync(), isFungibleItemAsync(), getOwnerOfAsync(), getBalanceAsync() to Erc1155Wrapper.
2019-07-23 15:46:15 -07:00
Lawrence Forman
348ec5bc3c
@0x/contracts-asset-proxy: Add setProxyAllowanceForAllAsync() to ERC1155ProxyWrapper.
2019-07-23 15:45:39 -07:00
Lawrence Forman
df9698ab1f
@0x/order-utils: Add ERC1155 to ExchangeTransferSimulator and fix MultiAssetProxy transfer accounting.
2019-07-23 15:45:39 -07:00
Lawrence Forman
c1aead970a
Disable staking package from CI.
2019-07-23 15:45:39 -07:00
Lawrence Forman
518f351235
@0x/contracts-exchange: Correct coding convention in match_orders.ts
2019-07-23 15:44:58 -07:00
Lawrence Forman
d79a07e2c4
@0x/contracts-exchange: Fix indentation in matchOrders().
2019-07-23 15:44:58 -07:00
Lawrence Forman
b636057251
@0x/contracts-exchange-libs: Make EIP712_ORDER_SCHEMA_HASH public.
2019-07-23 15:44:58 -07:00
Lawrence Forman
c692c8f055
@0x/contracts-exchange-libs: Regenerate LibExchangeSelectors.sol
2019-07-23 15:44:58 -07:00
Lawrence Forman
930736060c
@0x/abi-gen-templates: Automatically catch and decode ganache revert Errors in transaction methods.
2019-07-23 15:44:58 -07:00
Lawrence Forman
1c8468d248
@0x/contracts-exchange: Use function/event selectors from LibExchangeSelectors.
...
`@0x/contracts-exchange`: Add memory map comments to `Fill` emit code.
2019-07-23 15:43:23 -07:00
Lawrence Forman
575842eab4
@0x/contracts-exchange-libs: Convert generate-exchange-selectors script to typescript.
2019-07-23 15:43:23 -07:00
Lawrence Forman
f7f55cad43
@0x/contracts-exchange: Removed dependency on OrderValidationUtils. The tests using it didn't really warrant the full validation suite.
...
`@0x/contracts-test-utils`: Move all the `OrderScenario` related types into the `contracts-exchange` package because no one else is using them.
2019-07-23 15:43:23 -07:00
Lawrence Forman
acd857a8c0
@0x/contracts-asset-proxy: Fix broken proxies test.
2019-07-23 15:43:23 -07:00
Lawrence Forman
53ff248176
@0x/contracts-exchange: Revert internal tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
3de13967bc
@0x/base-contract: Re-wrap StringRevertErrors as plain Errors for backwards compatibility
2019-07-23 15:43:23 -07:00
Lawrence Forman
aebb923c2d
@0x/contracts-exchange: Major rework of fill_order_combinatorial_utils.
...
`@0x/contracts-exchange`: Add more arbitrary fee token tests.
`@0x/contracts-exchange`: Fix broken tests.
2019-07-23 15:43:23 -07:00
Lawrence Forman
76d577a08d
@0x/contracts-test-utils: Add more OrderScenario related types.
2019-07-23 15:43:23 -07:00
Lawrence Forman
3fb34a2a83
@0x/contracts-asset-proxy: Make setProxyAllowanceForAll() just accept a ownerAddress and give the proxy full control.
2019-07-23 15:43:23 -07:00
Lawrence Forman
cdb938ea28
@0x/base-contract: Add a method for converting Error types to RevertErrors.
...
`@0x/abi-gen-templates`: Automatically try to convert `Error`s thrown in `callAsync()` to `RevertError`s.
`@0x/abi-gen-wrappers`: Update generated wrappers.
2019-07-23 15:43:23 -07:00
Lawrence Forman
882dd4597e
@0x/dev-utils: Move Error -> RevertError coercion logic to @0x/utils.
2019-07-23 15:27:39 -07:00
Lawrence Forman
409efb8c67
@0x/order-utils: Update RevertError types for new RevertError constructor.
2019-07-23 15:27:39 -07:00
Lawrence Forman
eaa4373a18
@0x/utils: Tweak RevertError to produce a meaningful Error message/stack trace.
...
`@0x/utils`: Add more `RevertError` decoding/transforming functions (such as `decodeThrownErrorAsRevertError()`)
2019-07-23 15:27:39 -07:00
Lawrence Forman
d480f8d82a
@0x/web3-wrapper: Let toBaseUnitAmount() accept a number as well as a BigNumber
2019-07-23 15:27:39 -07:00
Lawrence Forman
339fc9ff14
@0x/assert: Add isNumberLike assertion
2019-07-23 15:27:00 -07:00
Lawrence Forman
14167412e0
@0x/contracts-exchange-libs: Make generate-exchange-selectors terminate file with a newline.
2019-07-23 15:26:59 -07:00
Lawrence Forman
7c0f075d1f
Update changelogs with PR #s
2019-07-23 15:26:59 -07:00
Lawrence Forman
f4aea76c6e
Ran prettier
2019-07-23 15:26:59 -07:00
Lawrence Forman
d263382365
@0x/contracts-coordinator: Fix broken coordinator tests.
2019-07-23 15:26:59 -07:00
Lawrence Forman
2109ed8464
@0x/contracts-exchange-libs: Add generate-exchange-selectors package script to regenerate LibExchangeSelectors from Exchange artifacts.
2019-07-23 15:26:59 -07:00
Lawrence Forman
d11444b983
@0x/contracts-exchange: Fix Exchange Wrappers tests.
2019-07-23 15:26:59 -07:00
Lawrence Forman
0508a45681
@0x/contracts-echange: Fix transactions test bug with ExchangeWrapper example due to deduping.
2019-07-23 15:26:59 -07:00
Lawrence Forman
a5c0b95f8b
Update changelogs
2019-07-23 15:26:59 -07:00
Lawrence Forman
f1af12b3b9
Update CI config to blacklist contracts-extensions and contracts-exchange-forwarder.
2019-07-23 15:26:59 -07:00
Lawrence Forman
9d257497bd
Ran prettier and fixed linter errors
2019-07-23 15:23:40 -07:00
Lawrence Forman
79f40b4ce0
@0x/contracts-exchange: Enable all exchange tests.
2019-07-23 15:23:40 -07:00
Lawrence Forman
1ab62b7a80
@0x/contracts-exchange: Fix broken match orders tests
2019-07-23 15:23:40 -07:00
Lawrence Forman
d2f10d5834
@0x/contracts-exchange: Allow custom ExchangeWrapper.matchOrders() call in MatchOrdersTester.
2019-07-23 15:23:40 -07:00
Lawrence Forman
c326ec9d1e
@0x/contracts-exchange: Rewrote MatchOrderTester class to be simpler and more flexible.
2019-07-23 15:23:40 -07:00