From 359a35931e7e3089c815b8f7edf3f42fd88f15ed Mon Sep 17 00:00:00 2001
From: catbref <misc-github@talk2dom.com>
Date: Thu, 7 May 2020 12:15:09 +0100
Subject: [PATCH] Fix broken Transaction.getUnconfirmedTransactions() and
 getInvalidTransactions()

---
 src/main/java/org/qortal/transaction/Transaction.java | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/main/java/org/qortal/transaction/Transaction.java b/src/main/java/org/qortal/transaction/Transaction.java
index 715efa48..2cbfd2d4 100644
--- a/src/main/java/org/qortal/transaction/Transaction.java
+++ b/src/main/java/org/qortal/transaction/Transaction.java
@@ -610,9 +610,7 @@ public abstract class Transaction {
 			Transaction transaction = Transaction.fromData(repository, transactionData);
 
 			if (transaction.isStillValidUnconfirmed(latestBlockData.getTimestamp()) != ValidationResult.OK)
-				continue;
-
-			unconfirmedTransactionsIterator.remove();
+				unconfirmedTransactionsIterator.remove();
 		}
 
 		return unconfirmedTransactions;
@@ -638,10 +636,7 @@ public abstract class Transaction {
 			Transaction transaction = Transaction.fromData(repository, transactionData);
 
 			if (transaction.isStillValidUnconfirmed(latestBlockData.getTimestamp()) != ValidationResult.OK)
-				continue;
-
-			invalidTransactions.add(transactionData);
-			unconfirmedTransactionsIterator.remove();
+				invalidTransactions.add(transactionData);
 		}
 
 		return invalidTransactions;