From 3706cd5ff7256d5d378b21c3e1be40fc4ee60fc8 Mon Sep 17 00:00:00 2001
From: catbref <misc-github@talk2dom.com>
Date: Fri, 11 Dec 2020 17:29:00 +0000
Subject: [PATCH] Return list, not set, of wallet transactions via API and
 provide better (usable) examples

---
 .../qortal/api/resource/CrossChainBitcoinResource.java    | 8 ++++----
 .../qortal/api/resource/CrossChainLitecoinResource.java   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/qortal/api/resource/CrossChainBitcoinResource.java b/src/main/java/org/qortal/api/resource/CrossChainBitcoinResource.java
index ef25892d..445d853e 100644
--- a/src/main/java/org/qortal/api/resource/CrossChainBitcoinResource.java
+++ b/src/main/java/org/qortal/api/resource/CrossChainBitcoinResource.java
@@ -8,7 +8,7 @@ import io.swagger.v3.oas.annotations.parameters.RequestBody;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
 
-import java.util.Set;
+import java.util.List;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.ws.rs.POST;
@@ -45,7 +45,7 @@ public class CrossChainBitcoinResource {
 				schema = @Schema(
 					type = "string",
 					description = "BIP32 'm' private/public key in base58",
-					example = "tpub___________________________________________________________________________________________________________"
+					example = "tpubD6NzVbkrYhZ4XTPc4btCZ6SMgn8CxmWkj6VBVZ1tfcJfMq4UwAjZbG8U74gGSypL9XBYk2R2BLbDBe8pcEyBKM1edsGQEPKXNbEskZozeZc"
 				)
 			)
 		),
@@ -83,7 +83,7 @@ public class CrossChainBitcoinResource {
 				schema = @Schema(
 					type = "string",
 					description = "BIP32 'm' private/public key in base58",
-					example = "tpub___________________________________________________________________________________________________________"
+					example = "tpubD6NzVbkrYhZ4XTPc4btCZ6SMgn8CxmWkj6VBVZ1tfcJfMq4UwAjZbG8U74gGSypL9XBYk2R2BLbDBe8pcEyBKM1edsGQEPKXNbEskZozeZc"
 				)
 			)
 		),
@@ -94,7 +94,7 @@ public class CrossChainBitcoinResource {
 		}
 	)
 	@ApiErrors({ApiError.INVALID_PRIVATE_KEY, ApiError.FOREIGN_BLOCKCHAIN_NETWORK_ISSUE})
-	public Set<BitcoinyTransaction> getBitcoinWalletTransactions(String key58) {
+	public List<BitcoinyTransaction> getBitcoinWalletTransactions(String key58) {
 		Security.checkApiCallAllowed(request);
 
 		Bitcoin bitcoin = Bitcoin.getInstance();
diff --git a/src/main/java/org/qortal/api/resource/CrossChainLitecoinResource.java b/src/main/java/org/qortal/api/resource/CrossChainLitecoinResource.java
index ea7a860f..9c841045 100644
--- a/src/main/java/org/qortal/api/resource/CrossChainLitecoinResource.java
+++ b/src/main/java/org/qortal/api/resource/CrossChainLitecoinResource.java
@@ -8,7 +8,7 @@ import io.swagger.v3.oas.annotations.parameters.RequestBody;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
 
-import java.util.Set;
+import java.util.List;
 
 import javax.servlet.http.HttpServletRequest;
 import javax.ws.rs.POST;
@@ -45,7 +45,7 @@ public class CrossChainLitecoinResource {
 				schema = @Schema(
 					type = "string",
 					description = "BIP32 'm' private/public key in base58",
-					example = "tpub___________________________________________________________________________________________________________"
+					example = "tpubD6NzVbkrYhZ4XTPc4btCZ6SMgn8CxmWkj6VBVZ1tfcJfMq4UwAjZbG8U74gGSypL9XBYk2R2BLbDBe8pcEyBKM1edsGQEPKXNbEskZozeZc"
 				)
 			)
 		),
@@ -83,7 +83,7 @@ public class CrossChainLitecoinResource {
 				schema = @Schema(
 					type = "string",
 					description = "BIP32 'm' private/public key in base58",
-					example = "tpub___________________________________________________________________________________________________________"
+					example = "tpubD6NzVbkrYhZ4XTPc4btCZ6SMgn8CxmWkj6VBVZ1tfcJfMq4UwAjZbG8U74gGSypL9XBYk2R2BLbDBe8pcEyBKM1edsGQEPKXNbEskZozeZc"
 				)
 			)
 		),
@@ -94,7 +94,7 @@ public class CrossChainLitecoinResource {
 		}
 	)
 	@ApiErrors({ApiError.INVALID_PRIVATE_KEY, ApiError.FOREIGN_BLOCKCHAIN_NETWORK_ISSUE})
-	public Set<BitcoinyTransaction> getLitecoinWalletTransactions(String key58) {
+	public List<BitcoinyTransaction> getLitecoinWalletTransactions(String key58) {
 		Security.checkApiCallAllowed(request);
 
 		Litecoin litecoin = Litecoin.getInstance();