Qortal/qortal
1
0
Fork 1
mirror of https://github.com/Qortal/qortal.git synced 2025-07-23 04:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Changed error response from RewardShareTransaction.isValid() for existing self-shares.

Browse Source 
Before:
0-fee self-share REWARD_SHARE when there is an existing self-share would result in
INSUFFICIENT_FEE from isFeeValid()

After:
isFeeValid() returns OK for above, but isValid() returns SELF_SHARE_EXISTS.

In addition, a transaction that tries to modify existing self-share, even with fee,
also returns SELF_SHARE_EXISTS.

Improved tests to double check.
This commit is contained in:
catbref
2020-02-18 13:23:42 +00:00
parent a4e127c84a
commit 282f6e6e2a
3 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/java/org/qortal/test/minting/RewardShareTests.java
View File

@@ -168,9 +168,14 @@ public class RewardShareTests extends Common {
newTransactionData = AccountUtils.createRewardShare(repository, testAccountName, testAccountName, CANCEL_SHARE_PERCENT);
newTransaction = Transaction.fromData(repository, newTransactionData);
// Confirm terminating reward-share is valid
// Confirm terminating reward-share with fee is valid
validationResult = newTransaction.isValidUnconfirmed();
assertEquals("Subsequent zero-fee self-share should be invalid", ValidationResult.OK, validationResult);
assertEquals("Subsequent self-share cancel should be valid", ValidationResult.OK, validationResult);
// Confirm terminating reward-share with zero fee is invalid
newTransactionData.setFee(BigDecimal.ZERO);
validationResult = newTransaction.isValidUnconfirmed();
assertNotSame("Subsequent zero-fee self-share cancel should be invalid", ValidationResult.OK, validationResult);
}
}