Finally syncs with qora1 chain!

ATData no longer needs deploySignature as a link back to DeployATTransaction,
but does need creator and creation [timestamp].
"creation" is critical for ordering ATs when creating/validating blocks.

Similar changes to ATStateData, adding creation, stateHash (for quicker
comparison with blocks received over the network), and fees incurred
by running AT on that block.
Also added more explicit constructors for different scenarios.

BlockData upgraded from simplistic "atBytes" to use ATStateData (above)
which has details on ATs run for that block, fees incurred, and a hash
of the AT's state. atCount added to keep track of how many ATs ran.

ATTransactions essentially reuse the GenesisAccount's publickey as
creator/sender as they're brought into existence by the Qora code
rather than an end user. ATTransactionData updated to reflect this
and the AT's address used as a "sender" field.

Account tidied up with respect to CIYAM ATs and setConfirmedBalance
ensures there is a corresponding record in Accounts (DB table).

Account, and subclasses, don't need "throws DataException" on
constructor any more.

Fixed bug in Asset Order matching where the matching engine
would give up after first potential match instead of trying others.

Lots more work on CIYAM AT, albeit mainly blind importing of old
v1 ATs from static JSON file as they're all dead and new
v2 implementation is not backwards compatible.

More work on Blocks, mostly AT stuff, but also fork-based corruption
prevention using fix from Qora v1.

Payment-related transactions (multipayment, etc.) always expect/use
non-null (albeit maybe empty) list of PaymentData when validating,
processing or orphaning.
Mainly a change in HSQLDBTransactionRepository.getPayments()

Payment.isValid(byte[], PaymentData, BigDecimal, boolean isZeroAmountValid)
didn't pass on isZeroAmountValid to called method - whoops!

Lots of work on ATTransactions themselves.

MessageTransactions incorrectly assumed the optional payment was always
in Qora. Now fixed to use the transaction's provided assetId.

Mass of fixes/additions to HSQLDBATRepository, especially fixing
incorrect reference to Assets DB table!

In HSQLDBDatabaseUpdates, bump QoraAmount type from DECIMAL(19,8)
to DECIMAL(27,8) to allow for huge asset quantities.
You WILL have to rebuild your database!

src/test/ATTests.java

@@ -9,6 +9,7 @@ import org.junit.Test;
 
 import com.google.common.hash.HashCode;
 
+import data.at.ATStateData;
 import data.block.BlockData;
 import data.block.BlockTransactionData;
 import data.transaction.DeployATTransactionData;
@@ -70,13 +71,22 @@ public class ATTests extends Common {
 					long blockTimestamp = 1439997158336L;
 					BigDecimal generatingBalance = BigDecimal.valueOf(1440368826L).setScale(8);
 					byte[] generatorPublicKey = Base58.decode("X4s833bbtghh7gejmaBMbWqD44HrUobw93ANUuaNhFc");
-					byte[] atBytes = HashCode.fromString("17950a6c62d17ff0caa545651c054a105f1c464daca443df846cc6a3d58f764b78c09cff50f0fd9ec2").asBytes();
+					int atCount = 1;
 					BigDecimal atFees = BigDecimal.valueOf(50.0).setScale(8);
 
 					BlockData blockData = new BlockData(version, blockReference, transactionCount, totalFees, transactionsSignature, height, blockTimestamp,
-							generatingBalance, generatorPublicKey, generatorSignature, atBytes, atFees);
+							generatingBalance, generatorPublicKey, generatorSignature, atCount, atFees);
 
 					repository.getBlockRepository().save(blockData);
+
+					byte[] atBytes = HashCode.fromString("17950a6c62d17ff0caa545651c054a105f1c464daca443df846cc6a3d58f764b78c09cff50f0fd9ec2").asBytes();
+
+					String atAddress = Base58.encode(Arrays.copyOfRange(atBytes, 0, 25));
+					byte[] stateHash = Arrays.copyOfRange(atBytes, 25, atBytes.length);
+
+					ATStateData atStateData = new ATStateData(atAddress, height, timestamp, new byte[0], stateHash, atFees);
+
+					repository.getATRepository().save(atStateData);
 				}
 
 				int sequence = 0;

src/test/NavigationTests.java

@@ -37,7 +37,7 @@ public class NavigationTests extends Common {
 
 			System.out.println("Block " + blockData.getHeight() + ", signature: " + Base58.encode(blockData.getSignature()));
 
-			assertEquals(49778, blockData.getHeight());
+			assertEquals((Integer) 49778, blockData.getHeight());
 		}
 	}
 

src/test/SignatureTests.java

@@ -48,11 +48,7 @@ public class SignatureTests extends Common {
 			PrivateKeyAccount generator = new PrivateKeyAccount(repository,
 					new byte[] { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31 });
 
-			byte[] atBytes = null;
-
-			BigDecimal atFees = null;
-
-			Block block = new Block(repository, version, reference, timestamp, generatingBalance, generator, atBytes, atFees);
+			Block block = new Block(repository, version, reference, timestamp, generatingBalance, generator);
 			block.sign();
 
 			assertTrue(block.isSignatureValid());

src/test/TransactionTests.java

@@ -172,7 +172,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, paymentTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(paymentTransactionData);
 		block.sign();
 
@@ -233,7 +233,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, registerNameTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(registerNameTransactionData);
 		block.sign();
 
@@ -289,7 +289,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, updateNameTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(updateNameTransactionData);
 		block.sign();
 
@@ -334,7 +334,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, sellNameTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(sellNameTransactionData);
 		block.sign();
 
@@ -385,7 +385,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, cancelSellNameTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(cancelSellNameTransactionData);
 		block.sign();
 
@@ -432,7 +432,7 @@ public class TransactionTests {
 		byte[] buyersReference = somePaymentTransaction.getTransactionData().getSignature();
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(somePaymentTransaction.getTransactionData());
 		block.sign();
 
@@ -451,7 +451,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, buyNameTransaction.isValid());
 
 		// Forge new block with transaction
-		block = new Block(repository, parentBlockData, generator, null, null);
+		block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(buyNameTransactionData);
 		block.sign();
 
@@ -504,7 +504,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, createPollTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(createPollTransactionData);
 		block.sign();
 
@@ -563,7 +563,7 @@ public class TransactionTests {
 			assertEquals(ValidationResult.OK, voteOnPollTransaction.isValid());
 
 			// Forge new block with transaction
-			Block block = new Block(repository, parentBlockData, generator, null, null);
+			Block block = new Block(repository, parentBlockData, generator);
 			block.addTransaction(voteOnPollTransactionData);
 			block.sign();
 
@@ -630,7 +630,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, issueAssetTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(issueAssetTransactionData);
 		block.sign();
 
@@ -720,7 +720,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, transferAssetTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(transferAssetTransactionData);
 		block.sign();
 
@@ -800,7 +800,7 @@ public class TransactionTests {
 		byte[] buyersReference = somePaymentTransaction.getTransactionData().getSignature();
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(somePaymentTransaction.getTransactionData());
 		block.sign();
 
@@ -824,7 +824,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, createOrderTransaction.isValid());
 
 		// Forge new block with transaction
-		block = new Block(repository, parentBlockData, generator, null, null);
+		block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(createOrderTransactionData);
 		block.sign();
 
@@ -905,7 +905,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, cancelOrderTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(cancelOrderTransactionData);
 		block.sign();
 
@@ -980,7 +980,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, createOrderTransaction.isValid());
 
 		// Forge new block with transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(createOrderTransactionData);
 		block.sign();
 
@@ -1089,7 +1089,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, multiPaymentTransaction.isValid());
 
 		// Forge new block with payment transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(multiPaymentTransactionData);
 		block.sign();
 
@@ -1159,7 +1159,7 @@ public class TransactionTests {
 		assertEquals(ValidationResult.OK, messageTransaction.isValid());
 
 		// Forge new block with message transaction
-		Block block = new Block(repository, parentBlockData, generator, null, null);
+		Block block = new Block(repository, parentBlockData, generator);
 		block.addTransaction(messageTransactionData);
 		block.sign();