crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get orders async tests passing

Browse Source
This commit is contained in:
fragosti
2018-08-15 17:31:39 -07:00
parent c325d638c9
commit 1c87e5f698
3 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/connect/src/utils/relayer_response_json_parsers.ts
View File

@@ -26,7 +26,7 @@ export const relayerResponseJsonParsers = {
}, },
parseAPIOrderJson(json: any): APIOrder { parseAPIOrderJson(json: any): APIOrder {
assert.doesConformToSchema('relayerApiOrder', json, schemas.relayerApiOrderSchema); assert.doesConformToSchema('relayerApiOrder', json, schemas.relayerApiOrderSchema);
return typeConverters.convertOrderStringFieldsToBigNumber(json); return typeConverters.convertAPIOrderStringFieldsToBigNumber(json);
}, },
parseOrderbookResponseJson(json: any): OrderbookResponse { parseOrderbookResponseJson(json: any): OrderbookResponse {
assert.doesConformToSchema('orderBookResponse', json, schemas.relayerApiOrderbookResponseSchema); assert.doesConformToSchema('orderBookResponse', json, schemas.relayerApiOrderbookResponseSchema);

7
packages/connect/src/utils/type_converters.ts
View File

@@ -36,7 +36,12 @@ export const typeConverters = {
convertStringsFieldsToBigNumbers(obj: any, fields: string[]): any { convertStringsFieldsToBigNumbers(obj: any, fields: string[]): any {
const result = _.assign({}, obj); const result = _.assign({}, obj);
_.each(fields, field => { _.each(fields, field => {
_.update(result, field, (value: string) => new BigNumber(value)); _.update(result, field, (value: string) => {
if (_.isUndefined(value)) {
throw new Error(`Could not find field '${field}' while converting string fields to BigNumber.`);
}
return new BigNumber(value);
});
}); });
return result; return result;
}, },

2
packages/connect/test/http_client_test.ts
View File

@@ -78,7 +78,7 @@ describe('HttpClient', () => {
page: 3, page: 3,
perPage: 50, perPage: 50,
}; };
const urlWithQuery = `${url}?page=3&perPage=50&assetDataAddress=${assetDataAddress}`; const urlWithQuery = `${url}?assetDataAddress=${assetDataAddress}&page=3&perPage=50`;
fetchMock.get(urlWithQuery, ordersResponseJSON); fetchMock.get(urlWithQuery, ordersResponseJSON);
const orders = await relayerClient.getOrdersAsync(ordersRequest); const orders = await relayerClient.getOrdersAsync(ordersRequest);
expect(orders).to.be.deep.equal(ordersResponse); expect(orders).to.be.deep.equal(ordersResponse);