crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In @0x/contracts-exchange: Update tests for rich reverts

Browse Source
This commit is contained in:
Lawrence Forman
2019-04-05 00:34:24 -04:00
committed by Amir Bandeali
parent 06499f2155
commit 20d8c1b51a
8 changed files with 217 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
contracts/exchange/test/dispatcher.ts
View File

@@ -9,7 +9,6 @@ import { DummyERC20TokenContract } from '@0x/contracts-erc20';
import {
chaiSetup,
constants,
expectTransactionFailedAsync,
LogDecoder,
orderUtils,
provider,
@@ -137,18 +136,16 @@ describe('AssetProxyDispatcher', () => {
txDefaults,
);
const expectedError = new ExchangeRevertErrors.AssetProxyExistsError(proxyAddress);
const tx = assetProxyDispatcher.registerAssetProxy.sendTransactionAsync(
newErc20TransferProxy.address,
{ from: owner },
);
const tx = assetProxyDispatcher.registerAssetProxy.sendTransactionAsync(newErc20TransferProxy.address, {
from: owner,
});
return expect(tx).to.revertWith(expectedError);
});
it('should throw if requesting address is not owner', async () => {
const tx = assetProxyDispatcher.registerAssetProxy.sendTransactionAsync(
erc20Proxy.address,
{ from: notOwner },
);
const tx = assetProxyDispatcher.registerAssetProxy.sendTransactionAsync(erc20Proxy.address, {
from: notOwner,
});
return expect(tx).to.revertWith(RevertReason.OnlyContractOwner);
});
@@ -279,7 +276,7 @@ describe('AssetProxyDispatcher', () => {
const expectedError = new ExchangeRevertErrors.AssetProxyDispatchError(
orderHash,
encodedAssetData,
ExchangeRevertErrors.AssetProxyDispatchErrorCodes.UnknownAssetProxy,
ExchangeRevertErrors.AssetProxyDispatchErrorCode.UnknownAssetProxy,
);
const tx = assetProxyDispatcher.publicDispatchTransferFrom.sendTransactionAsync(
orderHash,