improve logging for alt rfq request (#158)

* improve logging for alt rfq request

* clean up unsuccessful status code logic

* Fix quote requestor tests

* get rid of unnecessary promise handling

* remove unused code

* update changelog

* changed warning message for no quote

* appease prettier
This commit is contained in:
Alex Kroeger
2021-03-24 13:45:54 -07:00
committed by GitHub
parent 06b3464756
commit 24397c51a8
4 changed files with 53 additions and 12 deletions

View File

@@ -40,6 +40,8 @@ const ALT_RFQ_CREDS = {
altRfqProfile: ALT_PROFILE,
};
const CREATED_STATUS_CODE = 201;
function makeThreeMinuteExpiry(): BigNumber {
const expiry = new Date(Date.now());
expiry.setMinutes(expiry.getMinutes() + 3);
@@ -188,7 +190,7 @@ describe('QuoteRequestor', async () => {
altMockedRequests.push({
endpoint: 'https://132.0.0.1',
mmApiKey: ALT_MM_API_KEY,
responseCode: StatusCodes.Success,
responseCode: CREATED_STATUS_CODE,
requestData: altFirmRequestData,
responseData: altFirmResponse,
});
@@ -566,7 +568,7 @@ describe('QuoteRequestor', async () => {
altMockedRequests.push({
endpoint: 'https://132.0.0.1',
mmApiKey: ALT_MM_API_KEY,
responseCode: StatusCodes.Success,
responseCode: CREATED_STATUS_CODE,
requestData: buyAmountAltRequest,
responseData: buyAmountAltResponse,
});
@@ -612,7 +614,7 @@ describe('QuoteRequestor', async () => {
altMockedRequests.push({
endpoint: 'https://132.0.0.1',
mmApiKey: ALT_MM_API_KEY,
responseCode: StatusCodes.Success,
responseCode: CREATED_STATUS_CODE,
requestData: buyValueAltRequest,
responseData: buyValueAltResponse,
});
@@ -658,7 +660,7 @@ describe('QuoteRequestor', async () => {
altMockedRequests.push({
endpoint: 'https://132.0.0.1',
mmApiKey: ALT_MM_API_KEY,
responseCode: StatusCodes.Success,
responseCode: CREATED_STATUS_CODE,
requestData: sellAmountAltRequest,
responseData: sellAmountAltResponse,
});
@@ -704,7 +706,7 @@ describe('QuoteRequestor', async () => {
altMockedRequests.push({
endpoint: 'https://132.0.0.1',
mmApiKey: ALT_MM_API_KEY,
responseCode: StatusCodes.Success,
responseCode: CREATED_STATUS_CODE,
requestData: sellValueAltRequest,
responseData: sellValueAltResponse,
});