crowetic/protocol
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the typos

Browse Source
This commit is contained in:
Leonid Logvinov
2018-01-17 16:22:47 +01:00
parent 771f65c858
commit 278f68ae77
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/0x.js/CHANGELOG.md
View File

@@ -3,8 +3,8 @@
## v0.x.x - _TBD, 2018_
* Add an error parameter to the order watcher callback (#312)
* Fix the bug making it impossible to catch some errors from awaitTransactionMinedAsync (#312)
* Fix the bug in fillOrdersUpTo validation making it impossible to fill up to if user doesn't have enough balance to fully fill all the orders (#321)
* Fix a bug making it impossible to catch some errors from awaitTransactionMinedAsync (#312)
* Fix a bug in fillOrdersUpTo validation making it impossible to fill up to if user doesn't have enough balance to fully fill all the orders (#321)
## v0.29.1 - _January 11, 2018_

6
packages/0x.js/test/exchange_wrapper_test.ts
View File

@@ -550,7 +550,7 @@ describe('ExchangeWrapper', () => {
const remainingFillAmount = fillableAmount.minus(1);
expect(anotherFilledAmount).to.be.bignumber.equal(remainingFillAmount);
});
it('should successfully fill up to specified amount even if filling all orders will fail', async () => {
it('should successfully fill up to specified amount even if filling all orders would fail', async () => {
const missingBalance = new BigNumber(1); // User will still have enough balance to fill up to 9,
// but won't have 10 to fully fill all orders in a batch.
await zeroEx.token.transferAsync(makerTokenAddress, makerAddress, coinbase, missingBalance);
@@ -569,8 +569,8 @@ describe('ExchangeWrapper', () => {
});
});
describe('failed batch fills', () => {
it("should fail validation if user doesn't have enough balance wo fill up to", async () => {
const missingBalance = new BigNumber(2); // User will only have anough balance to fill up to 8
it("should fail validation if user doesn't have enough balance without fill up to", async () => {
const missingBalance = new BigNumber(2); // User will only have enough balance to fill up to 8
await zeroEx.token.transferAsync(makerTokenAddress, makerAddress, coinbase, missingBalance);
return expect(
zeroEx.exchange.fillOrdersUpToAsync(